Various cleanups: `<chrono>` - #4119

Merged

Stephan T. Lavavej (StephanTLavavej) merged 20 commits into

microsoft:mainfrom

StephanTLavavej:dry-cleaning-3-chrono-cleanups

Oct 26, 2023

Commits on Oct 23, 2023

chrono cleanups: Make `_THROW` a variadic macro so we never need extra parens.
Stephan T. Lavavej (StephanTLavavej)
committed
db3c7a1
chrono cleanups: Replace `decltype(tzdb::zones)` and `decltype(tzdb::links)` with their actual types.
Stephan T. Lavavej (StephanTLavavej)
committed
af77711
chrono cleanups: `_Crt_allocator` should provide equality.
Stephan T. Lavavej (StephanTLavavej)
committed
3cb601f
chrono cleanups: `time_zone` and `time_zone_link`'s internal constructors should be tagged.
Stephan T. Lavavej (StephanTLavavej)
committed
e6f5cb3
chrono cleanups: Return `const char*` as `string` without braces.
Stephan T. Lavavej (StephanTLavavej)
committed
67ab97d
chrono cleanups: Extract `_Make_unique_tzdb_info()`.
Stephan T. Lavavej (StephanTLavavej)
committed
de87607
chrono cleanups: `exchange()` the contained value instead of the entire `optional`.
Stephan T. Lavavej (StephanTLavavej)
committed
aa16fb5
chrono cleanups: Use positive test and early `return`.
Stephan T. Lavavej (StephanTLavavej)
committed
423374f
chrono cleanups: Drop empty line at the top of `_Make_time_point()`.
Stephan T. Lavavej (StephanTLavavej)
committed
d6179a1
chrono cleanups: Consistently say "leap second deletion" in comments.
Stephan T. Lavavej (StephanTLavavej)
committed
b3a28bd
chrono cleanups: `_InIt` is always `istreambuf_iterator`, not an arbitrary input iterator.
Stephan T. Lavavej (StephanTLavavej)
committed
aff9642
chrono cleanups: Use `const auto&` to avoid `_Ctype` typedef.
Stephan T. Lavavej (StephanTLavavej)
committed
29ee886
chrono cleanups: `'q'` and `'Q'` should always be given `duration`s, otherwise there's a logic error in `_Is_valid_type`.
Stephan T. Lavavej (StephanTLavavej)
committed
d99cc4f
chrono cleanups: Avoid dead `return`s after `if constexpr`.
Stephan T. Lavavej (StephanTLavavej)
committed
386d32f
chrono cleanups: `_Is_any_of_v` => `is_same_v` for one type.
Stephan T. Lavavej (StephanTLavavej)
committed
12caeeb
chrono test cleanups: Drop separate `res` variable used during debugging.
Stephan T. Lavavej (StephanTLavavej)
committed
1fdf9b5
chrono test cleanups: Consistently make `invalid` variables `constexpr`.
Stephan T. Lavavej (StephanTLavavej)
committed
5a51fcc
chrono cleanups: Drop performance note.
Stephan T. Lavavej (StephanTLavavej)
committed
2919534
chrono cleanups: Comment why `++_Begin` is safe.
Stephan T. Lavavej (StephanTLavavej)
committed
cde007a
chrono cleanups: Use `ios_base` with `_CATCH_IO_`.
Stephan T. Lavavej (StephanTLavavej)
committed
15223ed

Navigation Menu

Uh oh!

Various cleanups: `<chrono>` - #4119

Various cleanups: `<chrono>`#4119
Stephan T. Lavavej (StephanTLavavej) merged 20 commits into
microsoft:mainfrom
StephanTLavavej:dry-cleaning-3-chrono-cleanups

Commits on Oct 23, 2023

chrono cleanups: Make `_THROW` a variadic macro so we never need extra parens.

chrono cleanups: Replace `decltype(tzdb::zones)` and `decltype(tzdb::links)` with their actual types.

chrono cleanups: `_Crt_allocator` should provide equality.

chrono cleanups: `time_zone` and `time_zone_link`'s internal constructors should be tagged.

chrono cleanups: Return `const char*` as `string` without braces.

chrono cleanups: Extract `_Make_unique_tzdb_info()`.

chrono cleanups: `exchange()` the contained value instead of the entire `optional`.

chrono cleanups: Use positive test and early `return`.

chrono cleanups: Drop empty line at the top of `_Make_time_point()`.

chrono cleanups: Consistently say "leap second deletion" in comments.

chrono cleanups: `_InIt` is always `istreambuf_iterator`, not an arbitrary input iterator.

chrono cleanups: Use `const auto&` to avoid `_Ctype` typedef.

chrono cleanups: `'q'` and `'Q'` should always be given `duration`s, otherwise there's a logic error in `_Is_valid_type`.

chrono cleanups: Avoid dead `return`s after `if constexpr`.

chrono cleanups: `_Is_any_of_v` => `is_same_v` for one type.

chrono test cleanups: Drop separate `res` variable used during debugging.

chrono test cleanups: Consistently make `invalid` variables `constexpr`.

chrono cleanups: Drop performance note.

chrono cleanups: Comment why `++_Begin` is safe.

chrono cleanups: Use `ios_base` with `_CATCH_IO_`.