ASan: Remove noexcept from __sanitizer_annotate_contiguous_container - #4150
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoNov 7, 2023
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
November 6, 2023 18:24
nicole mazzuca (strega-nil-ms)
approved these changes
Nov 6, 2023
Contributor
|
If it throws, should be |
Casey Carter (CaseyCarter)
approved these changes
Nov 6, 2023
Contributor
I don't believe it does throw, I think it's simply unannotated. This is common for shared C/C++ headers: it's easy to stick a conditional Ideally we would fix this upstream and then bring it back here. |
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4106 marked
__sanitizer_annotate_contiguous_containerasnoexceptbecause it'sextern "C". However, it has to match ASan's primary declaration, so we can't mark it.This PR reverts this declaration to its original form, and adds a comment for future maintainers.