Skip to content

<type_traits>: Workaround for DevCom-10543093 (ICE with some uses of pointers to data members) #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into from
Jan 11, 2024
Merged

<type_traits>: Workaround for DevCom-10543093 (ICE with some uses of pointers to data members) #4277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stl/inc/type_traits
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1746,7 +1746,12 @@ constexpr auto invoke(_Callable&& _Obj, _Ty1&& _Arg1, _Types2&&... _Args2) noexc
} else if constexpr (_Invoker1<_Callable, _Ty1>::_Strategy == _Invoker_strategy::_Pmd_object) {
return static_cast<_Ty1&&>(_Arg1).*_Obj;
} else if constexpr (_Invoker1<_Callable, _Ty1>::_Strategy == _Invoker_strategy::_Pmd_refwrap) {
#if defined(__clang__) || defined(__EDG__) // TRANSITION, DevCom-10543093
return _Arg1.get().*_Obj;
#else // ^^^ no workaround / workaround vvv
auto& _Ref = _Arg1.get();
return _Ref.*_Obj;
#endif // ^^^ workaround ^^^
} else {
_STL_INTERNAL_STATIC_ASSERT(_Invoker1<_Callable, _Ty1>::_Strategy == _Invoker_strategy::_Pmd_pointer);
return (*static_cast<_Ty1&&>(_Arg1)).*_Obj;
Expand Down
4 changes: 0 additions & 4 deletions tests/libcxx/expected_results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,10 +869,6 @@ std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp SKIPPED
# Not analyzed. Failing after LLVM-D75622.
std/re/re.const/re.matchflag/match_prev_avail.pass.cpp FAIL

# Not analyzed. Possibly C1XX constexpr bug.
std/utilities/function.objects/func.invoke/invoke_constexpr.pass.cpp:0 FAIL
std/utilities/function.objects/func.invoke/invoke_constexpr.pass.cpp:1 FAIL

# Not analyzed. Failing for "[a[.ch.]z]".
std/re/re.alg/re.alg.match/awk.locale.pass.cpp FAIL
std/re/re.alg/re.alg.match/basic.locale.pass.cpp FAIL
Expand Down