<generator>: Don't use operator new[] and operator delete[] - #4621
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoMay 10, 2024
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
April 23, 2024 18:05
This comment was marked as resolved.
This comment was marked as resolved.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
May 10, 2024
<generator>: Don't use new[] and delete[] operators<generator>: Don't use operator new[] and operator delete[]
Stephan T. Lavavej (StephanTLavavej)
merged commit May 10, 2024
7ad2c73
into
microsoft:feature/generator
Member
|
Great catch! 😺 I adjusted the PR title due to a mega-nitpick - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Promise_allocator<void>'soperator new(size_t)is specified to allocate memory withallocator<_Aligned_block>(see [coro.generator.promise]/17), which internally uses::operator new, not::operator new[](see [allocator.members]/5).