Fix atomic_ref::is_lock_free() on x64 - #4729
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoJun 27, 2024
Merged
Conversation
For `!_ATOMIC_HAS_DCAS`: If we're `is_always_lock_free` (power of two, at most 1 pointer), return true. Otherwise, we have to be `_Is_potentially_lock_free` (power of two, at most 2 pointers) and have cmpxchg16b.
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
June 16, 2024 17:22
Closed
Co-authored-by: Alex Guteniev <gutenev@gmail.com>
Member
Author
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Charlie Barto (barcharcraz)
approved these changes
Jun 27, 2024
Stephan T. Lavavej (StephanTLavavej)
deleted the
fix-atomic_ref-is_lock_free
branch
June 27, 2024 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4728.
For
!_ATOMIC_HAS_DCAS:is_always_lock_free(power of two, at most 1 pointer), return true._Is_potentially_lock_free(power of two, at most 2 pointers) and have cmpxchg16b.