Always use cmpxchg16b on x64 for `atomic_ref<16 bytes>` - #4751

Merged

Stephan T. Lavavej (StephanTLavavej) merged 20 commits into

microsoft:mainfrom

StephanTLavavej:cmpxchg16b

Jul 5, 2024

Commits on Jun 27, 2024

Simplify `__std_atomic_has_cmpxchg16b`: cmpxchg16b is always available for 64-bit Win8.1 / Server 2012 R2.
Stephan T. Lavavej (StephanTLavavej)
committed
be1dabe
Simplify `__std_atomic_compare_exchange_128` accordingly.
Stephan T. Lavavej (StephanTLavavej)
committed
b16508d
`__std_atomic_compare_exchange_128` and `__std_atomic_has_cmpxchg16b` should `abort` for 32-bit.
Stephan T. Lavavej (StephanTLavavej)
committed
bad4814
Preserve `__std_atomic_compare_exchange_128` for bincompat.
Stephan T. Lavavej (StephanTLavavej)
committed
7bf2aa7
Replace the `_STD_COMPARE_EXCHANGE_128` macro with `_InterlockedCompareExchange128`.
Stephan T. Lavavej (StephanTLavavej)
committed
e3a9a91
Allow Clang x64 to use `_InterlockedCompareExchange128`.
Stephan T. Lavavej (StephanTLavavej)
committed
60798a3
Simplify the "future ABI" `atomic<T>::is_lock_free()`.
Stephan T. Lavavej (StephanTLavavej)
committed
c7261ef
Major style: Add parens when mixing arithmetic and bitwise operators in "current ABI" `atomic<T>::is_lock_free()`.
Stephan T. Lavavej (StephanTLavavej)
committed
72349d3
Minor style: Simplify `atomic<T>::is_lock_free()`.
Stephan T. Lavavej (StephanTLavavej)
committed
6411c97
Enhance the "future ABI" `_Is_always_lock_free` (aka `atomic<T>::is_always_lock_free`).
Stephan T. Lavavej (StephanTLavavej)
committed
b855bb9
Centralize `atomic<T>::is_lock_free()` and `_Is_always_lock_free`.
Stephan T. Lavavej (StephanTLavavej)
committed
ea085c5
`atomic_ref::is_lock_free()`: Simplify.
Stephan T. Lavavej (StephanTLavavej)
committed
c468e9e
`atomic_ref::is_lock_free()`: Further simplify.
Stephan T. Lavavej (StephanTLavavej)
committed
3861e48
Enhance `atomic_ref::is_always_lock_free`.
Stephan T. Lavavej (StephanTLavavej)
committed
0e17494
Collapse `atomic_ref` `is_always_lock_free` and `is_lock_free()`.
Stephan T. Lavavej (StephanTLavavej)
committed
fe82b0c
`_ATOMIC_HAS_DCAS` is now unused.
Stephan T. Lavavej (StephanTLavavej)
committed
0c46d60
Preserve `__std_atomic_has_cmpxchg16b` for bincompat.
Stephan T. Lavavej (StephanTLavavej)
committed
ba77cd1
Drop `_STD_ATOMIC_ALWAYS_USE_CMPXCHG16B` and simplify test coverage.
Stephan T. Lavavej (StephanTLavavej)
committed
96d86e7
`_STL_WIN32_WINNT_WINBLUE` is now unused.
Stephan T. Lavavej (StephanTLavavej)
committed
537bc95

Commits on Jun 28, 2024

Silence unreferenced parameter warnings for 32-bit.
Stephan T. Lavavej (StephanTLavavej)
committed
e13d679

Navigation Menu

Uh oh!

Always use cmpxchg16b on x64 for `atomic_ref<16 bytes>` - #4751

Always use cmpxchg16b on x64 for `atomic_ref<16 bytes>`#4751
Stephan T. Lavavej (StephanTLavavej) merged 20 commits into
microsoft:mainfrom
StephanTLavavej:cmpxchg16b

Commits on Jun 27, 2024

Simplify `__std_atomic_has_cmpxchg16b`: cmpxchg16b is always available for 64-bit Win8.1 / Server 2012 R2.

Simplify `__std_atomic_compare_exchange_128` accordingly.

`__std_atomic_compare_exchange_128` and `__std_atomic_has_cmpxchg16b` should `abort` for 32-bit.

Preserve `__std_atomic_compare_exchange_128` for bincompat.

Replace the `_STD_COMPARE_EXCHANGE_128` macro with `_InterlockedCompareExchange128`.

Allow Clang x64 to use `_InterlockedCompareExchange128`.

Simplify the "future ABI" `atomic<T>::is_lock_free()`.

Major style: Add parens when mixing arithmetic and bitwise operators in "current ABI" `atomic<T>::is_lock_free()`.

Minor style: Simplify `atomic<T>::is_lock_free()`.

Enhance the "future ABI" `_Is_always_lock_free` (aka `atomic<T>::is_always_lock_free`).

Centralize `atomic<T>::is_lock_free()` and `_Is_always_lock_free`.

`atomic_ref::is_lock_free()`: Simplify.

`atomic_ref::is_lock_free()`: Further simplify.

Enhance `atomic_ref::is_always_lock_free`.

Collapse `atomic_ref` `is_always_lock_free` and `is_lock_free()`.

`_ATOMIC_HAS_DCAS` is now unused.

Preserve `__std_atomic_has_cmpxchg16b` for bincompat.

Drop `_STD_ATOMIC_ALWAYS_USE_CMPXCHG16B` and simplify test coverage.

`_STL_WIN32_WINNT_WINBLUE` is now unused.

Commits on Jun 28, 2024

Silence unreferenced parameter warnings for 32-bit.