<regex>: Silence CodeQL false positive warning - #5072
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoNov 14, 2024
Merged
<regex>: Silence CodeQL false positive warning#5072Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
<regex>: Silence CodeQL false positive warning#5072Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
November 10, 2024 19:08
Closed
Casey Carter (CaseyCarter)
approved these changes
Nov 11, 2024
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows encountered internal OS-50456631 "[CodeQL:Warning]: SM02323: cpp/infiniteloop (in packages/[...]/regex)", reported to me by Ryan Shepherd (@DefaultRyan). According to the internal doc, this is:
In this case, the warning is a false positive, and my suppression comment explains why.
Alternatively, we could widen the
unsigned inttosize_t, either with astatic_castor a named variable, but that'd be unusual enough to still merit a comment, so I chose the less invasive approach.