Skip to content

Implement range_size_t #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Casey Carter (CaseyCarter) merged 5 commits into from
Mar 5, 2020
Merged

Implement range_size_t #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74b5cdf
Implement range_size_t
miscco Feb 19, 2020
c360fa7
Add test
miscco Feb 19, 2020
2b1c509
constrain range_size_t with sized_range instead of range
CaseyCarter Feb 21, 2020
c8607d0
Oops - move definition of range_size_t after definition of sized_range
CaseyCarter Feb 21, 2020
dbe9bb8
Test negative cases for range_size_t also
CaseyCarter Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions stl/inc/xutility
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2636,6 +2636,10 @@ namespace ranges {
&& requires(_Rng& __r) { _RANGES size(__r); };
// clang-format on

// ALIAS TEMPLATE ranges::range_size_t
template <sized_range _Rng>
using range_size_t = decltype(_RANGES size(_STD declval<_Rng&>()));

// STRUCT ranges::view_base
struct view_base {};

Expand Down
5 changes: 5 additions & 0 deletions tests/std/tests/P0896R4_ranges_range_machinery/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ concept CanEmpty = requires(R&& r) { ranges::empty(std::forward<R>(r)); };
template <class R>
concept CanSize = requires(R&& r) { ranges::size(std::forward<R>(r)); };

template <class R>
concept CanSizeType = requires { typename ranges::range_size_t<R>; };

template <class R>
concept CanData = requires(R&& r) { ranges::data(std::forward<R>(r)); };

Expand Down Expand Up @@ -321,9 +324,11 @@ constexpr bool test_size() {
STATIC_ASSERT(!is_valid<Size> || std::integral<Size>);

STATIC_ASSERT(CanSize<Range> == is_valid<Size>);
STATIC_ASSERT(CanSizeType<Range> == is_valid<Size>);
STATIC_ASSERT(ranges::sized_range<Range> == is_valid<Size>);
if constexpr (is_valid<Size>) {
STATIC_ASSERT(std::same_as<decltype(ranges::size(std::declval<Range>())), Size>);
STATIC_ASSERT(std::same_as<ranges::range_size_t<Range>, Size>);

STATIC_ASSERT(CanEmpty<Range>);
}
Expand Down