Skip to content

Expand workaround for EDG bug in P0323R12_expected #5249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into from
Jan 24, 2025
Merged

Expand workaround for EDG bug in P0323R12_expected #5249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8c4b23
Drive-by: Don't bother to implement some member functions that aren't…
StephanTLavavej Jan 24, 2025
f401839
Expand workaround for EDG bug in `P0323R12_expected`
StephanTLavavej Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions tests/std/tests/P0323R12_expected/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2476,24 +2476,17 @@ static_assert(test_inherited_constructors());
template <class T, class E>
struct ambiguating_expected_copy_constructor_caller {
struct const_lvalue_taker {
const_lvalue_taker(const expected<T, E>&) {}
const_lvalue_taker(const expected<T, E>&);
};

void operator()(expected<T, E>) {}
void operator()(const_lvalue_taker) {}
void operator()(expected<T, E>);
void operator()(const_lvalue_taker);
};

template <class T, class E>
struct ambiguating_expected_assignment_source {
operator const expected<T, E>&() && {
return ex;
}

operator expected<T, E>&&() && {
return move(ex);
}

expected<T, E> ex;
operator const expected<T, E>&() &&;
operator expected<T, E>&&() &&;
};

struct move_only {
Expand All @@ -2512,9 +2505,9 @@ static_assert(
#ifndef __EDG__ // TRANSITION, VSO-1601179
static_assert(!is_assignable_v<expected<int, char>&, ambiguating_expected_assignment_source<int, char>>);
static_assert(!is_assignable_v<expected<void, int>&, ambiguating_expected_assignment_source<void, int>>);
#endif // ^^^ no workaround ^^^
static_assert(!is_assignable_v<expected<move_only, char>&, ambiguating_expected_assignment_source<move_only, char>>);
static_assert(!is_assignable_v<expected<void, move_only>&, ambiguating_expected_assignment_source<void, move_only>>);
#endif // ^^^ no workaround ^^^

static_assert(test_lwg_3886());

Expand Down