<barrier>: Fix constructor's exception specification - #5398
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoApr 22, 2025
Merged
Conversation
Jakub Mazurkiewicz (JMazurkiewicz)
requested a review
from a team
as a code owner
April 10, 2025 15:19
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 14, 2025
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for noticing and fixing this bug! 🐞 🕵️ 🛠️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
barrier's constructor is unconditionallynoexcept, but according to[thread.barrier.class]/11this is incorrect. This PR fixes the problem by changing exception specification fromnoexcept(true)tonoexcept(is_nothrow_move_constructible_v<_Completion_function>).