Skip to content

<flat_map>: explain test failures caused by being moved-out #5451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into from
May 1, 2025
Merged

<flat_map>: explain test failures caused by being moved-out #5451

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c0e465
`<flat_map>`: explain test failures caused by move
AlexGuteniev Apr 30, 2025
20f6068
mention P3567R0
AlexGuteniev Apr 30, 2025
44636fa
expand explaination
AlexGuteniev May 1, 2025
8f9d263
non-bougs now
AlexGuteniev May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions tests/libcxx/expected_results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,17 +236,23 @@ std/strings/c.strings/cuchar.compile.pass.cpp FAIL
std/containers/container.adaptors/flat.map/flat.map.cons/deduct.pass.cpp FAIL
std/containers/container.adaptors/flat.multimap/flat.multimap.cons/deduct.pass.cpp FAIL

# FIXME! Assertion failed: mo.empty()
std/containers/container.adaptors/flat.map/flat.map.cons/move_alloc.pass.cpp FAIL
std/containers/container.adaptors/flat.multimap/flat.multimap.cons/move_alloc.pass.cpp FAIL

# FIXME! Assertion failed: m.keys().size() == m.values().size()
# [flat.map.defn] doesn't declare a move constructor, which seems to imply that moving from a flat_map should behave
# as if the move constructor were implicitly defined, i.e. it can't restore the invariants
# P2767R2 does not specify move constructor, which is broken
# P3567R0 adds a move constructor that asks to restore invariants
# P3567R0 constructor also moves comparator, which we should veto if it makes into the Standard
std/containers/container.adaptors/flat.map/flat.map.cons/move_assign_clears.pass.cpp FAIL
std/containers/container.adaptors/flat.map/flat.map.cons/move_exceptions.pass.cpp FAIL
std/containers/container.adaptors/flat.multimap/flat.multimap.cons/move_assign_clears.pass.cpp FAIL
std/containers/container.adaptors/flat.multimap/flat.multimap.cons/move_exceptions.pass.cpp FAIL

# FIXME! abort() has been called
# caused by insert failing when called on a moved-from flat_map due to its comparator being moved from,
# but this seems to be in line with the specification: flat_map::insert transitively requires that the comparator
# "induce a strict weak ordering on the values"
# P2767R2 does not specify move constructor, which is broken
# P3567R0 constructor is still asked to move comparator, which is also broken
std/containers/container.adaptors/flat.map/flat.map.cons/move.pass.cpp FAIL
std/containers/container.adaptors/flat.multimap/flat.multimap.cons/move.pass.cpp FAIL

Expand Down Expand Up @@ -591,6 +597,10 @@ std/depr/depr.c.headers/stddef_h.compile.pass.cpp:1 FAIL

# *** LIKELY BOGUS TESTS ***

# A moved-from flat_map is not empty, which doesn't seem to be required
std/containers/container.adaptors/flat.map/flat.map.cons/move_alloc.pass.cpp FAIL
std/containers/container.adaptors/flat.multimap/flat.multimap.cons/move_alloc.pass.cpp FAIL

# Test bug after LWG-2899 "is_(nothrow_)move_constructible and tuple, optional and unique_ptr" was accepted.
std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move_convert.pass.cpp FAIL
std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move_convert.runtime.pass.cpp FAIL
Expand Down