vector_algorithms.cpp: avoid unaligned access - #5760
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoOct 10, 2025
Merged
Conversation
Contributor
Author
|
I didn't run with UBSan. Whereas |
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Oct 8, 2025
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Oct 10, 2025
f3eff99
into
microsoft:main
39 checks passed
Member
|
Thanks for fixing the alignment problem! 🤖 📈 💥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5741
The unaligned access here could happen without misalignment from the user side: the original arrays could be of a type with a smaller alignment.
I have not found other instances of unaligned access due to integral cast
vector_algorithms.cpp: avoid cast to integral in__std_bitset_from_string_N#5759 is different as it only was unaligned access when the bitset itself is unaligned, so there the user is to blame