Skip to content

Add "/build/" to the .gitignore - #581

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
SuperWig:git
Mar 8, 2020
Merged

Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
SuperWig:git

Conversation

@SuperWig

Copy link
Copy Markdown
Contributor

What the title says.
I assume most people who aren't using Visual Studio would use build instead of out.

@SuperWig
Daniel Marshall (SuperWig) requested a review from a team as a code owner March 3, 2020 10:41
@BillyONeal

Copy link
Copy Markdown
Member

This seems like something you should put in your .git/info/exclude rather than in the shared repository, since we don't mean anything special by a directory named "build". However, I don't see specific harm in doing this, we already exclude "out" for a similar reason, and we are unlikely to use that name "build" for anything else....

@SuperWig

Copy link
Copy Markdown
Contributor Author

we already exclude "out" for a similar reason, and we are unlikely to use that name "build" for anything else....

Essentially my entire line of thinking :P

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, OK.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how someone would end up with a /build/ directory (what process would they be following, and why isn't it in our documentation?) but I have no objection to this change.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the enhancement Something can be improved label Mar 3, 2020
@SuperWig

Daniel Marshall (SuperWig) commented Mar 4, 2020

Copy link
Copy Markdown
Contributor Author

I'm not sure how someone would end up with a /build/ directory

As stated in this comment #572 (comment) using VS Code and the CMake Tools extension, that has build as the default build directory.

(Apparently I can't type on mobile without accidentally tapping on comment and close pull request).

@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for this small improvement! 😸

Stephan T. Lavavej (StephanTLavavej) added a commit to StephanTLavavej/STL that referenced this pull request Apr 29, 2020
This essentially replicates the information in `.gitignore`,
where `/build/` was added by microsoft#581.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants