Clang support for LWG-3617 function/packaged_task deduction guides and deducing this - #5921
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoDec 1, 2025
Conversation
This should have been done for Clang 19.
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
December 1, 2025 09:17
Merged
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Zack Johnson (zacklj89)
approved these changes
Dec 1, 2025
Zack Johnson (zacklj89)
left a comment
There was a problem hiding this comment.
Did this come to you in a thanksgiving fever dream? 🤣
Stephan T. Lavavej (StephanTLavavej)
merged commit Dec 1, 2025
f9db62a
into
microsoft:main
45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We merged #2966 on 2022-08-05, shipped in VS 2022 17.4, for MSVC and EDG. At that time, we were requiring Clang 14, which didn't support "deducing
this".In VS 2022 17.14, we began requiring Clang 19, which added support for "deducing
this". I didn't notice this in #5247 merged on 2025-01-24. Nobody else noticed either, but it's my job! 😹We should activate the product and test code for this LWG issue resolution for Clang now.