Skip to content

<flat_map> <flat_set>: Add _NODISCARD, remove nested _Clear_guard, add precondition checks etc. #5953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 26 commits into from
Dec 12, 2025
Merged

<flat_map> <flat_set>: Add _NODISCARD, remove nested _Clear_guard, add precondition checks etc. #5953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6f6c88b
Add _NODISCARD to flat_map and flat_set.
vmichal Dec 9, 2025
bdd8da9
Don't query the nothrow_move_constructibility of flat_map::key_compar…
vmichal Dec 9, 2025
6ca26ba
flat_map::_Extract_using_allocator should be rvalue-ref qualified.
vmichal Dec 9, 2025
c42901c
Make flat_map::extract consistent with flat_set::extract.
vmichal Dec 9, 2025
85d1c99
flat_set::_Erase should not pessimize performance for different _Ty a…
vmichal Dec 9, 2025
d7085de
Some libcxx tests have to be FAILed due to throwing move constructor …
vmichal Dec 9, 2025
9b185b8
Remove nested _Clear_guards form flat_map
vmichal Dec 9, 2025
12e6cd1
Make newlines between functions in <flat_set> consistent (remove between
vmichal Dec 9, 2025
6310395
Add precondition checks to flat_map
vmichal Dec 9, 2025
cd91e3a
consistently use typedef key_compare instead of template parameter _C…
vmichal Dec 9, 2025
359d1aa
Fix formatting.
vmichal Dec 9, 2025
2de5450
_Flat_map_base::_Is_sorted should not be template.
vmichal Dec 9, 2025
571d39e
Wrap _Flat_map_base::_Key_compare with _Pass_fn when calling standard…
vmichal Dec 9, 2025
25fa916
Correct formatting.
vmichal Dec 9, 2025
d0a4fa3
Introduce a helper function to call _Pass_fn in flat_map.
vmichal Dec 9, 2025
62a3fca
Start to unify implementation of deduplication between flat_map and f…
vmichal Dec 9, 2025
0f1b93b
Make begin/end available when including <flat_map>
vmichal Dec 9, 2025
3f5513e
Reference correct standard WP in comments.
vmichal Dec 9, 2025
7d56088
Correct formatting.
vmichal Dec 9, 2025
5a5fc46
Use ranges::sort instead of std::sort.
vmichal Dec 10, 2025
f5eb328
Mention that FAILed libcxx tests are due to different resolution of L…
vmichal Dec 10, 2025
45defb2
Merge branch 'feature/flat_map' into flat-map-nodiscard
StephanTLavavej Dec 12, 2025
fe77c32
Fix/update citations.
StephanTLavavej Dec 12, 2025
af4f932
Consistently use the `_Always_clear` name.
StephanTLavavej Dec 12, 2025
9d30377
All shall love `adjacent_find()` and despair.
StephanTLavavej Dec 12, 2025
c8b7bf1
Categorize LWG-2227 divergence as "likely bogus tests", not "missing …
StephanTLavavej Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading