constexpr for std::array Comparisons - #599
Merged
Gianni Georg Weinand (ggweinand) merged 18 commits intoMar 31, 2020
Merged
Conversation
Gianni Georg Weinand (ggweinand)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
March 11, 2020 00:07
Gianni Georg Weinand (ggweinand)
requested a review
from a team
as a code owner
March 11, 2020 00:07
Stephan T. Lavavej (StephanTLavavej)
requested changes
Mar 11, 2020
Merged
4 tasks
Gianni Georg Weinand (ggweinand)
force-pushed
the
constexprForArrayComparisons
branch
2 times, most recently
from
March 19, 2020 02:17
9f112b4 to
80b5623
Compare
Casey Carter (CaseyCarter)
suggested changes
Mar 23, 2020
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Gianni Georg Weinand (ggweinand)
force-pushed
the
constexprForArrayComparisons
branch
from
March 27, 2020 02:20
e1c2a15 to
09b6b49
Compare
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 27, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good! Minor suggestions.
Casey Carter (CaseyCarter)
approved these changes
Mar 29, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 29, 2020
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net>
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net>
Gianni Georg Weinand (ggweinand)
force-pushed
the
constexprForArrayComparisons
branch
from
March 30, 2020 22:17
17eb416 to
c187f72
Compare
Casey Carter (CaseyCarter)
suggested changes
Mar 31, 2020
Casey Carter (CaseyCarter)
approved these changes
Mar 31, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 31, 2020
Member
|
Congratulations on checking in your first C++20 feature, @Weheineman! 😸 |
Contributor
|
Congratulations 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #49.
stl/inc/array: The functions whereconstexprneeded to be added just called other functions which are nowconstexpr, so only_CONSTEXPR20was added.stl/inc/yvals_core.h: Modified the definition of the feature test macro__cpp_lib_array_constexprfor cxx20 mode.tests/std/tests/VSO_0157762_feature_test_macros/test.cpp: Added test coverage for__cpp_lib_array_constexprin cxx20 mode.Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.