Skip to content

<regex>: Add test coverage for capture group reset between match attempts in regex_search() #6122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into from
Mar 4, 2026
Merged

<regex>: Add test coverage for capture group reset between match attempts in regex_search() #6122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/std/tests/VSO_0000000_regex_use/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2441,6 +2441,20 @@ void test_gh_6022() {
g_regexTester.should_match("abaaacaabaaaadab", R"((?:(a*)b(\1*)a*c)+aabaaaad\2b)");
}

void test_gh_6118() {
// GH-6118: regex_search() sometimes incorrectly matches capturing groups
// regex_search() failed to reset capture groups between match attempts.
{
test_regex re_matching_inbetween(&g_regexTester, "a|(b)c");
re_matching_inbetween.should_search_match_capture_groups("ba", "a", match_default, {{-1, -1}});
}

{
test_regex re_matching_at_end(&g_regexTester, "$|(b)c");
re_matching_at_end.should_search_match_capture_groups("b", "", match_default, {{-1, -1}});
}
}

int main() {
test_dev10_449367_case_insensitivity_should_work();
test_dev11_462743_regex_collate_should_not_disable_regex_icase();
Expand Down Expand Up @@ -2503,6 +2517,7 @@ int main() {
test_gh_5939();
test_gh_5944();
test_gh_6022();
test_gh_6118();

return g_regexTester.result();
}