Skip to content

Vector algorithms: trim runtime coverage for ARM64EC non-vectorized fallbacks - #6142

Merged
Stephan T. Lavavej (StephanTLavavej) merged 7 commits into
microsoft:mainfrom
AlexGuteniev:trim-fallback
Mar 10, 2026
Merged

Vector algorithms: trim runtime coverage for ARM64EC non-vectorized fallbacks#6142
Stephan T. Lavavej (StephanTLavavej) merged 7 commits into
microsoft:mainfrom
AlexGuteniev:trim-fallback

Conversation

@AlexGuteniev

@AlexGuteniev Alex Guteniev (AlexGuteniev) commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Follow up on #6107.

We can't have complexity in test matrices, especially for internal test runs, so let's trim the excess coverage otherwise.

I know it still adds some complexity in another place, so it is still controversial.

Trim random coverage, which is time-consuming, for the algorithms that are vectorized everywhere and don't have fallbacks.
After #6141, #6139, and #6143 this excludes all string algorithms. The following are left: bitset, replace, and minmax_element for 64-bit integers and pointers.

Deliberately avoided checking for _VECTORIZED_* macros. We still need _USE_STD_VECTOR_ALGORITHMS=0 coverage intact, and we need the machinery to be tested independently.

Comment thread tests/std/tests/VSO_0000000_vector_algorithms/test.cpp Outdated
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added test Related to test code ARM64EC I can't believe it's not x64! labels Mar 5, 2026
Comment thread tests/std/tests/VSO_0000000_vector_algorithms/test.cpp Outdated
Comment thread tests/std/tests/VSO_0000000_vector_algorithms/test.cpp Outdated
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 6, 2026
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) moved this from Ready To Merge to Merging in STL Code Reviews Mar 9, 2026
@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit fab6100 into microsoft:main Mar 10, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Merging to Done in STL Code Reviews Mar 10, 2026
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for keeping our test harness running efficiently! ⏱️ ✅ 😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARM64EC I can't believe it's not x64! test Related to test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants