Add /INFERASANLIBS to the Clang ARM64 workarounds - #6163
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoMar 16, 2026
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
March 16, 2026 19:30
Contributor
|
But should you then undo the Github harness change to also rely on the pragma, like the internal harness? |
Member
Author
|
I don't understand nearly enough about what's going on with the blizzard of ASan configurations and options to mess with this any more than I absolutely have to. |
David Justo (davidmrdavid)
approved these changes
Mar 16, 2026
Zack Johnson (zacklj89)
approved these changes
Mar 16, 2026
Stephan T. Lavavej (StephanTLavavej)
merged commit Mar 16, 2026
2626cf1
into
microsoft:main
49 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #6157's sub-commit "Tests: Enable ASan annotation tests for ARM64, except Clang."
The MSVC-internal test harness lacks this workaround:
STL/tests/utils/stl/test/tests.py
Lines 349 to 351 in 83a261c
And to work around llvm/llvm-project#184902 everywhere (GitHub and MSVC), I had to avoid all
#includedirectives (which could drag in global initializers that would then crash due to the compiler bug), which also avoided picking up:STL/stl/inc/__msvc_sanitizer_annotate_container.hpp
Lines 71 to 81 in 83a261c
The result is that these tests, newly enabled for ARM64, became successfully empty-ish for GitHub (compiled with
-fsanitize=addressand linked with/INFERASANLIBS), but failed to link for the MSVC-internal test harness (compiled with-fsanitize=address, but not linked with/INFERASANLIBS).Adding these pragmas to the workaround paths should get the Clang ARM64 configurations passing internally. Reverse-mirrored from MSVC-PR-718376 where I'm verifying that.
(This wasn't noticed until after merging, because the MSVC-internal test harness doesn't run ARM64 by default for PRs, only in CIs. Why yes I am having an excellent Monday, why do you ask.)