Workaround for MSVC's constexpr array allocation bug for vector - #6177
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoMar 27, 2026
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Mar 25, 2026
Member
|
I'm mirroring this to the MSVC-internal repo. Please notify me if any further changes are pushed, otherwise no action is required. |
Stephan T. Lavavej (StephanTLavavej)
merged commit Mar 27, 2026
05b4b08
into
microsoft:main
49 checks passed
Member
|
Thanks for reporting and working around this bug! 😻 🕵️ 🪲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds workaround for DevCom-11060638 needed for
vector. Closes #6155.Due the implementation strategy of MSVC, if a user directly uses
allocator<T[N]>::allocate, the behavior in constant evaluation is still broken. There doesn't seem any possible workaround in the library implementation for this.