Skip to content

P0811R3_midpoint_lerp: Avoid flaky ARM64/ARM64EC failures #6266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into from
Apr 29, 2026
Merged

P0811R3_midpoint_lerp: Avoid flaky ARM64/ARM64EC failures #6266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions tests/std/tests/P0811R3_midpoint_lerp/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,13 @@ constexpr int fe_overflow = FE_OVERFLOW;
// "major" floating point exceptions, excluding underflow and inexact
constexpr int fe_major_except = FE_INVALID | FE_DIVBYZERO | FE_OVERFLOW;

bool check_feexcept(const int expected_excepts, const int except_mask = fe_major_except) {
bool check_feexcept(
[[maybe_unused]] const int expected_excepts, [[maybe_unused]] const int except_mask = fe_major_except) {
#if defined(_M_ARM64) || defined(_M_ARM64EC) // TRANSITION, GH-5685
return true;
#else // ^^^ workaround / no workaround vvv
return fetestexcept(except_mask) == (expected_excepts & except_mask);
#endif // ^^^ no workaround ^^^
}
#else // ^^^ defined(_M_FP_STRICT) / !defined(_M_FP_STRICT) vvv
class ExceptGuard {
Expand Down Expand Up @@ -1049,9 +1054,7 @@ void test_gh_1917() {
ExceptGuard except;

assert(bit_cast<float_bit_type>(lerp(2e+38f, 1e+38f, 4.0f)) == bit_cast<float_bit_type>(-2e+38f));
#if !defined(_M_ARM64) && !defined(_M_ARM64EC) // TRANSITION, GH-5685
assert(check_feexcept(0));
#endif // ^^^ no workaround ^^^
}
#ifdef _M_FP_STRICT
{
Expand All @@ -1066,9 +1069,7 @@ void test_gh_1917() {
RoundGuard round{FE_UPWARD};

assert(bit_cast<float_bit_type>(lerp(2e+38f, 1e+38f, 4.0f)) == bit_cast<float_bit_type>(-2e+38f));
#if !defined(_M_ARM64) && !defined(_M_ARM64EC) // TRANSITION, GH-5685
assert(check_feexcept(0));
#endif // ^^^ no workaround ^^^
}
{
ExceptGuard except;
Expand All @@ -1082,9 +1083,7 @@ void test_gh_1917() {
RoundGuard round{FE_DOWNWARD};

assert(bit_cast<float_bit_type>(lerp(2e+38f, 1e+38f, 4.0f)) == bit_cast<float_bit_type>(-2e+38f));
#if !defined(_M_ARM64) && !defined(_M_ARM64EC) // TRANSITION, GH-5685
assert(check_feexcept(0));
#endif // ^^^ no workaround ^^^
}
{
ExceptGuard except;
Expand All @@ -1098,9 +1097,7 @@ void test_gh_1917() {
RoundGuard round{FE_TOWARDZERO};

assert(bit_cast<float_bit_type>(lerp(2e+38f, 1e+38f, 4.0f)) == bit_cast<float_bit_type>(-2e+38f));
#if !defined(_M_ARM64) && !defined(_M_ARM64EC) // TRANSITION, GH-5685
assert(check_feexcept(0));
#endif // ^^^ no workaround ^^^
}
{
ExceptGuard except;
Expand Down