Skip to content

Silence new warning C4877 when overriding deprecated non-pure virtual functions #6279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into from
May 15, 2026
Merged

Silence new warning C4877 when overriding deprecated non-pure virtual functions #6279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21dc1aa
Pre-existing: ABI warning C5291 is off-by-default.
StephanTLavavej May 8, 2026
ad4bb5e
Add new off-by-default warning C4877 to `_STL_DISABLE_DEPRECATED_WARN…
StephanTLavavej May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions stl/inc/yvals_core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@
// warning C5285: cannot declare a specialization for 'meow'
// warning C5291: 'DERIVED': deriving from the base class 'BASE' can cause potential runtime issues
// due to an ABI bug. Recommend adding a 4-byte data member to the base class
// for the padding at the end of it to work around this bug. (TRANSITION, ABI)
// for the padding at the end of it to work around this bug. (/Wall, TRANSITION, ABI)
// warning C6294: Ill-defined for-loop: initial condition does not satisfy test. Loop body not executed

#ifndef _STL_DISABLED_WARNINGS
Expand Down Expand Up @@ -886,9 +886,11 @@
_Pragma("clang diagnostic push") \
_Pragma("clang diagnostic ignored \"-Wdeprecated-declarations\"")
#else // ^^^ defined(__clang__) / !defined(__clang__) vvv
// warning C4877: overriding non-pure virtual function 'Base::meow': was declared deprecated (/Wall)
// warning C4996: 'meow': was declared deprecated
Comment thread
StephanTLavavej marked this conversation as resolved.
#define _STL_DISABLE_DEPRECATED_WARNING \
_Pragma("warning(push)") \
_Pragma("warning(disable : 4996)") // was declared deprecated
_Pragma("warning(disable : 4877 4996)")
#endif // ^^^ !defined(__clang__) ^^^
#endif // _STL_DISABLE_DEPRECATED_WARNING
// clang-format on
Expand Down