<yvals_core.h>: Fix <bit> feature-test macros - #695
Merged
Merged
Conversation
* Don't define `__cpp_lib_bitops` when `__EDG__`, so IntelliSense is consistent with MSVC * Don't define `__cpp_lib_int_pow2` when `__cpp_lib_bitops` isn't defined since the facilities that correspond with `__cpp_lib_int_pow2` are only provided when `__cpp_lib_bitops` is defined. (See discussion starting at microsoft#313 (comment).)
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 9, 2020
Comment on lines
+1114
to
+1116
| #ifdef __cpp_lib_bitops // TRANSITION, VSO-1020212 | ||
| #define __cpp_lib_int_pow2 202002L | ||
| #endif |
There was a problem hiding this comment.
I observe that <bit> guards its non-bit_cast content with #ifdef __cpp_lib_bitops // TRANSITION, VSO-1020212 instead of having separate sections for that and __cpp_lib_int_pow2. This is fine, but I thought I'd mention it.
Contributor
There was a problem hiding this comment.
I think I wrote the guard before __cpp_lib_int_pow2 was a thing.
Charlie Barto (barcharcraz)
approved these changes
Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__cpp_lib_bitopswhen__EDG__, so IntelliSense is consistent with MSVC__cpp_lib_int_pow2when__cpp_lib_bitopsisn't defined since the facilities that correspond with__cpp_lib_int_pow2are only provided when__cpp_lib_bitopsis defined.(See discussion starting at #313 (comment).)