Implement ranges::search - #896
Merged
Stephan T. Lavavej (StephanTLavavej) merged 11 commits intoJun 24, 2020
Merged
Conversation
Implement helper `ranges::_Rewrap_subrange` to use in `ranges::search` and `ranges::find_end`. Perma-workaround VSO-1141368, a failure in MSVC to properly handle lifetime extension when binding a temporary returned from a non-static member function to a reference in a constexpr context. (This seems to also affect structured bindings which look similar "under the covers".) Partially addresses microsoft#39.
Closed
Michael Schellenberger Costa (miscco)
left a comment
Contributor
There was a problem hiding this comment.
One minuscule nit
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jun 17, 2020
Casey Carter (CaseyCarter)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
June 18, 2020 20:56
... with `_STL_INTERNAL_STATIC_ASSERT` when we don't want to pay the throughput cost of constraints.
Casey Carter (CaseyCarter)
force-pushed
the
search
branch
from
June 20, 2020 16:34
d52344f to
fce2cca
Compare
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 22, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 23, 2020
Miya Natsuhara (mnatsuhara)
approved these changes
Jun 23, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 23, 2020
Member
|
Thanks for implementing this algorithm! Onward to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement helper
ranges::_Rewrap_subrangeto use inranges::searchandranges::find_end.Perma-workaround VSO-1141368, a failure in MSVC to properly handle lifetime extension when binding a temporary returned from a non-static member function to a reference in a constexpr context. (This seems to also affect structured bindings which look similar "under the covers".)
Partially addresses #39.