Skip to content

Implement ranges::generate and ranges::generate_n - #905

Merged
Stephan T. Lavavej (StephanTLavavej) merged 43 commits into
microsoft:masterfrom
ahanamuk:generate_algo
Jul 11, 2020
Merged

Stephan T. Lavavej (StephanTLavavej) merged 43 commits into
microsoft:masterfrom
ahanamuk:generate_algo

Conversation

@ahanamuk

Copy link
Copy Markdown
Contributor

No description provided.

@ahanamuk ahanamuk added the cxx20 C++20 feature label Jun 17, 2020
@ahanamuk
ahanamuk requested a review from a team as a code owner June 17, 2020 16:05
@ghost

Deleted user (ghost) commented Jun 17, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

* revert inadvertent change to LLVM reference
* update `range_algorithm_support.hpp` from `fill` PR to reduce future merge conflicts
@StephanTLavavej

Copy link
Copy Markdown
Member

Oops, got confused about whether I had previously approved this.

Comment thread stl/inc/algorithm Outdated
Comment thread stl/inc/algorithm Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_generate/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated
Comment thread tests/std/include/range_algorithm_support.hpp Outdated
Comment thread stl/inc/algorithm
Comment thread tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated
Comment thread stl/inc/algorithm
Comment thread tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp
Comment thread tests/std/tests/P0896R4_ranges_alg_generate/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_generate_n/test.cpp Outdated
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@CaseyCarter Casey Carter (CaseyCarter) removed their assignment Jul 9, 2020
Comment thread tests/std/tests/P0896R4_ranges_alg_generate/test.cpp
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for implementing these ranges algorithms, they're going to generate a lot of excitement. 😎

@miscco

Copy link
Copy Markdown
Contributor

Casey Carter (@CaseyCarter) how did you hack into Stephan T. Lavavej (@StephanTLavavej)'s account?

@CaseyCarter

Copy link
Copy Markdown
Contributor

Casey Carter (@CaseyCarter) how did you hack into Stephan T. Lavavej (@StephanTLavavej)'s account?

I had the exact same thought - he's even using the sunglasses emoji instead of cat emoji! I feel seen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cxx20 C++20 feature ranges C++20/23 ranges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants