Skip to content

Update _MSVC_STL_UPDATE for July 2020 - #989

Merged
Casey Carter (CaseyCarter) merged 1 commit into
microsoft:masterfrom
God-father1:master
Jul 7, 2020
Merged

Casey Carter (CaseyCarter) merged 1 commit into
microsoft:masterfrom
God-father1:master

Conversation

@God-father1

@God-father1 Balkrishna Harode (God-father1) commented Jul 4, 2020

Copy link
Copy Markdown
Contributor

Updated
#define _MSVC_STL_UPDATE 202006L
to
#define _MSVC_STL_UPDATE 202007L

Thank you so much for creating this issue for us (newcomers and beginners).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Welcome to open source! 😸

We should be able to merge this early next week (our process requires two maintainers to review and approve, then a maintainer needs to port the change to our Microsoft-internal repository simultaneously - which is hilariously excessive for an obviously correct single-line change, but more appropriate for the larger changes we usually merge).

@CaseyCarter Casey Carter (CaseyCarter) changed the title First open source contribution! Updated #define Update _MSVC_STL_UPDATE for July 2020 Jul 7, 2020
@CaseyCarter
Casey Carter (CaseyCarter) merged commit 89c3b49 into microsoft:master Jul 7, 2020
@CaseyCarter

Copy link
Copy Markdown
Contributor

Congratulations on your first STL contribution! 🎉

@CaseyCarter Casey Carter (CaseyCarter) added fixed Something works now, yay! and removed fixed Something works now, yay! labels Jul 7, 2020
@CaseyCarter Casey Carter (CaseyCarter) removed their assignment Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to July 2020

3 participants