Uh oh!
There was an error while loading. Please reload this page.
linuxHelpers.cpp fixes - #36
Merged
Kevin Sheldrake (kesheldr) merged 2 commits intoNov 4, 2021
Merged
Conversation
Elsewhere in this function, false and true are returned, and the comments even say that it only returns true or false. However, there's one spot where "return NULL" exists, so replace that with a "return false".
Kevin Sheldrake (kesheldr)
suggested changes
Nov 3, 2021
Uh oh!
There was an error while loading. Please reload this page.
Coleman Kane (ckane)force-pushed
the
linuxHelpers-fixes
branch
from
November 3, 2021 22:24
1dc315a to
3d88495CompareThe inner element of the LARGE_INTEGER union is a struct, so populate
its contens with {{0}} instead of {0,}, since it is a struct initialization.Coleman Kane (ckane)force-pushed
the
linuxHelpers-fixes
branch
from
November 3, 2021 22:28
3d88495 to
ea0aa15CompareColeman Kane (ckane)
commented
Nov 3, 2021
ContributorAuthor
Kevin Sheldrake (@kesheldr) I just did an ammended commit to use your suggestion (sort of). The value |
Kevin Sheldrake (kesheldr)
approved these changes
Nov 4, 2021
Kevin Sheldrake (kesheldr)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for revisiting this. I guess one set of curly brackets for the struct and another for the union.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inconsistent return value as well as fix up the LARGE_INTEGER struct initialization in
GetProcess