Uh oh!
There was an error while loading. Please reload this page.
Moved infix::calculate() from writers.cc, fixed problem with Ref lookups - #207
Open
matteB10 wants to merge 2 commits into
Open
Moved infix::calculate() from writers.cc, fixed problem with Ref lookups #207matteB10 wants to merge 2 commits into
matteB10 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewriterinfix::calculateinto its own file, calculate.cc to decouple and keep code coverage measures separate.existsandcan_replaceaction functions. We discovered that the oldcan_replacefailed to find any replaceable identifers during fuzzing, including when using --gen-bound to generate variables with symbol‑table bindings. The issue turned out to be that the rule calledcan_replaceon theRefnode instead of itsIdentchild. Since generatedRefnodes don’t always share the same location as theirIdent, the rule never matched. The updated version fixes this by applying the check directly to theIdentnode.