Skip to content

Add readable byte streams - #1362

Merged
github-actions[bot] merged 13 commits into
microsoft:mainfrom
MattiasBuelens:readable-byte-streams
Aug 4, 2022
Merged

Add readable byte streams#1362
github-actions[bot] merged 13 commits into
microsoft:mainfrom
MattiasBuelens:readable-byte-streams

Conversation

@MattiasBuelens

@MattiasBuelensMattias Buelens (MattiasBuelens) commented Jul 19, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

With Firefox 102 adding support for readable byte streams, we now have two browser engines (Chromium and Gecko) shipping this feature. This means we can finally add official type definitions! 😁

Most of work was already done in #890 but then those types had to be removed. This PR brings them back, and hopefully they'll stay this time around. 😅

@github-actions

github-actionsBot commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

MattiasBuelens
Mattias Buelens (MattiasBuelens) commented Jul 19, 2022
View reviewed changes
Comment threadbaselines/dom.generated.d.ts
Comment threadbaselines/dom.generated.d.ts
Comment threadbaselines/webworker.generated.d.ts
saschanaz
Kagami Sascha Rosylight (saschanaz) reviewed Jul 19, 2022
View reviewed changes

@saschanazKagami Sascha Rosylight (saschanaz) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Some nits.

Comment threadinputfiles/overridingTypes.jsonc Outdated
Comment threadbaselines/audioworklet.generated.d.ts
Comment threadbaselines/dom.generated.d.ts
MattiasBuelens
Mattias Buelens (MattiasBuelens) commented Jul 20, 2022
View reviewed changes

@MattiasBuelensMattias Buelens (MattiasBuelens) left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are added.

I also added additional constructor signatures for ReadableStream, to distinguish between byte streams and non-byte streams. (This is a bit complex, so please take a look!)

Comment threadbaselines/webworker.generated.d.ts
Comment threadbaselines/webworker.generated.d.ts
@Banou26Banou (Banou26) mentioned this pull request Jul 31, 2022
Closed
saschanaz
Kagami Sascha Rosylight (saschanaz) reviewed Aug 1, 2022
View reviewed changes

@saschanazKagami Sascha Rosylight (saschanaz) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(Sorry for responding late, I was off and playing games 😄. My vacation does not really apply here, but whatever.)

Comment threadinputfiles/addedTypes.jsonc Outdated
Comment threadinputfiles/overridingTypes.jsonc Outdated
saschanaz
Kagami Sascha Rosylight (saschanaz) reviewed Aug 4, 2022
View reviewed changes

@saschanazKagami Sascha Rosylight (saschanaz) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay everything's cool, thank you for additional assertions!

Comment threadunittests/files/streams.ts
controller.close();
},
cancel(reason) {
assertType<any>(reason);

@saschanazKagami Sascha Rosylight (saschanaz)Aug 4, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really do anything? 😄 (But probably good to be explicit)

@MattiasBuelensMattias Buelens (MattiasBuelens)Aug 4, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯\_(ツ)_/¯

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

LGTM

@github-actions
github-actionsBot merged commit 321faea into microsoft:mainAug 4, 2022
@github-actions

github-actionsBot commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks!

@MattiasBuelens
Mattias Buelens (MattiasBuelens) deleted the readable-byte-streams branch August 4, 2022 06:57
@MattiasBuelensMattias Buelens (MattiasBuelens) mentioned this pull request Aug 4, 2022
Open
@yume-chanSimon Chan (yume-chan) mentioned this pull request Mar 29, 2026
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@saschanazKagami Sascha Rosylight (saschanaz)saschanaz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MattiasBuelens@saschanaz