Skip to content

Introduce CSSStyleDeclarationBase - #2174

Merged
github-actions[bot] merged 3 commits into
microsoft:mainfrom
saschanaz:css-decl
Oct 1, 2025
Merged

Introduce CSSStyleDeclarationBase#2174
github-actions[bot] merged 3 commits into
microsoft:mainfrom
saschanaz:css-decl

Conversation

@saschanaz

@saschanazKagami Sascha Rosylight (saschanaz) commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

This should reduce DT breakage. But note that this would make CSSPageDescriptors extends CSSStyleDeclaration to false. Authors would need to use CSSStyleDeclarationBase for that.

@saschanaz
Introduce CSSStyleDeclarationBase
5f70944
This should reduce DT breakage. But note that this would make `CSSPageDescriptors extends CSSStyleDeclaration` to `false`. Authors would need to use CSSStyleDeclarationBase for that.
@github-actions

github-actionsBot commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

Merged
@jakebailey

Jake Bailey (jakebailey) commented Sep 30, 2025

Copy link
Copy Markdown
Member

CSSStyleDeclaration doesn't add anything to CSSStyleProperties so I think it technically still works?

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Sep 30, 2025

Copy link
Copy Markdown
ContributorAuthor

With this PR it's CSSStyleDeclarationBase -> CSSStyleProperties -> CSSStyleDeclaration, so yeah it can't add anything to it's now-parent.

image

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Sep 30, 2025

Copy link
Copy Markdown
ContributorAuthor

Jake Bailey (@jakebailey) 🤞🏻

Bashamega
Adam Naji (Bashamega) reviewed Oct 1, 2025
View reviewed changes
Comment threadinputfiles/patches/cssom.kdl
Bashamega
Adam Naji (Bashamega) reviewed Oct 1, 2025
View reviewed changes
Comment threadsrc/build/emitter.ts
Bashamega
Adam Naji (Bashamega) reviewed Oct 1, 2025
View reviewed changes
Comment threadsrc/build/types.ts
@Bashamega

Adam Naji (Bashamega) commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Just a few nits that I found

jakebailey
Jake Bailey (jakebailey) approved these changes Oct 1, 2025
View reviewed changes

@jakebaileyJake Bailey (jakebailey) left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on microsoft/TypeScript#62496, it seems like this is working fine. If you're happy, then I think this is okay.

@saschanaz

Kagami Sascha Rosylight (saschanaz) commented Oct 1, 2025

Copy link
Copy Markdown
ContributorAuthor

LGTM, let's go 🙂

@github-actions
github-actionsBot merged commit 77e5897 into microsoft:mainOct 1, 2025
20 checks passed
@github-actions

github-actionsBot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks!

@github-actions
github-actionsBot deleted the css-decl branch October 1, 2025 23:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakebaileyJake Bailey (jakebailey)jakebailey approved these changes
+1 more reviewer
@BashamegaAdam Naji (Bashamega)Bashamega approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschanaz@jakebailey@Bashamega