Use BCD to autoremove unimplemented features by saschanaz · Pull Request #915 · microsoft/TypeScript-DOM-lib-generator

Kagami Sascha Rosylight (saschanaz) · 2020-09-16T21:37:59Z

This patch focuses only on removing totally unimplemented features, and defers everything else:

features only with single implementation should be reevaluated later
features that are widely-supported but over-restricted by removedTypes.json should also be reevaluated later.

forceKeepAlive is quite huge now but it eventually will be removed once reevaluation ends.

Kagami Sascha Rosylight (saschanaz) · 2020-09-16T21:39:46Z

 new<R = any>(underlyingSource?: UnderlyingSource<R>, strategy?: QueuingStrategy<R>): ReadableStream<R>;
 };

-interface ReadableStreamBYOBReader {


Mattias Buelens (@MattiasBuelens), could you review the Streams part of this removal? Thanks!

UnderlyingByteSource, ReadableByteStreamControllerCallback and this ReadableStream constructor overload should be removed as well.
You might want to have a look at 361a870 (part of #890).

Hang on, where did WritableStream and TransformStream go? There are still types referencing them (like GenericTransformStream and ReadableStream.pipeTo).
(I understand why they would need to be removed, but it still makes me sad to see them go... 😞)

The bright side is that this patch only disables some of your work but not removes them all. It can be enabled again when browsers implement them 👍
(Disabling them should also boost #890 👀👀)

BTW, WritableStream and TransformStream are still alive as there is at least a single implementation and thus not covered here. This patch is intentionally only removes totally unimplemented ones to reduce the diff size.

Streams changes LGTM. 👍 Happy to see WritableStream and TransformStream are still alive! 😁
I think it's best to wait with landing #890 until after this PR lands. I'll see if I can rebase my PR to not completely remove the readable byte stream definitions, and instead rely on your work to auto-remove them. 🙂

Kagami Sascha Rosylight (saschanaz) · 2020-09-16T21:48:42Z

Oops, test fails 👀

Kagami Sascha Rosylight (saschanaz) · 2020-09-19T17:12:20Z

Philip Jägenstedt (foolip) · 2020-09-22T09:14:22Z

@vinyldarkscratch this PR is of interest to our ongoing project. In particular the list of BCD bugs in #915 (comment) are things that can hopefully be fixed by using https://github.com/foolip/mdn-bcd-collector. Where they can't, that might reveal a deficiency in our approach.

Kagami Sascha Rosylight (saschanaz) · 2020-10-24T20:52:38Z

Changes are too big, maybe better to remove things progressively. I'll make separate PRs.

Nathan Shively-Sanders (sandersn) · 2021-02-23T16:19:35Z

Orta Therox (@orta) and I like this idea -- in fact, we'd rather take this PR than the dozen or so individual-removal PRs.

Do they remove the same set of declarations? It looks that way.
Is this PR ready to go otherwise? I've only scanned the code, but it looks OK at that level of detail.

Nathan Shively-Sanders (sandersn)

Approving the code change -- couple of open questions about the resulting DOM changes.

Kagami Sascha Rosylight (saschanaz) · 2021-02-27T21:52:01Z

Orta Therox (@orta) and I like this idea -- in fact, we'd rather take this PR than the dozen or so individual-removal PRs.
Do they remove the same set of declarations? It looks that way.
Is this PR ready to go otherwise? I've only scanned the code, but it looks OK at that level of detail.

Yes, they are already merged in this PR.
Also yes. It's using older version of BCD since the PR has been rotting, though.

Orta Therox (orta) · 2021-03-01T14:19:06Z

Cool, IMO we should let's get this in and into the compiler then 👍🏻

Nathan Shively-Sanders (sandersn) · 2021-03-04T01:15:55Z

I'm going to port this over to Typescript right now and will tag you (Orta Therox (@orta) and Kagami Sascha Rosylight (@saschanaz)) on the PR when it's ready.

Nathan Shively-Sanders (sandersn) · 2021-03-04T14:28:17Z

OK, it is merged into TS now.

Kagami Sascha Rosylight (saschanaz) requested a review from Nathan Shively-Sanders (sandersn) as a code owner September 16, 2020 21:37

Kagami Sascha Rosylight (saschanaz) commented Sep 16, 2020
View reviewed changes

Kagami Sascha Rosylight (saschanaz) marked this pull request as draft September 17, 2020 21:21

Holger Jeromin (HolgerJeromin) approved these changes Sep 18, 2020
View reviewed changes

Kagami Sascha Rosylight (saschanaz) marked this pull request as ready for review September 18, 2020 08:14

Philip Jägenstedt (foolip) mentioned this pull request Sep 22, 2020
Process for updating browser.webidl.preprocessed.json? #918
Closed

Mattias Buelens (MattiasBuelens) mentioned this pull request Sep 29, 2020
Update Streams to official WebIDL #890
Merged

Kagami Sascha Rosylight (saschanaz) mentioned this pull request Oct 9, 2020
Design Meeting Notes, 10/2/2020 microsoft/TypeScript#40969
Closed

Kagami Sascha Rosylight (saschanaz) marked this pull request as draft October 24, 2020 20:52

This was referenced Oct 24, 2020
Remove unimplemented Web Authentication APIs #931
Closed
Remove DeviceLightEvent #932
Closed
Remove ServiceWorkerMessageEvent #933
Closed
Remove HTMLBaseFontElement #934
Closed
Add Payment Request types #937
Closed

Kagami Sascha Rosylight (saschanaz)force-pushed the bcd branch 4 times, most recently from 5903298 to f1d41bcCompare October 25, 2020 03:02

Kagami Sascha Rosylight (saschanaz) mentioned this pull request Oct 25, 2020
Publish crawled data with fixes to NPM? w3c/webref#63
Closed

Kagami Sascha Rosylight (saschanaz) mentioned this pull request Nov 9, 2020
Should BCD represent dictionaries as their own entries? mdn/browser-compat-data#7287
Closed

Kagami Sascha Rosylight (saschanaz) mentioned this pull request Dec 11, 2020
Create deprecatedjson from mdn web #884
Merged

Nathan Shively-Sanders (sandersn) approved these changes Feb 23, 2021
View reviewed changes

Kagami Sascha Rosylight (saschanaz) marked this pull request as ready for review February 27, 2021 21:14

Kagami Sascha Rosylight (saschanaz) added 2 commits February 27, 2021 22:18

Remove unimplemented WindowClient#ancestorOrigins
2fa17c4

Remove unimplemented WorkerNavigator#serviceWorker
3be2125

Kagami Sascha Rosylight (saschanaz) added 18 commits February 27, 2021 22:18

Remove unimplemented PushSubscriptionChangeEvent
8f0c6af

Remove unimplemented WebGLObject
7aa27a8

Remove unimplemented WebVR APIs
0e862e6

Remove unimplemented TextTrack#sourceBuffer
f49723d

Remove unexposed TextMetrics APIs
625b066

Remove unimplemented SVGUseElement properties
6ac9b31

Update WebRTC types
3f6baa4

Add Payment Request types
a1a1491

Remove MediaStreamTrack isolation
fce90f5

Remove MS-prefixed events
45a0ea2

Remove HTMLBaseFontElement
a879898

Remove ServiceWorkerMessageEvent
5df008b

Remove DeviceLightEvent
6444df5

Remove unimplemented Web Authentication APIs
3ff43fc

Use BCD to autoremove unimplemented features
34e53dd

bcd 2.0.5
192d519

bcd 2.0.6
c3eef9e

2.0.7
555d3d5

Kagami Sascha Rosylight (saschanaz)force-pushed the bcd branch from e26adf0 to 555d3d5Compare February 27, 2021 21:49

Nathan Shively-Sanders (sandersn) approved these changes Mar 4, 2021
View reviewed changes

Nathan Shively-Sanders (sandersn) merged commit f45dc9f into microsoft:masterMar 4, 2021

Nathan Shively-Sanders (sandersn) mentioned this pull request Mar 4, 2021
Update the DOM: March 03, 2021 microsoft/TypeScript#43070
Merged

Kagami Sascha Rosylight (saschanaz) deleted the bcd branch March 4, 2021 04:21

Uh oh!

Conversation

Kagami Sascha Rosylight (saschanaz) commented Sep 16, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kagami Sascha Rosylight (saschanaz)Sep 16, 2020

Choose a reason for hiding this comment

Uh oh!

Mattias Buelens (MattiasBuelens)Sep 16, 2020

Choose a reason for hiding this comment

Uh oh!

Mattias Buelens (MattiasBuelens)Sep 16, 2020

Choose a reason for hiding this comment

Uh oh!

Kagami Sascha Rosylight (saschanaz)Sep 18, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kagami Sascha Rosylight (saschanaz)Sep 19, 2020

Choose a reason for hiding this comment

Uh oh!

Mattias Buelens (MattiasBuelens)Sep 29, 2020

Choose a reason for hiding this comment

Uh oh!

Kagami Sascha Rosylight (saschanaz) commented Sep 16, 2020

Uh oh!

Kagami Sascha Rosylight (saschanaz) commented Sep 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Philip Jägenstedt (foolip) commented Sep 22, 2020

Uh oh!

Kagami Sascha Rosylight (saschanaz) commented Oct 24, 2020

Uh oh!

Nathan Shively-Sanders (sandersn) commented Feb 23, 2021

Uh oh!

Nathan Shively-Sanders (sandersn) left a comment

Choose a reason for hiding this comment

Uh oh!

Kagami Sascha Rosylight (saschanaz) commented Feb 27, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Orta Therox (orta) commented Mar 1, 2021

Uh oh!

Nathan Shively-Sanders (sandersn) commented Mar 4, 2021

Uh oh!

Nathan Shively-Sanders (sandersn) commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Kagami Sascha Rosylight (saschanaz) commented Sep 16, 2020•
edited
Loading

Kagami Sascha Rosylight (saschanaz)Sep 18, 2020•
edited
Loading

Kagami Sascha Rosylight (saschanaz) commented Sep 19, 2020•
edited
Loading

Kagami Sascha Rosylight (saschanaz) commented Feb 27, 2021•
edited
Loading