Skip to content

Support internationalization of text inside the website - #180

Merged
Orta Therox (orta) merged 5 commits into
v2from
i8n
Jan 15, 2020
Merged

Support internationalization of text inside the website#180
Orta Therox (orta) merged 5 commits into
v2from
i8n

Conversation

@orta

@ortaOrta Therox (orta) commented Jan 15, 2020

Copy link
Copy Markdown
Contributor

Screen Shot 2020-01-15 at 2 37 52 PM

Note the nav above: this PR allows code inside React to be translated. Adds the website section to #100

Interesting things because of this:

  • Bumped node version of this project to minimum of 13, because that is when internationalization was added natively. We don't use any of those APIs yet (maybe never (like dates/number formatters etc) but better to be sure)

  • I switched form "leet" to "vo". The locales are verified to be real in the i8n code, and well, "leet" isn't an ISO 639-1 code. So I found the one with only 20 language speakers in the world: Volapük

As an aside, I did some work on the code syntax coloring - it now passes the a11y audits on CI.

@github-actions

Copy link
Copy Markdown
Contributor
Messages
📖

Deployed to a PR branch - playgroundtsconfigold handbook

Got false positives?

Make changes to the global settings spellcheck.json in /artsy/peril-settings.

Typos for Project_Files_0.md

LineTypo
5B1ts and d1gits for setting up the
5B1ts and d1gits for setting up the filez
5and d1gits for setting up the filez

Typos for noImplicitAny.md

LineTypo
6!n s0me cases where n0 type annotatio
6!n s0me cases where n0 type annotations r present, T
6annotations r present, Type$cript will fall back to a type of `
19itAny` however T$ will issue errorz whenever it would have inferr

Typos for files.md

LineTypo
25Specifies an 4llowlist of f1l3s to include in the pr
25Specifies an 4llowlist of f1l3s to include in the pr0gram. An
25st of f1l3s to include in the pr0gram. An error occurs if any 0f th
250gram. An error occurs if any 0f the files can't be found.

Typos for Basic_Options_6172.md

LineTypo
5These settings ar3 used to define the runtime ex
5e the runtime expectations of ur project, how and where u want
5of ur project, how and where u want the J$ to be emittd and
5nd where u want the J$ to be emittd and the lvl of integ8ion you
5the J$ to be emittd and the lvl of integ8ion you want with ex
5$ to be emittd and the lvl of integ8ion you want with existing JS cod

Lighthouse Scores

/

PerformanceAccessibilityBest PracticesSEOProgressive Web App
0.8710.930.880.74

/en/tsconfig

PerformanceAccessibilityBest PracticesSEOProgressive Web App
0.90.9710.860.7

/docs/handbook/integrating-with-build-tools.html

PerformanceAccessibilityBest PracticesSEOProgressive Web App
0.930.9310.890.74

Generated by 🚫 dangerJS against 95d74e7

@orta

Copy link
Copy Markdown
ContributorAuthor

back to green merges 🥇

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@orta