Skip to content

[PT-BR] Translate Conditional Types and Unknown and Never - #964

Merged
github-actions[bot] merged 2 commits into
microsoft:v2from
vinicius98s:v2
Aug 28, 2020
Merged

[PT-BR] Translate Conditional Types and Unknown and Never#964
github-actions[bot] merged 2 commits into
microsoft:v2from
vinicius98s:v2

Conversation

@vinicius98s

@vinicius98sVinicius Sales (vinicius98s) commented Aug 24, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@ghost

Deleted user (ghost) commented Aug 24, 2020•
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@github-actions

github-actionsBot commented Aug 24, 2020

Copy link
Copy Markdown
Contributor

Thanks for the PR!

This section of the codebase is owned by Lucas Santos (@khaosdoctor) and Danilo Fuchs (@danilofuchs) - if they write a comment saying "LGTM" then it will be merged.

@vinicius98sVinicius Sales (vinicius98s) mentioned this pull request Aug 24, 2020
Closed
danilofuchs
Danilo Fuchs (danilofuchs) suggested changes Aug 27, 2020
View reviewed changes

@danilofuchsDanilo Fuchs (danilofuchs) left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
I have a few suggestions and caught some typos

Comment threadpackages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts Outdated
khaosdoctor
Lucas Santos (khaosdoctor) suggested changes Aug 27, 2020
View reviewed changes

@khaosdoctorLucas Santos (khaosdoctor) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

Comment threadpackages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Meta-Types/Conditional Types.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts Outdated
Comment threadpackages/playground-examples/copy/pt/TypeScript/Primitives/Unknown and Never.ts Outdated
@khaosdoctor

Lucas Santos (khaosdoctor) commented Aug 27, 2020

Copy link
Copy Markdown
Contributor

Vinicius Sales (@vinicius98s) Corrected a few examples!

@vinicius98s@khaosdoctor@danilofuchs
Apply suggestions from code review
0214f16
Co-authored-by: Lucas Santos <lhs.santoss@gmail.com>
Co-authored-by: Danilo Campana Fuchs <danilo_fuchs@hotmail.com>
@vinicius98s

Vinicius Sales (vinicius98s) commented Aug 28, 2020

Copy link
Copy Markdown
ContributorAuthor

Lucas Santos (@khaosdoctor)Danilo Fuchs (@danilofuchs) Applied those suggestions and corrected the typos

danilofuchs
Danilo Fuchs (danilofuchs) approved these changes Aug 28, 2020
View reviewed changes

@danilofuchsDanilo Fuchs (danilofuchs) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danilofuchs

Danilo Fuchs (danilofuchs) commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

Orta Therox (@orta) the merge action failed mysteriously 🤔

@khaosdoctor

Lucas Santos (khaosdoctor) commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

lgtm

@github-actions
github-actionsBot merged commit e53888c into microsoft:v2Aug 28, 2020
@github-actions

github-actionsBot commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

Merging because Lucas Santos (@khaosdoctor) is a code-owner of all the changes - thanks!

@khaosdoctor

Lucas Santos (khaosdoctor) commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

Danilo Fuchs (@danilofuchs) Well... I don't know what happened

@orta

Orta Therox (orta) commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

I know, I had hoped this would solve it OSS-Docs-Tools/code-owner-self-merge#6

@orta

Orta Therox (orta) commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

Hrm, 6 hours ago might have been before I shipped the update - so I'm not sold on it not being fixed actually - just remember to leave a review LGTM next time and we'll see

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@khaosdoctorLucas Santos (khaosdoctor)khaosdoctor requested changes
@danilofuchsDanilo Fuchs (danilofuchs)danilofuchs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vinicius98s@khaosdoctor@danilofuchs@orta