TSX spread stopped working

[normalser]

import * as React from "react";

interface Props {

}

export class Test extends React.Component<Props, {}> {
 render() {
 return <div {...this.props} />
 }
}

Was working fine until: typescript@2.3.0-dev.20170215

In typescript@2.3.0-dev.20170216 throws:

error TS2698: Spread types may only be created from object types.

Not sure if related: #13557

[yuit]

normalser it is related to #13557 as now spread operation in Jsx is going through same logic as normal spread (previously it is handled separately... I will discuss with Nathan Shively-Sanders (@sandersn) who is working in this area

[sandersn]

It will be fixed by #13288. Reviews are welcome!

The original proposal is #10727, which is the main bug for this issue.

[sandersn]

In #13288, getSpreadType has a special case that flattens intersections if they only contain object types (no type parameters, etc). I don't know React, but spreading this.props looks like it is extremely common. If so, it would be worthwhile to ship that part of the change early.

normalser Yui (@yuit) Ryan Cavanaugh (@RyanCavanaugh) opinions from people who actually know React?

[sandersn]

Note that this would make error reporting a lot harder (impossible?) for the case that the intersection does contain a type parameter.

[sandersn]

After discussing with Yui (@yuit), I think the fix is just to get #13288 checked in soon so that spread types are fully supported. Supporting intersections separately would be too error-prone.

[sandersn]

Well, it turns out that the culprit is that checkObjectLiteral and createJsxAttributesType both call getSpreadType and both check for object types. But createJsxAttributesType doesn't call isValidSpreadType, it uses an older, simpler check. So this is an easy fix, after all: just make anybody who calls getSpreadType first call isValidSpreadType.

[RyanCavanaugh]

JSX spread is very common; this needs to work for a major release

[sandersn]

Fix is up at #14122