Wrong import suggestion in subpath pattern

[konsalex]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.75.1
• OS Version: Darwin x64 22.1.0 (MacOS)

Steps to Reproduce:

1. Install @neo4j-ndl/react@1.0.0-alpha-fafbc08
2. Try to import an icon like <AdjustmentsHorizontalIconSolid /> in a JSX file.

The recommended import path is @neo4j-ndl/react/lib/types/icons while the correct based on the exports field would be @neo4j-ndl/react/icons

The modified package.json is looking like this:

{
 "name": "@neo4j-ndl/react",
 "version": "0.17.7",
 "sideEffects": false,
 "description": "React implementation of Neo4j Design System",
 "keywords": [
 "neo4j",
 "react",
 "design system",
 "needle",
 "ndl"
 ],
 "author": "Neo4j Inc.",
 "homepage": "",
 "license": "GPL-3.0",
 "main": "./lib/cjs/index.js",
 "module": "./lib/esm/index.js",
 "types": "./lib/types/index.d.ts",
 "exports": {
 "./icons": {
 "import": "./lib/esm/icons/index.js",
 "require": "./lib/cjs/icons/index.js",
 "types": "./lib/types/icons/index.d.ts"
 },
 ".": {
 "import": "./lib/esm/index.js",
 "require": "./lib/cjs/index.js",
 "types": "./lib/types/index.d.ts"
 }
 },
 ...
}

As a library publishers tried it also with WebStorm to see how it behaves and I can see that there it is imported as expected (video):

CleanShot.2023-02-16.at.17.48.07.mp4

Also noticed, that if there is one module imported from @neo4j-ndl/react/icons then the suggestion works as expected (image):

[mjbvz]

Can you please try upgrading your workspace to use the next version of typescript by installing this extension and then restarting VS Code. Does this fix the issue?

[konsalex]

Matt Bierner (@mjbvz) no unfortunately, still the same:

[RyanCavanaugh]

A reduced repro would let us look at this earlier

[mbrevda]

Look like this was fixed in #55015

[konsalex]

Moshe Brevda (@mbrevda) tried with TS 5.4, and still have the same issue in VS Code.

Example screenshot:

Here you can find the package config:
https://www.jsdelivr.com/package/npm/@neo4j-ndl/react?tab=files

Not sure what is different from WebStorm's approach, but there is works as expected:

[mbrevda]

Realizing now that our use cases differ: I'm doing subpath imports.