Adding tsconfig.json mixed content (script block) support by jramsay · Pull Request #12153 · microsoft/TypeScript

jram (jramsay) · 2016-11-10T19:49:48Z

Adding tsconfig.json mixed content (script block) support

Vladimir Matveev (@vladima): I'll work on adding tests for this now.

…tentSupport

Vladimir Matveev (vladima) · 2016-12-03T08:30:35Z

 }

- export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program): Program {
+ export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, fileExtensionMap?: FileExtensionMap): Program {


I don't think we need to push concrete knowledge about these extra extensions through all layers, this will be necessary if we'll need to be able to add files with these extensions into program via imports or tripleslash references. Since both these scenarios are not supported and files with custom extensions should always be included in the list of root files I think we can:
revert changes in program, language service host, lsHost and services
in editor services for configured projects if host configuration specifies extra extensions and result of cracking config files contains files with these extensions - set allowNonTsExtensions bit on CompilerOptions to force adding these files into program.
this way I think we can update only project system part and keep all other layers relatively untouched.

(Note: adding this until PR #12789 is merged in so that unit tests pass)

Vladimir Matveev (vladima) · 2016-12-09T21:06:28Z

 }

- const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors);
+ const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors, fileExtensionMap);


is it not really a map anymore. maybe extraExtensions: ExtensionInfo[]?

sounds good - will switch to extraFileExtensions: FileExtensionInfo[]

…s: FileExtensionInfo[]

Vladimir Matveev (vladima) · 2016-12-09T22:14:27Z

@@ -670,7 +678,7 @@ namespace ts.server {
 // check if requested version is the same that we have reported last time


I would make it more like
letupdatedFileNames=this.updatedFileNames;this.updatedFileNames=undefined;/// use local updatedFileNames - this way we'll know that set of names is definitely cleared

Yes - good idea

… names is definitely cleared

Vladimir Matveev (vladima) · 2016-12-09T23:33:04Z

- export function getSupportedExtensions(options?: CompilerOptions): string[] {
- return options && options.allowJs ? allSupportedExtensions : supportedTypeScriptExtensions;
+ export function getSupportedExtensions(options?: CompilerOptions, extraFileExtensions?: FileExtensionInfo[]): string[] {
+ let typeScriptHostExtensions: string[] = [];


minor nit to reduce allocations:
letallExtensions: string[];letallTypeScriptExtensions: string[];constneedAllExtensions=options&&options.allowJs;if(!extraFileExtensions){returnneedAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions;}constextensions=(needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions).slice(0);for(constextofextraExtensions){if(!needAllExtensions||ext.scriptKind===ScriptKind.TS){extensions.push(ext.fileName);}}returnextensions;

clever - testing this change and will update

mihailik · 2016-12-12T09:21:27Z

What is mixed content?

Anders Hejlsberg (@ahejlsberg) had that tradition of decorating significant new work with a detailed summary. I don't think it is such a bad idea.

jram (jramsay) · 2016-11-10T19:49:48Z

Adding tsconfig.json mixed content (script block) support

Vladimir Matveev (@vladima): I'll work on adding tests for this now.

…tentSupport

Vladimir Matveev (vladima) · 2016-12-03T08:30:35Z

 }

- export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program): Program {
+ export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, fileExtensionMap?: FileExtensionMap): Program {


I don't think we need to push concrete knowledge about these extra extensions through all layers, this will be necessary if we'll need to be able to add files with these extensions into program via imports or tripleslash references. Since both these scenarios are not supported and files with custom extensions should always be included in the list of root files I think we can:
revert changes in program, language service host, lsHost and services
in editor services for configured projects if host configuration specifies extra extensions and result of cracking config files contains files with these extensions - set allowNonTsExtensions bit on CompilerOptions to force adding these files into program.
this way I think we can update only project system part and keep all other layers relatively untouched.

(Note: adding this until PR #12789 is merged in so that unit tests pass)

Vladimir Matveev (vladima) · 2016-12-09T21:06:28Z

 }

- const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors);
+ const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors, fileExtensionMap);


is it not really a map anymore. maybe extraExtensions: ExtensionInfo[]?

sounds good - will switch to extraFileExtensions: FileExtensionInfo[]

…s: FileExtensionInfo[]

Vladimir Matveev (vladima) · 2016-12-09T22:14:27Z

@@ -670,7 +678,7 @@ namespace ts.server {
 // check if requested version is the same that we have reported last time


I would make it more like
letupdatedFileNames=this.updatedFileNames;this.updatedFileNames=undefined;/// use local updatedFileNames - this way we'll know that set of names is definitely cleared

Yes - good idea

… names is definitely cleared

Vladimir Matveev (vladima) · 2016-12-09T23:33:04Z

- export function getSupportedExtensions(options?: CompilerOptions): string[] {
- return options && options.allowJs ? allSupportedExtensions : supportedTypeScriptExtensions;
+ export function getSupportedExtensions(options?: CompilerOptions, extraFileExtensions?: FileExtensionInfo[]): string[] {
+ let typeScriptHostExtensions: string[] = [];


minor nit to reduce allocations:
letallExtensions: string[];letallTypeScriptExtensions: string[];constneedAllExtensions=options&&options.allowJs;if(!extraFileExtensions){returnneedAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions;}constextensions=(needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions).slice(0);for(constextofextraExtensions){if(!needAllExtensions||ext.scriptKind===ScriptKind.TS){extensions.push(ext.fileName);}}returnextensions;

clever - testing this change and will update

mihailik · 2016-12-12T09:21:27Z

What is mixed content?

Anders Hejlsberg (@ahejlsberg) had that tradition of decorating significant new work with a detailed summary. I don't think it is such a bad idea.

jram (jramsay) · 2016-11-10T19:49:48Z

Adding tsconfig.json mixed content (script block) support

Vladimir Matveev (@vladima): I'll work on adding tests for this now.

…tentSupport

Vladimir Matveev (vladima) · 2016-12-03T08:30:35Z

 }

- export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program): Program {
+ export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, fileExtensionMap?: FileExtensionMap): Program {


I don't think we need to push concrete knowledge about these extra extensions through all layers, this will be necessary if we'll need to be able to add files with these extensions into program via imports or tripleslash references. Since both these scenarios are not supported and files with custom extensions should always be included in the list of root files I think we can:
revert changes in program, language service host, lsHost and services
in editor services for configured projects if host configuration specifies extra extensions and result of cracking config files contains files with these extensions - set allowNonTsExtensions bit on CompilerOptions to force adding these files into program.
this way I think we can update only project system part and keep all other layers relatively untouched.

(Note: adding this until PR #12789 is merged in so that unit tests pass)

Vladimir Matveev (vladima) · 2016-12-09T21:06:28Z

 }

- const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors);
+ const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors, fileExtensionMap);


is it not really a map anymore. maybe extraExtensions: ExtensionInfo[]?

sounds good - will switch to extraFileExtensions: FileExtensionInfo[]

…s: FileExtensionInfo[]

Vladimir Matveev (vladima) · 2016-12-09T22:14:27Z

@@ -670,7 +678,7 @@ namespace ts.server {
 // check if requested version is the same that we have reported last time


I would make it more like
letupdatedFileNames=this.updatedFileNames;this.updatedFileNames=undefined;/// use local updatedFileNames - this way we'll know that set of names is definitely cleared

Yes - good idea

… names is definitely cleared

Vladimir Matveev (vladima) · 2016-12-09T23:33:04Z

- export function getSupportedExtensions(options?: CompilerOptions): string[] {
- return options && options.allowJs ? allSupportedExtensions : supportedTypeScriptExtensions;
+ export function getSupportedExtensions(options?: CompilerOptions, extraFileExtensions?: FileExtensionInfo[]): string[] {
+ let typeScriptHostExtensions: string[] = [];


minor nit to reduce allocations:
letallExtensions: string[];letallTypeScriptExtensions: string[];constneedAllExtensions=options&&options.allowJs;if(!extraFileExtensions){returnneedAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions;}constextensions=(needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions).slice(0);for(constextofextraExtensions){if(!needAllExtensions||ext.scriptKind===ScriptKind.TS){extensions.push(ext.fileName);}}returnextensions;

clever - testing this change and will update

mihailik · 2016-12-12T09:21:27Z

What is mixed content?

Anders Hejlsberg (@ahejlsberg) had that tradition of decorating significant new work with a detailed summary. I don't think it is such a bad idea.

jram (jramsay) · 2016-11-10T19:49:48Z

Adding tsconfig.json mixed content (script block) support

Vladimir Matveev (@vladima): I'll work on adding tests for this now.

…tentSupport

Vladimir Matveev (vladima) · 2016-12-03T08:30:35Z

 }

- export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program): Program {
+ export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, fileExtensionMap?: FileExtensionMap): Program {


I don't think we need to push concrete knowledge about these extra extensions through all layers, this will be necessary if we'll need to be able to add files with these extensions into program via imports or tripleslash references. Since both these scenarios are not supported and files with custom extensions should always be included in the list of root files I think we can:
revert changes in program, language service host, lsHost and services
in editor services for configured projects if host configuration specifies extra extensions and result of cracking config files contains files with these extensions - set allowNonTsExtensions bit on CompilerOptions to force adding these files into program.
this way I think we can update only project system part and keep all other layers relatively untouched.

(Note: adding this until PR #12789 is merged in so that unit tests pass)

Vladimir Matveev (vladima) · 2016-12-09T21:06:28Z

 }

- const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors);
+ const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors, fileExtensionMap);


is it not really a map anymore. maybe extraExtensions: ExtensionInfo[]?

sounds good - will switch to extraFileExtensions: FileExtensionInfo[]

…s: FileExtensionInfo[]

Vladimir Matveev (vladima) · 2016-12-09T22:14:27Z

@@ -670,7 +678,7 @@ namespace ts.server {
 // check if requested version is the same that we have reported last time


I would make it more like
letupdatedFileNames=this.updatedFileNames;this.updatedFileNames=undefined;/// use local updatedFileNames - this way we'll know that set of names is definitely cleared

Yes - good idea

… names is definitely cleared

Vladimir Matveev (vladima) · 2016-12-09T23:33:04Z

- export function getSupportedExtensions(options?: CompilerOptions): string[] {
- return options && options.allowJs ? allSupportedExtensions : supportedTypeScriptExtensions;
+ export function getSupportedExtensions(options?: CompilerOptions, extraFileExtensions?: FileExtensionInfo[]): string[] {
+ let typeScriptHostExtensions: string[] = [];


minor nit to reduce allocations:
letallExtensions: string[];letallTypeScriptExtensions: string[];constneedAllExtensions=options&&options.allowJs;if(!extraFileExtensions){returnneedAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions;}constextensions=(needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions).slice(0);for(constextofextraExtensions){if(!needAllExtensions||ext.scriptKind===ScriptKind.TS){extensions.push(ext.fileName);}}returnextensions;

clever - testing this change and will update

mihailik · 2016-12-12T09:21:27Z

What is mixed content?

Anders Hejlsberg (@ahejlsberg) had that tradition of decorating significant new work with a detailed summary. I don't think it is such a bad idea.

jram (jramsay) · 2016-11-10T19:49:48Z

Adding tsconfig.json mixed content (script block) support

Vladimir Matveev (@vladima): I'll work on adding tests for this now.

…tentSupport

Vladimir Matveev (vladima) · 2016-12-03T08:30:35Z

 }

- export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program): Program {
+ export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, fileExtensionMap?: FileExtensionMap): Program {


I don't think we need to push concrete knowledge about these extra extensions through all layers, this will be necessary if we'll need to be able to add files with these extensions into program via imports or tripleslash references. Since both these scenarios are not supported and files with custom extensions should always be included in the list of root files I think we can:
revert changes in program, language service host, lsHost and services
in editor services for configured projects if host configuration specifies extra extensions and result of cracking config files contains files with these extensions - set allowNonTsExtensions bit on CompilerOptions to force adding these files into program.
this way I think we can update only project system part and keep all other layers relatively untouched.

(Note: adding this until PR #12789 is merged in so that unit tests pass)

Vladimir Matveev (vladima) · 2016-12-09T21:06:28Z

 }

- const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors);
+ const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors, fileExtensionMap);


is it not really a map anymore. maybe extraExtensions: ExtensionInfo[]?

sounds good - will switch to extraFileExtensions: FileExtensionInfo[]

…s: FileExtensionInfo[]

Vladimir Matveev (vladima) · 2016-12-09T22:14:27Z

@@ -670,7 +678,7 @@ namespace ts.server {
 // check if requested version is the same that we have reported last time


I would make it more like
letupdatedFileNames=this.updatedFileNames;this.updatedFileNames=undefined;/// use local updatedFileNames - this way we'll know that set of names is definitely cleared

Yes - good idea

… names is definitely cleared

Vladimir Matveev (vladima) · 2016-12-09T23:33:04Z

- export function getSupportedExtensions(options?: CompilerOptions): string[] {
- return options && options.allowJs ? allSupportedExtensions : supportedTypeScriptExtensions;
+ export function getSupportedExtensions(options?: CompilerOptions, extraFileExtensions?: FileExtensionInfo[]): string[] {
+ let typeScriptHostExtensions: string[] = [];


minor nit to reduce allocations:
letallExtensions: string[];letallTypeScriptExtensions: string[];constneedAllExtensions=options&&options.allowJs;if(!extraFileExtensions){returnneedAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions;}constextensions=(needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions).slice(0);for(constextofextraExtensions){if(!needAllExtensions||ext.scriptKind===ScriptKind.TS){extensions.push(ext.fileName);}}returnextensions;

clever - testing this change and will update

mihailik · 2016-12-12T09:21:27Z

What is mixed content?

Anders Hejlsberg (@ahejlsberg) had that tradition of decorating significant new work with a detailed summary. I don't think it is such a bad idea.

jram (jramsay) · 2016-11-10T19:49:48Z

Adding tsconfig.json mixed content (script block) support

Vladimir Matveev (@vladima): I'll work on adding tests for this now.

…tentSupport

Vladimir Matveev (vladima) · 2016-12-03T08:30:35Z

 }

- export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program): Program {
+ export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, fileExtensionMap?: FileExtensionMap): Program {


I don't think we need to push concrete knowledge about these extra extensions through all layers, this will be necessary if we'll need to be able to add files with these extensions into program via imports or tripleslash references. Since both these scenarios are not supported and files with custom extensions should always be included in the list of root files I think we can:
revert changes in program, language service host, lsHost and services
in editor services for configured projects if host configuration specifies extra extensions and result of cracking config files contains files with these extensions - set allowNonTsExtensions bit on CompilerOptions to force adding these files into program.
this way I think we can update only project system part and keep all other layers relatively untouched.

(Note: adding this until PR #12789 is merged in so that unit tests pass)

Vladimir Matveev (vladima) · 2016-12-09T21:06:28Z

 }

- const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors);
+ const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors, fileExtensionMap);


is it not really a map anymore. maybe extraExtensions: ExtensionInfo[]?

sounds good - will switch to extraFileExtensions: FileExtensionInfo[]

…s: FileExtensionInfo[]

Vladimir Matveev (vladima) · 2016-12-09T22:14:27Z

@@ -670,7 +678,7 @@ namespace ts.server {
 // check if requested version is the same that we have reported last time


I would make it more like
letupdatedFileNames=this.updatedFileNames;this.updatedFileNames=undefined;/// use local updatedFileNames - this way we'll know that set of names is definitely cleared

Yes - good idea

… names is definitely cleared

Vladimir Matveev (vladima) · 2016-12-09T23:33:04Z

- export function getSupportedExtensions(options?: CompilerOptions): string[] {
- return options && options.allowJs ? allSupportedExtensions : supportedTypeScriptExtensions;
+ export function getSupportedExtensions(options?: CompilerOptions, extraFileExtensions?: FileExtensionInfo[]): string[] {
+ let typeScriptHostExtensions: string[] = [];


minor nit to reduce allocations:
letallExtensions: string[];letallTypeScriptExtensions: string[];constneedAllExtensions=options&&options.allowJs;if(!extraFileExtensions){returnneedAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions;}constextensions=(needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions).slice(0);for(constextofextraExtensions){if(!needAllExtensions||ext.scriptKind===ScriptKind.TS){extensions.push(ext.fileName);}}returnextensions;

clever - testing this change and will update

mihailik · 2016-12-12T09:21:27Z

What is mixed content?

Anders Hejlsberg (@ahejlsberg) had that tradition of decorating significant new work with a detailed summary. I don't think it is such a bad idea.

jram (jramsay) · 2016-11-10T19:49:48Z

Adding tsconfig.json mixed content (script block) support

Vladimir Matveev (@vladima): I'll work on adding tests for this now.

…tentSupport

Vladimir Matveev (vladima) · 2016-12-03T08:30:35Z

 }

- export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program): Program {
+ export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, fileExtensionMap?: FileExtensionMap): Program {


I don't think we need to push concrete knowledge about these extra extensions through all layers, this will be necessary if we'll need to be able to add files with these extensions into program via imports or tripleslash references. Since both these scenarios are not supported and files with custom extensions should always be included in the list of root files I think we can:
revert changes in program, language service host, lsHost and services
in editor services for configured projects if host configuration specifies extra extensions and result of cracking config files contains files with these extensions - set allowNonTsExtensions bit on CompilerOptions to force adding these files into program.
this way I think we can update only project system part and keep all other layers relatively untouched.

(Note: adding this until PR #12789 is merged in so that unit tests pass)

Vladimir Matveev (vladima) · 2016-12-09T21:06:28Z

 }

- const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors);
+ const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors, fileExtensionMap);


is it not really a map anymore. maybe extraExtensions: ExtensionInfo[]?

sounds good - will switch to extraFileExtensions: FileExtensionInfo[]

…s: FileExtensionInfo[]

Vladimir Matveev (vladima) · 2016-12-09T22:14:27Z

@@ -670,7 +678,7 @@ namespace ts.server {
 // check if requested version is the same that we have reported last time


I would make it more like
letupdatedFileNames=this.updatedFileNames;this.updatedFileNames=undefined;/// use local updatedFileNames - this way we'll know that set of names is definitely cleared

Yes - good idea

… names is definitely cleared

Vladimir Matveev (vladima) · 2016-12-09T23:33:04Z

- export function getSupportedExtensions(options?: CompilerOptions): string[] {
- return options && options.allowJs ? allSupportedExtensions : supportedTypeScriptExtensions;
+ export function getSupportedExtensions(options?: CompilerOptions, extraFileExtensions?: FileExtensionInfo[]): string[] {
+ let typeScriptHostExtensions: string[] = [];


minor nit to reduce allocations:
letallExtensions: string[];letallTypeScriptExtensions: string[];constneedAllExtensions=options&&options.allowJs;if(!extraFileExtensions){returnneedAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions;}constextensions=(needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions).slice(0);for(constextofextraExtensions){if(!needAllExtensions||ext.scriptKind===ScriptKind.TS){extensions.push(ext.fileName);}}returnextensions;

clever - testing this change and will update

mihailik · 2016-12-12T09:21:27Z

What is mixed content?

Anders Hejlsberg (@ahejlsberg) had that tradition of decorating significant new work with a detailed summary. I don't think it is such a bad idea.

jram (jramsay) · 2016-11-10T19:49:48Z

Adding tsconfig.json mixed content (script block) support

Vladimir Matveev (@vladima): I'll work on adding tests for this now.

…tentSupport

Vladimir Matveev (vladima) · 2016-12-03T08:30:35Z

 }

- export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program): Program {
+ export function createProgram(rootNames: string[], options: CompilerOptions, host?: CompilerHost, oldProgram?: Program, fileExtensionMap?: FileExtensionMap): Program {


I don't think we need to push concrete knowledge about these extra extensions through all layers, this will be necessary if we'll need to be able to add files with these extensions into program via imports or tripleslash references. Since both these scenarios are not supported and files with custom extensions should always be included in the list of root files I think we can:
revert changes in program, language service host, lsHost and services
in editor services for configured projects if host configuration specifies extra extensions and result of cracking config files contains files with these extensions - set allowNonTsExtensions bit on CompilerOptions to force adding these files into program.
this way I think we can update only project system part and keep all other layers relatively untouched.

(Note: adding this until PR #12789 is merged in so that unit tests pass)

Vladimir Matveev (vladima) · 2016-12-09T21:06:28Z

 }

- const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors);
+ const result = matchFileNames(fileNames, includeSpecs, excludeSpecs, basePath, options, host, errors, fileExtensionMap);


is it not really a map anymore. maybe extraExtensions: ExtensionInfo[]?

sounds good - will switch to extraFileExtensions: FileExtensionInfo[]

…s: FileExtensionInfo[]

Vladimir Matveev (vladima) · 2016-12-09T22:14:27Z

@@ -670,7 +678,7 @@ namespace ts.server {
 // check if requested version is the same that we have reported last time


I would make it more like
letupdatedFileNames=this.updatedFileNames;this.updatedFileNames=undefined;/// use local updatedFileNames - this way we'll know that set of names is definitely cleared

Yes - good idea

… names is definitely cleared

Vladimir Matveev (vladima) · 2016-12-09T23:33:04Z

- export function getSupportedExtensions(options?: CompilerOptions): string[] {
- return options && options.allowJs ? allSupportedExtensions : supportedTypeScriptExtensions;
+ export function getSupportedExtensions(options?: CompilerOptions, extraFileExtensions?: FileExtensionInfo[]): string[] {
+ let typeScriptHostExtensions: string[] = [];


minor nit to reduce allocations:
letallExtensions: string[];letallTypeScriptExtensions: string[];constneedAllExtensions=options&&options.allowJs;if(!extraFileExtensions){returnneedAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions;}constextensions=(needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions).slice(0);for(constextofextraExtensions){if(!needAllExtensions||ext.scriptKind===ScriptKind.TS){extensions.push(ext.fileName);}}returnextensions;

clever - testing this change and will update

mihailik · 2016-12-12T09:21:27Z

What is mixed content?

Anders Hejlsberg (@ahejlsberg) had that tradition of decorating significant new work with a detailed summary. I don't think it is such a bad idea.

Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label Nov 10, 2016

tsconfig.json mixed content support
da7f824

jram (jramsay)force-pushed the tsconfigMixedContentSupport branch from b90ce31 to da7f824Compare November 14, 2016 21:31

jram (jramsay) added 4 commits November 18, 2016 15:51

tsconfig.json mixed content support
7dd30db

Merge branch 'master' into tsconfigMixedContentSupport
891173c

Merge branch 'master' into tsconfigMixedContentSupportRedux
464bc0e

Merge branch 'tsconfigMixedContentSupportRedux' into tsconfigMixedCon…
12971d2
…tentSupport

Vladimir Matveev (vladima) reviewed Dec 3, 2016
View reviewed changes

jram (jramsay) added 6 commits December 7, 2016 15:31

Reduced version from CR comments
64dad30

Merge branch 'master' into tsconfigMixedContentSupportRedux
1c3689e

Fix merge issues
7a11453

Changes due to CR comments
d528943

Merge branch 'master' into tsconfigMixedContentSupport
4cb5a36

Mark containing project as dirty when file is closed
5f46e48
(Note: adding this until PR #12789 is merged in so that unit tests pass)

jram (jramsay)force-pushed the tsconfigMixedContentSupport branch from 6d2b3c5 to 5f46e48Compare December 9, 2016 19:12

Vladimir Matveev (vladima) reviewed Dec 9, 2016
View reviewed changes

Rename fileExtensionMap: fileExtensionMapItem[] to extraFileExtension…
05160ca
…s: FileExtensionInfo[]

Vladimir Matveev (vladima) reviewed Dec 9, 2016
View reviewed changes

jram (jramsay) added 2 commits December 9, 2016 14:24

Merge branch 'master' into tsconfigMixedContentSupport
30bd841

use localUse local updatedFileNames - this way we'll know that set of…
5829ca8
… names is definitely cleared

Vladimir Matveev (vladima) reviewed Dec 9, 2016
View reviewed changes

getSupportedExtensions optimization to reduce allocations
c40508c

Vladimir Matveev (vladima) approved these changes Dec 10, 2016
View reviewed changes

jram (jramsay) merged commit f27fe0d into masterDec 10, 2016

Mohamed Hegazy (mhegazy) mentioned this pull request Dec 12, 2016
Merge master 12/12 #12864
Merged

Mohamed Hegazy (mhegazy) deleted the tsconfigMixedContentSupport branch November 2, 2017 21:03

Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018