Allow brace completion in comments by anubmat · Pull Request #12741 · microsoft/TypeScript

Anubha Mathur (anubmat) · 2016-12-08T00:07:54Z

Allows brace completion inside comments in JS and TS files

…ionInComments

Microsoft Contribution License Agreements (msftclas) · 2016-12-08T00:07:58Z

Hi Anubha Mathur (@anubmat), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anubha Mathur). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Anubha Mathur (anubmat) · 2016-12-08T00:28:03Z

jram (@jramsay) , Paul van Brenk (@paulvanbrenk) , Bill Ticehurst (@billti) , Vlad Yazhbin [twitter.com/vla] (@vlad), Can someone please review?

Paul van Brenk (paulvanbrenk) · 2016-12-08T00:32:08Z

 const sourceFile = syntaxTreeCache.getCurrentSourceFile(fileName);

 // Check if in a context where we don't want to perform any insertion
- if (isInString(sourceFile, position) || isInComment(sourceFile, position)) {


This should only be the case for { not for all braces. IMO

Doesn't work for <>. But why should it exclude () and []?

What does C# do?

c# does no completions for any type of braces inside comments..

c# is smart, otherwise too outside comments, it only completes when brackets are placed in an expected location

Ok, Don't have a strong opinion either way..

Bill Ticehurst (billti) · 2016-12-08T19:29:28Z

How does this behave in the editor? If we auto-complete the closing brace, (so after typing the opening brace the cursor is at ( | ) ), then when I type a closing brace, does it automatically just move me past the auto-inserted one, and not add an additional closing brace (i.e. I should end up with ( ) |, not ( ) | ) ).

Anubha Mathur (anubmat) · 2016-12-08T19:50:29Z

The behavior is same as outside comments, i.e. on typing the closing brace, it moves past the auto-inserted one and does not add an additional closing brace, like that ( ) |

Bill Ticehurst (billti) · 2016-12-08T21:08:58Z

Great, thanks. If you've tried it out in VS and VS Code and the experience feels right, then 👍 :-)

Anubha Mathur (anubmat) · 2016-12-08T22:12:59Z

I tried and it works nicely in VS. As for VsCode, brace completion was already working inside comments.

Anubha Mathur (anubmat) · 2016-12-08T00:07:54Z

Allows brace completion inside comments in JS and TS files

…ionInComments

Microsoft Contribution License Agreements (msftclas) · 2016-12-08T00:07:58Z

Hi Anubha Mathur (@anubmat), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anubha Mathur). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Anubha Mathur (anubmat) · 2016-12-08T00:28:03Z

jram (@jramsay) , Paul van Brenk (@paulvanbrenk) , Bill Ticehurst (@billti) , Vlad Yazhbin [twitter.com/vla] (@vlad), Can someone please review?

Paul van Brenk (paulvanbrenk) · 2016-12-08T00:32:08Z

 const sourceFile = syntaxTreeCache.getCurrentSourceFile(fileName);

 // Check if in a context where we don't want to perform any insertion
- if (isInString(sourceFile, position) || isInComment(sourceFile, position)) {


This should only be the case for { not for all braces. IMO

Doesn't work for <>. But why should it exclude () and []?

What does C# do?

c# does no completions for any type of braces inside comments..

c# is smart, otherwise too outside comments, it only completes when brackets are placed in an expected location

Ok, Don't have a strong opinion either way..

Bill Ticehurst (billti) · 2016-12-08T19:29:28Z

How does this behave in the editor? If we auto-complete the closing brace, (so after typing the opening brace the cursor is at ( | ) ), then when I type a closing brace, does it automatically just move me past the auto-inserted one, and not add an additional closing brace (i.e. I should end up with ( ) |, not ( ) | ) ).

Anubha Mathur (anubmat) · 2016-12-08T19:50:29Z

The behavior is same as outside comments, i.e. on typing the closing brace, it moves past the auto-inserted one and does not add an additional closing brace, like that ( ) |

Bill Ticehurst (billti) · 2016-12-08T21:08:58Z

Great, thanks. If you've tried it out in VS and VS Code and the experience feels right, then 👍 :-)

Anubha Mathur (anubmat) · 2016-12-08T22:12:59Z

I tried and it works nicely in VS. As for VsCode, brace completion was already working inside comments.

Anubha Mathur (anubmat) · 2016-12-08T00:07:54Z

Allows brace completion inside comments in JS and TS files

…ionInComments

Microsoft Contribution License Agreements (msftclas) · 2016-12-08T00:07:58Z

Hi Anubha Mathur (@anubmat), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anubha Mathur). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Anubha Mathur (anubmat) · 2016-12-08T00:28:03Z

jram (@jramsay) , Paul van Brenk (@paulvanbrenk) , Bill Ticehurst (@billti) , Vlad Yazhbin [twitter.com/vla] (@vlad), Can someone please review?

Paul van Brenk (paulvanbrenk) · 2016-12-08T00:32:08Z

 const sourceFile = syntaxTreeCache.getCurrentSourceFile(fileName);

 // Check if in a context where we don't want to perform any insertion
- if (isInString(sourceFile, position) || isInComment(sourceFile, position)) {


This should only be the case for { not for all braces. IMO

Doesn't work for <>. But why should it exclude () and []?

What does C# do?

c# does no completions for any type of braces inside comments..

c# is smart, otherwise too outside comments, it only completes when brackets are placed in an expected location

Ok, Don't have a strong opinion either way..

Bill Ticehurst (billti) · 2016-12-08T19:29:28Z

How does this behave in the editor? If we auto-complete the closing brace, (so after typing the opening brace the cursor is at ( | ) ), then when I type a closing brace, does it automatically just move me past the auto-inserted one, and not add an additional closing brace (i.e. I should end up with ( ) |, not ( ) | ) ).

Anubha Mathur (anubmat) · 2016-12-08T19:50:29Z

The behavior is same as outside comments, i.e. on typing the closing brace, it moves past the auto-inserted one and does not add an additional closing brace, like that ( ) |

Bill Ticehurst (billti) · 2016-12-08T21:08:58Z

Great, thanks. If you've tried it out in VS and VS Code and the experience feels right, then 👍 :-)

Anubha Mathur (anubmat) · 2016-12-08T22:12:59Z

I tried and it works nicely in VS. As for VsCode, brace completion was already working inside comments.

Anubha Mathur (anubmat) · 2016-12-08T00:07:54Z

Allows brace completion inside comments in JS and TS files

…ionInComments

Microsoft Contribution License Agreements (msftclas) · 2016-12-08T00:07:58Z

Hi Anubha Mathur (@anubmat), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anubha Mathur). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Anubha Mathur (anubmat) · 2016-12-08T00:28:03Z

jram (@jramsay) , Paul van Brenk (@paulvanbrenk) , Bill Ticehurst (@billti) , Vlad Yazhbin [twitter.com/vla] (@vlad), Can someone please review?

Paul van Brenk (paulvanbrenk) · 2016-12-08T00:32:08Z

 const sourceFile = syntaxTreeCache.getCurrentSourceFile(fileName);

 // Check if in a context where we don't want to perform any insertion
- if (isInString(sourceFile, position) || isInComment(sourceFile, position)) {


This should only be the case for { not for all braces. IMO

Doesn't work for <>. But why should it exclude () and []?

What does C# do?

c# does no completions for any type of braces inside comments..

c# is smart, otherwise too outside comments, it only completes when brackets are placed in an expected location

Ok, Don't have a strong opinion either way..

Bill Ticehurst (billti) · 2016-12-08T19:29:28Z

How does this behave in the editor? If we auto-complete the closing brace, (so after typing the opening brace the cursor is at ( | ) ), then when I type a closing brace, does it automatically just move me past the auto-inserted one, and not add an additional closing brace (i.e. I should end up with ( ) |, not ( ) | ) ).

Anubha Mathur (anubmat) · 2016-12-08T19:50:29Z

The behavior is same as outside comments, i.e. on typing the closing brace, it moves past the auto-inserted one and does not add an additional closing brace, like that ( ) |

Bill Ticehurst (billti) · 2016-12-08T21:08:58Z

Great, thanks. If you've tried it out in VS and VS Code and the experience feels right, then 👍 :-)

Anubha Mathur (anubmat) · 2016-12-08T22:12:59Z

I tried and it works nicely in VS. As for VsCode, brace completion was already working inside comments.

Anubha Mathur (anubmat) · 2016-12-08T00:07:54Z

Allows brace completion inside comments in JS and TS files

…ionInComments

Microsoft Contribution License Agreements (msftclas) · 2016-12-08T00:07:58Z

Hi Anubha Mathur (@anubmat), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anubha Mathur). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Anubha Mathur (anubmat) · 2016-12-08T00:28:03Z

jram (@jramsay) , Paul van Brenk (@paulvanbrenk) , Bill Ticehurst (@billti) , Vlad Yazhbin [twitter.com/vla] (@vlad), Can someone please review?

Paul van Brenk (paulvanbrenk) · 2016-12-08T00:32:08Z

 const sourceFile = syntaxTreeCache.getCurrentSourceFile(fileName);

 // Check if in a context where we don't want to perform any insertion
- if (isInString(sourceFile, position) || isInComment(sourceFile, position)) {


This should only be the case for { not for all braces. IMO

Doesn't work for <>. But why should it exclude () and []?

What does C# do?

c# does no completions for any type of braces inside comments..

c# is smart, otherwise too outside comments, it only completes when brackets are placed in an expected location

Ok, Don't have a strong opinion either way..

Bill Ticehurst (billti) · 2016-12-08T19:29:28Z

How does this behave in the editor? If we auto-complete the closing brace, (so after typing the opening brace the cursor is at ( | ) ), then when I type a closing brace, does it automatically just move me past the auto-inserted one, and not add an additional closing brace (i.e. I should end up with ( ) |, not ( ) | ) ).

Anubha Mathur (anubmat) · 2016-12-08T19:50:29Z

The behavior is same as outside comments, i.e. on typing the closing brace, it moves past the auto-inserted one and does not add an additional closing brace, like that ( ) |

Bill Ticehurst (billti) · 2016-12-08T21:08:58Z

Great, thanks. If you've tried it out in VS and VS Code and the experience feels right, then 👍 :-)

Anubha Mathur (anubmat) · 2016-12-08T22:12:59Z

I tried and it works nicely in VS. As for VsCode, brace completion was already working inside comments.

Anubha Mathur (anubmat) · 2016-12-08T00:07:54Z

Allows brace completion inside comments in JS and TS files

…ionInComments

Microsoft Contribution License Agreements (msftclas) · 2016-12-08T00:07:58Z

Hi Anubha Mathur (@anubmat), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anubha Mathur). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Anubha Mathur (anubmat) · 2016-12-08T00:28:03Z

jram (@jramsay) , Paul van Brenk (@paulvanbrenk) , Bill Ticehurst (@billti) , Vlad Yazhbin [twitter.com/vla] (@vlad), Can someone please review?

Paul van Brenk (paulvanbrenk) · 2016-12-08T00:32:08Z

 const sourceFile = syntaxTreeCache.getCurrentSourceFile(fileName);

 // Check if in a context where we don't want to perform any insertion
- if (isInString(sourceFile, position) || isInComment(sourceFile, position)) {


This should only be the case for { not for all braces. IMO

Doesn't work for <>. But why should it exclude () and []?

What does C# do?

c# does no completions for any type of braces inside comments..

c# is smart, otherwise too outside comments, it only completes when brackets are placed in an expected location

Ok, Don't have a strong opinion either way..

Bill Ticehurst (billti) · 2016-12-08T19:29:28Z

How does this behave in the editor? If we auto-complete the closing brace, (so after typing the opening brace the cursor is at ( | ) ), then when I type a closing brace, does it automatically just move me past the auto-inserted one, and not add an additional closing brace (i.e. I should end up with ( ) |, not ( ) | ) ).

Anubha Mathur (anubmat) · 2016-12-08T19:50:29Z

The behavior is same as outside comments, i.e. on typing the closing brace, it moves past the auto-inserted one and does not add an additional closing brace, like that ( ) |

Bill Ticehurst (billti) · 2016-12-08T21:08:58Z

Great, thanks. If you've tried it out in VS and VS Code and the experience feels right, then 👍 :-)

Anubha Mathur (anubmat) · 2016-12-08T22:12:59Z

I tried and it works nicely in VS. As for VsCode, brace completion was already working inside comments.

Anubha Mathur (anubmat) · 2016-12-08T00:07:54Z

Allows brace completion inside comments in JS and TS files

…ionInComments

Microsoft Contribution License Agreements (msftclas) · 2016-12-08T00:07:58Z

Hi Anubha Mathur (@anubmat), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anubha Mathur). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Anubha Mathur (anubmat) · 2016-12-08T00:28:03Z

jram (@jramsay) , Paul van Brenk (@paulvanbrenk) , Bill Ticehurst (@billti) , Vlad Yazhbin [twitter.com/vla] (@vlad), Can someone please review?

Paul van Brenk (paulvanbrenk) · 2016-12-08T00:32:08Z

 const sourceFile = syntaxTreeCache.getCurrentSourceFile(fileName);

 // Check if in a context where we don't want to perform any insertion
- if (isInString(sourceFile, position) || isInComment(sourceFile, position)) {


This should only be the case for { not for all braces. IMO

Doesn't work for <>. But why should it exclude () and []?

What does C# do?

c# does no completions for any type of braces inside comments..

c# is smart, otherwise too outside comments, it only completes when brackets are placed in an expected location

Ok, Don't have a strong opinion either way..

Bill Ticehurst (billti) · 2016-12-08T19:29:28Z

How does this behave in the editor? If we auto-complete the closing brace, (so after typing the opening brace the cursor is at ( | ) ), then when I type a closing brace, does it automatically just move me past the auto-inserted one, and not add an additional closing brace (i.e. I should end up with ( ) |, not ( ) | ) ).

Anubha Mathur (anubmat) · 2016-12-08T19:50:29Z

The behavior is same as outside comments, i.e. on typing the closing brace, it moves past the auto-inserted one and does not add an additional closing brace, like that ( ) |

Bill Ticehurst (billti) · 2016-12-08T21:08:58Z

Great, thanks. If you've tried it out in VS and VS Code and the experience feels right, then 👍 :-)

Anubha Mathur (anubmat) · 2016-12-08T22:12:59Z

I tried and it works nicely in VS. As for VsCode, brace completion was already working inside comments.

Anubha Mathur (anubmat) · 2016-12-08T00:07:54Z

Allows brace completion inside comments in JS and TS files

…ionInComments

Microsoft Contribution License Agreements (msftclas) · 2016-12-08T00:07:58Z

Hi Anubha Mathur (@anubmat), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Anubha Mathur). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Anubha Mathur (anubmat) · 2016-12-08T00:28:03Z

jram (@jramsay) , Paul van Brenk (@paulvanbrenk) , Bill Ticehurst (@billti) , Vlad Yazhbin [twitter.com/vla] (@vlad), Can someone please review?

Paul van Brenk (paulvanbrenk) · 2016-12-08T00:32:08Z

 const sourceFile = syntaxTreeCache.getCurrentSourceFile(fileName);

 // Check if in a context where we don't want to perform any insertion
- if (isInString(sourceFile, position) || isInComment(sourceFile, position)) {


This should only be the case for { not for all braces. IMO

Doesn't work for <>. But why should it exclude () and []?

What does C# do?

c# does no completions for any type of braces inside comments..

c# is smart, otherwise too outside comments, it only completes when brackets are placed in an expected location

Ok, Don't have a strong opinion either way..

Bill Ticehurst (billti) · 2016-12-08T19:29:28Z

How does this behave in the editor? If we auto-complete the closing brace, (so after typing the opening brace the cursor is at ( | ) ), then when I type a closing brace, does it automatically just move me past the auto-inserted one, and not add an additional closing brace (i.e. I should end up with ( ) |, not ( ) | ) ).

Anubha Mathur (anubmat) · 2016-12-08T19:50:29Z

The behavior is same as outside comments, i.e. on typing the closing brace, it moves past the auto-inserted one and does not add an additional closing brace, like that ( ) |

Bill Ticehurst (billti) · 2016-12-08T21:08:58Z

Great, thanks. If you've tried it out in VS and VS Code and the experience feels right, then 👍 :-)

Anubha Mathur (anubmat) · 2016-12-08T22:12:59Z

I tried and it works nicely in VS. As for VsCode, brace completion was already working inside comments.

Anubha Mathur (anubmat) added 2 commits December 7, 2016 15:58

Allowing brace completion inside comments in JS and TS files
31dde97

Merge remote-tracking branch 'origin/master' into allowBracketComplet…
cb0beb8
…ionInComments

Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Dec 8, 2016

Paul van Brenk (paulvanbrenk) reviewed Dec 8, 2016
View reviewed changes

Daniel Rosenwasser (DanielRosenwasser) changed the title ~~Allow bracket completion in comments~~Allow brace completion in commentsDec 8, 2016

Anubha Mathur (anubmat) merged commit 9dd769d into masterDec 8, 2016

Anubha Mathur (anubmat) deleted the allowBracketCompletionInComments branch December 8, 2016 22:37

Mohamed Hegazy (mhegazy) mentioned this pull request Dec 12, 2016
Merge master 12/12 #12864
Merged

Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018