Uh oh!
There was an error while loading. Please reload this page.
TypedArrays: fixed find and findIndex callback param obj type. - #18493
Merged
Conversation
Adrian Leonhard (@NaridaL), |
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| find(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number | undefined; | ||
| find(predicate: (value: number, index: number, obj: Int16Array) => boolean, thisArg?: any): number | undefined; |
Contributor
There was a problem hiding this comment.
Uint16Array ?
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| findIndex(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number; | ||
| findIndex(predicate: (value: number, index: number, obj: Int16Array) => boolean, thisArg?: any): number; |
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| find(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number | undefined; | ||
| find(predicate: (value: number, index: number, obj: Int32Array) => boolean, thisArg?: any): number | undefined; |
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| findIndex(predicate: (value: number, index: number, obj: Array<number>) => boolean, thisArg?: any): number; | ||
| findIndex(predicate: (value: number, index: number, obj: Int32Array) => boolean, thisArg?: any): number; |
Adrian Leonhard (NaridaL)force-pushed
the
fix18425
branch
from
September 14, 2017 23:58
2948c5b to
c06d532CompareAdrian Leonhard (NaridaL)
commented
Sep 15, 2017
ContributorAuthor
Yeah... sorry about that. BTW, I tried it with the separate TypedArray interface, and it seems to be an improvement... previous: now: ... not sure if those statistics are the only relevant thing though. |
Adrian Leonhard (NaridaL)
commented
Sep 15, 2017
ContributorAuthor
Oh yeah, the issues with U/Intarray should be fixed now, because it's not immediately obvious from the code reviews^^. |
Mohamed Hegazy (mhegazy)
commented
Sep 18, 2017
Contributor
We should be moving them out of es5.d.ts anyways. #15780 should be in first though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#18425.