Uh oh!
There was an error while loading. Please reload this page.
Mark fresh spread types with ContainsObjectLiteral - #19250
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoOct 17, 2017
Merged
Conversation
Nathan Shively-Sanders (sandersn)
requested review from
Mohamed Hegazy (mhegazy) and Wesley Wigham (weswigham)October 17, 2017 17:05
Wesley Wigham (weswigham)
approved these changes
Oct 17, 2017
Mohamed Hegazy (mhegazy)
approved these changes
Oct 17, 2017
Nathan Shively-Sanders (sandersn)
deleted the
mark-fresh-spread-types-with-ContainsObjectLiteral
branch
October 17, 2017 18:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#19226
getSpreadTypeno longer addedTypeFlags.ContainsObjectLiteralafter I moved the flag-setting code there in #18965. It takes a parameterpropagatedFlagsfromcheckObjectLiteral, butpropagatedFlagsmutates over the course ofcheckObjectLiteralso it doesn't containContainsObjectLiteralnow. The right thing is forgetSpreadTypeto explicitly markContainsObjectLiteralon all its fresh object types.