Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 13.8k
Api for creating program in watch mode and using builder to get incremental emit/semantic diagnostics#20234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
a06f0c3576fe1e7ebf9d93c5a6e1c9a17f36d36a3d85ce1d0e102feeffa64e8012f12b0b79f4a374536b3dda21761fc9b9471c83b1a91256f046d82944f8b843c2610e694b9e8cc2936abafddd77e6731d22ba5ec9a407e14f66efa21b074eb052fe39bf33d4c21cbf2586bb3bb0fc0d965f40fdc62bb99b54d2e8ad9a62a75badf2611c9bcb263665bc78af5bd3f976650029ed23ca529dee9ff29c0e3bd43e452be231d8a51cdaFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but if we try to emit this file with this emit resolver the emit will fail, e.g. marking aliases as referenced would not have happened.. right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would not impact declaration file emit right? I mean there could be errors but the output wont change and hence ok to do so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to document that well.. also maybe change the parameter name to something more declarative like
declarationFileEmitOnly. i worry that someone will just create this and pass true by mistake and will be hard to see why it is failing.