JsxTagNameExpression can only be Identifier | ThisExpression, not any PrimaryExpression

[Deleted user (ghost)]

Noticed this while looking at some jsx-using code -- we were typing this as PrimaryExpression but could be a lot more strict.

[Ben Lichtman (uniqueiniquity)]

I mean, while you're at it, it seems like PropertyAccessExpression is not particularly strict either, given JSXMemberExpression in https://github.com/facebook/jsx/blob/master/README.md. I think your change is fine but I would recommend waiting for someone more familiar with our grammar to agree.

[Ron Buckton (rbuckton)]

This is fine, but as Ben Lichtman (@uniqueiniquity) mentioned, if we're that concerned about strictness here then we would probably want to add a:

exporttypeJsxTagNameExpression=Identifier|ThisExpression|JsxMemberExpression;exportinterfaceJsxMemberExpressionextendsPropertyAccessExpression{expression: JsxTagNameExpression;}

[Deleted user (ghost)]

I think we could just use EntityNameExpression | ThisExpression, but let's wait on #21588 first.

[Deleted user (ghost)]

Ben Lichtman (@uniqueiniquity)Ron Buckton (@rbuckton) Please re-review

[TypeScript Bot (typescript-bot)]

Thanks for your contribution. This PR has not been updated in a while and cannot be automatically merged at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to continue working on this PR, please leave a message and one of the maintainers can reopen it.

[Deleted user (ghost)]

Ben Lichtman (@uniqueiniquity)Ron Buckton (@rbuckton) Please re-review