Uh oh!
There was an error while loading. Please reload this page.
Enable member completions for import types - #23085
Merged
Wesley Wigham (weswigham) merged 6 commits intoApr 3, 2018
Merged
Conversation
Wesley Wigham (weswigham)
requested review from
a user, Mohamed Hegazy (mhegazy) and Sheetal Nandi (sheetalkamat)April 2, 2018 20:16
| return typeChecker.isValidPropertyAccess(<PropertyAccessExpression>(node.parent), symbol.name); | ||
| } | ||
| else { | ||
| if (!(node as ImportTypeNode).isTypeOf) return false; |
There was a problem hiding this comment.
Use a && b instead of if (!a) return false; return b;
Mohamed Hegazy (mhegazy)
approved these changes
Apr 2, 2018
| return typeChecker.isValidPropertyAccess(<PropertyAccessExpression>(node.parent), symbol.name); | ||
| } | ||
| else { | ||
| return !(node as ImportTypeNode).isTypeOf && !!(symbol.flags & SymbolFlags.Value); |
There was a problem hiding this comment.
Dont you still need typeChecker.isValidPropertyAccess especially checkPropertyAccessibility needs to be done to avoid not showing non exported stuff?
MemberAuthor
There was a problem hiding this comment.
Non-exported symbols aren't returned by getExportsOfModule - except for class statics! I'll add a test.
Wesley Wigham (weswigham)force-pushed
the
import-types-completions
branch
from
April 3, 2018 01:15
f570a8f to
01ea0a6CompareWesley Wigham (weswigham)
commented
Apr 3, 2018
MemberAuthor
Sheetal Nandi (@sheetalkamat) Can I get a rereview? |
Sheetal Nandi (sheetalkamat)
approved these changes
Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes one of the points brought up in this comment.