Skip to content

Correctly show instantiated signatures for JSX element signature help and quick info - #23492

Merged
Wesley Wigham (weswigham) merged 4 commits into
microsoft:masterfrom
weswigham:jsx-signature-help
May 16, 2018
Merged

Correctly show instantiated signatures for JSX element signature help and quick info#23492
Wesley Wigham (weswigham) merged 4 commits into
microsoft:masterfrom
weswigham:jsx-signature-help

Conversation

@weswigham

@weswighamWesley Wigham (weswigham) commented Apr 17, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#22873
Fixes#22636

@weswighamWesley Wigham (weswigham) changed the title Correctly show instantiated signatures for JSX element signature helpCorrectly show instantiated signatures for JSX element signature help and quick infoApr 18, 2018
@ajafffKlaus Meinhardt (ajafff) mentioned this pull request Apr 26, 2018
Closed
@weswighamWesley Wigham (weswigham) mentioned this pull request May 4, 2018
Merged
@mhegazy

Mohamed Hegazy (mhegazy) commented May 16, 2018

Copy link
Copy Markdown
Contributor

Nathan Shively-Sanders (@sandersn) can you also take a look

@weswigham
Wesley Wigham (weswigham) merged commit e01c7d2 into microsoft:masterMay 16, 2018
@weswigham

Wesley Wigham (weswigham) commented May 16, 2018

Copy link
Copy Markdown
MemberAuthor

Mohamed Hegazy (@mhegazy) do I need to port this to the 2.9 branch?

@sandersn

Nathan Shively-Sanders (sandersn) commented May 16, 2018

Copy link
Copy Markdown
Member

I think this broke the build. It needs to use verify.signatureHelp({text: "..."}) instead of verify.SignatureHelpIs("...")

@weswigham
Wesley Wigham (weswigham) deleted the jsx-signature-help branch May 16, 2018 20:47
@weswigham

Wesley Wigham (weswigham) commented May 16, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Older PRs are great 😉 I've opened (and then merged) #24179 with the fix.

@ghostghost mentioned this pull request May 17, 2018
Merged
@microsoftMicrosoft (microsoft) locked and limited conversation to collaborators Jul 31, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersnNathan Shively-Sanders (sandersn)Awaiting requested review from sandersn
1 more reviewer
@mhegazyMohamed Hegazy (mhegazy)mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weswigham@mhegazy@sandersn