Uh oh!
There was an error while loading. Please reload this page.
Fix async generator rejection handling - #24078
Merged
Merged
Conversation
Ron Buckton (rbuckton)
requested review from
Mohamed Hegazy (mhegazy) and Wesley Wigham (weswigham)May 12, 2018 09:19
Wesley Wigham (weswigham)
approved these changes
May 14, 2018
falsandtru (falsandtru)
commented
May 14, 2018
Contributor
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
__asyncValuesto more correctly align with CreateAsyncFromSyncIterator, and updates__asyncDelegatorto ensurethrowis correctly propagated.Similar changes will also need to be made to tslib in a separate PR.
Fixes#24014