Uh oh!
There was an error while loading. Please reload this page.
Don't report unused diagnostics when the unused node has a parse error - #25598
Merged
2 commits merged intoJul 13, 2018
Merged
Conversation
ghost
requested review from
Daniel Rosenwasser (DanielRosenwasser), Andrew Casey (amcasey) and Mohamed Hegazy (mhegazy)July 12, 2018 01:25
ghost
force-pushed
the
noSuggestionDiagnosticsOnParseError
branch
from
July 12, 2018 01:27
3f62a5c to
23d0baeCompare
ghost
force-pushed
the
noSuggestionDiagnosticsOnParseError
branch
from
July 12, 2018 01:56
23d0bae to
e26e448CompareAndrew Casey (amcasey)
approved these changes
Jul 12, 2018
Andrew Casey (amcasey)
left a comment
Member
There was a problem hiding this comment.
Seems reasonable, assuming Matt confirms it doesn't cause flicker.
Mohamed Hegazy (mhegazy)
approved these changes
Jul 12, 2018
Deleted user (ghost)
commented
Jul 12, 2018
Author
Waiting for Matt Bierner (@mjbvz) to verify |
Matt Bierner (mjbvz)
commented
Jul 12, 2018
Andy (Andrewkraft) (@Andy-MS) I'm still see the diagnostics when using the TS version from this PR, at least for the cases in #25591 |
Deleted user (ghost)
commented
Jul 13, 2018
Author
Here's what it looks like to me:
|
Matt Bierner (mjbvz)
commented
Jul 13, 2018
Andy (Andrewkraft) (@Andy-MS) You're right. I ran the wrong build command. Seems to be working well. I haven't notice any flickering or other odd behavior in my testing |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#25591