Uh oh!
There was an error while loading. Please reload this page.
Delay load configured project referenced from external project when opening it - #25884
Merged
Sheetal Nandi (sheetalkamat) merged 3 commits intoAug 17, 2018
Merged
Conversation
Sheetal Nandi (sheetalkamat)force-pushed
the
optimizeOpenExternalProject
branch
from
August 1, 2018 22:47
4716d31 to
8c5ae9bCompare…igured project referenced from external project when opening it
Since external projects are needed to be uptodate when opening file, so in most likely scenarios these will be loaded anyways so there is no saving in postponing this work
…ynchronizeProjectList for project opened by external project
Sheetal Nandi (sheetalkamat)force-pushed
the
optimizeOpenExternalProject
branch
from
August 6, 2018 23:24
8c5ae9b to
f67bdd4CompareSheetal Nandi (sheetalkamat)
requested a review
from Ryan Cavanaugh (RyanCavanaugh)August 14, 2018 23:30
Sheetal Nandi (sheetalkamat)
commented
Aug 14, 2018
MemberAuthor
Ryan Cavanaugh (@RyanCavanaugh) this is the PR that does lazy loading of configured projects as discussed offline. |
| setProjectOptionsUsed(project); | ||
| const data: ProjectInfoTelemetryEventData = { | ||
| projectId: this.host.createSHA256Hash(projectKey), | ||
| projectId: this.host.createSHA256Hash(project.projectName), |
There was a problem hiding this comment.
Andrew Casey (@amcasey) is this OK?
There was a problem hiding this comment.
Since projects are not 1:1 with users or devices and the hash function is cryptographically secure, I understand that this is okay.
MemberAuthor
There was a problem hiding this comment.
Note that this isnt a real change since project key was project.projectName (configFile name for configured projects and external project name ) so this is just instead of passing it through the calls uses it directly through the key, hence no changes in the tests as well.
Ryan Cavanaugh (RyanCavanaugh)
commented
Aug 16, 2018
Member
Overall LGTM; just had a GDPR compliance check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change Configured projects that are part of external project, are just is just created but reading the config file and creating program based on the root files is postponed to when needed.
To delay loading for config file and program the changes included are:
compileOnSaveAffectedFileListdo not load all projects if the project to get list on affected file list is specifiedsynchronizeProjectListsend file names as empty list for configured projects that aren't loaded yet.