Uh oh!
There was an error while loading. Please reload this page.
Don't error on destructure of private property with computed property syntax - #26360
Merged
1 commit merged intoAug 10, 2018
Merged
Don't error on destructure of private property with computed property syntax#263601 commit merged into
1 commit merged into
Conversation
Klaus Meinhardt (ajafff)
approved these changes
Aug 10, 2018
Sheetal Nandi (sheetalkamat)
approved these changes
Aug 10, 2018
ghost
deleted the
destructureComputedProperty_private
branch
August 10, 2018 22:11
Albert Siddhartha Slawinski (errendir) added a commit
to errendir/TypeScript
that referenced
this pull request
Aug 11, 2018
* origin/master: (283 commits) Don't error on destructure of private property with computed property syntax (microsoft#26360) getDefaultExportInfo: Use `getImmediateAliasedSymbol` instead of `getAliasedSymbol` (microsoft#26364) review comments restore old algorithm Dont use baseURL relative absolute paths in declaration emit, use absolute paths in bundle emit (microsoft#26341) Update user baselines (microsoft#26358) Don't store @template constraint in a TypeParameterDeclaration node (microsoft#26283) fixAddMissingMember: Support interface and don't crash on type parameter (microsoft#25995) Don't include class getter in spread type (microsoft#26287) Don't crash on computed property in destructure (microsoft#26334) Check the ambientness of a symbol name before attempting to trim it (microsoft#26312) Still generate signatures in SkipContextSensitive mode just to match on return types (microsoft#25937) fix handling if there is no commonPrefix Actually add sorting of elaboration text to user baselines Ping ryan instead of mohammed for user PRs now handle failed lookups make it work for root directory really, really fix test(?) add test fix commonPrefix handling ...
Klaus Meinhardt (ajafff) added a commit
to ajafff/TypeScript
that referenced
this pull request
Aug 23, 2018
…y with computed property syntax
Ryan Cavanaugh (RyanCavanaugh) added a commit
that referenced
this pull request
Aug 24, 2018
…mputed-name Revert #26360: Don't error on destructure of private property with computed property syntax
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#26356
I wasn't sure whether
"p": pshould error or not. Currently it does and you need["p"]: pto access a private property.