Api review cleanup#2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mohamed Hegazy (mhegazy) merged 10 commits into from
Apr 11, 2015
Merged

Api review cleanup #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b0bbf9
Remove step to build typeScript_internal.d.ts
mhegazy Apr 9, 2015
1c91c2c
Mark non-public API surface with the /* @internal */ comment
mhegazy Apr 9, 2015
9fdeffe
Fix formatting and parameter names
mhegazy Apr 9, 2015
e30f0d4
Make version const
mhegazy Apr 9, 2015
97a4c24
Expose parseCommandLine
mhegazy Apr 9, 2015
4a5d3a2
Remove _internal.d.ts files from LKG
mhegazy Apr 9, 2015
03685f4
Update LKG
mhegazy Apr 9, 2015
431dce7
Merge branch 'master' into APIReviewCleanup
mhegazy Apr 10, 2015
13ef271
use @internal comment consistenlly
mhegazy Apr 10, 2015
6f1feff
Update LKG
mhegazy Apr 11, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 14 additions & 60 deletions Jakefile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -105,24 +105,6 @@ var serverSources = [
return path.join(serverDirectory, f);
});

var definitionsRoots = [
"compiler/types.d.ts",
"compiler/scanner.d.ts",
"compiler/parser.d.ts",
"compiler/checker.d.ts",
"compiler/program.d.ts",
"compiler/commandLineParser.d.ts",
"services/services.d.ts",
];

var internalDefinitionsRoots = [
"compiler/core.d.ts",
"compiler/sys.d.ts",
"compiler/utilities.d.ts",
"compiler/commandLineParser.d.ts",
"services/utilities.d.ts",
];

var harnessSources = [
"harness.ts",
"sourceMapRecorder.ts",
Expand DownExpand Up@@ -354,60 +336,32 @@ var tscFile = path.join(builtLocalDirectory, compilerFilename);
compileFile(tscFile, compilerSources, [builtLocalDirectory, copyright].concat(compilerSources), [copyright], /*useBuiltCompiler:*/ false);

var servicesFile = path.join(builtLocalDirectory, "typescriptServices.js");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var nodePackageFile = path.join(builtLocalDirectory, "typescript.js");
var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");

compileFile(servicesFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
/*prefixes*/ [copyright],
/*useBuiltCompiler*/ true,
/*noOutFile*/ false,
/*generateDeclarations*/ false,
/*generateDeclarations*/ true,
/*outDir*/ undefined,
/*preserveConstEnums*/ true,
/*keepComments*/ false,
/*keepComments*/ true,
/*noResolve*/ false,
/*stripInternal*/ false,
/*stripInternal*/ true,
/*callback*/ function () {
jake.cpR(servicesFile, nodePackageFile, {silent: true});
});

var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var internalNodeDefinitionsFile = path.join(builtLocalDirectory, "typescript_internal.d.ts");
var internalStandaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices_internal.d.ts");
var tempDirPath = path.join(builtLocalDirectory, "temptempdir");
compileFile(nodeDefinitionsFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
/*prefixes*/ undefined,
/*useBuiltCompiler*/ true,
/*noOutFile*/ true,
/*generateDeclarations*/ true,
/*outDir*/ tempDirPath,
/*preserveConstEnums*/ true,
/*keepComments*/ true,
/*noResolve*/ true,
/*stripInternal*/ true,
/*callback*/ function () {
function makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile) {
// Create the standalone definition file
concatenateFiles(standaloneDefinitionsFile, definitionsRoots.map(function (f) {
return path.join(tempDirPath, f);
}));
prependFile(copyright, standaloneDefinitionsFile);

// Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
}
prependFile(copyright, standaloneDefinitionsFile);

// Create the public definition files
makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile);

// Create the internal definition files
makeDefinitionFiles(internalDefinitionsRoots, internalStandaloneDefinitionsFile, internalNodeDefinitionsFile);
// Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
});

// Delete the temp dir
jake.rmRf(tempDirPath, {silent: true});
});

var serverFile = path.join(builtLocalDirectory, "tsserver.js");
compileFile(serverFile, serverSources,[builtLocalDirectory, copyright].concat(serverSources), /*prefixes*/ [copyright], /*useBuiltCompiler*/ true);
Expand DownExpand Up@@ -469,7 +423,7 @@ task("generate-spec", [specMd])
// Makes a new LKG. This target does not build anything, but errors if not all the outputs are present in the built/local directory
desc("Makes a new LKG out of the built js files");
task("LKG", ["clean", "release", "local"].concat(libraryTargets), function() {
var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile, internalNodeDefinitionsFile, internalStandaloneDefinitionsFile].concat(libraryTargets);
var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile].concat(libraryTargets);
var missingFiles = expectedFiles.filter(function (f) {
return !fs.existsSync(f);
});
Expand Down
4 changes: 2 additions & 2 deletions bin/lib.core.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
*/
test(string: string): boolean;

/** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
/** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
source: string;

/** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,4 +1183,4 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
71 changes: 39 additions & 32 deletions bin/lib.core.es6.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
*/
test(string: string): boolean;

/** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
/** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
source: string;

/** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
declare type PropertyKey = string | number | symbol;

interface Symbol {
Expand DownExpand Up@@ -1236,26 +1236,21 @@ interface SymbolConstructor {
*/
isConcatSpreadable: symbol;

/**
* A Boolean value that if true indicates that an object may be used as a regular expression.
*/
isRegExp: symbol;

/**
* A method that returns the default iterator for an object.Called by the semantics of the
* for-of statement.
* for-of statement.
*/
iterator: symbol;

/**
* A method that converts an object to a corresponding primitive value.Called by the ToPrimitive
* abstract operation.
* abstract operation.
*/
toPrimitive: symbol;

/**
* A String value that is used in the creation of the default string description of an object.
* Called by the built-in method Object.prototype.toString.
* A String value that is used in the creation of the default string description of an object.
* Called by the built-in method Object.prototype.toString.
*/
toStringTag: symbol;

Expand DownExpand Up@@ -1297,7 +1292,7 @@ interface ObjectConstructor {
getOwnPropertySymbols(o: any): symbol[];

/**
* Returns true if the values are the same value, false otherwise.
* Returns true if the values are the same value, false otherwise.
* @param value1 The first value.
* @param value2 The second value.
*/
Expand DownExpand Up@@ -1784,8 +1779,6 @@ interface Math {
}

interface RegExp {
[Symbol.isRegExp]: boolean;

/**
* Matches a string with a regular expression, and returns an array containing the results of
* that search.
Expand DownExpand Up@@ -1817,6 +1810,20 @@ interface RegExp {
*/
split(string: string, limit?: number): string[];

/**
* Returns a string indicating the flags of the regular expression in question. This field is read-only.
* The characters in this string are sequenced and concatenated in the following order:
*
* - "g" for global
* - "i" for ignoreCase
* - "m" for multiline
* - "u" for unicode
* - "y" for sticky
*
* If no flags are set, the value is the empty string.
*/
flags: string;

/**
* Returns a Boolean value indicating the state of the sticky flag (y) used with a regular
* expression. Default is false. Read-only.
Expand DownExpand Up@@ -4699,27 +4706,27 @@ interface ProxyHandler<T> {

interface ProxyConstructor {
revocable<T>(target: T, handler: ProxyHandler<T>): { proxy: T; revoke: () => void; };
new <T>(target: T, handeler: ProxyHandler<T>): T
new <T>(target: T, handler: ProxyHandler<T>): T
}
declare var Proxy: ProxyConstructor;

declare var Reflect: {
apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
construct(target: Function, argumentsList: ArrayLike<any>): any;
defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
deleteProperty(target: any, propertyKey: PropertyKey): boolean;
enumerate(target: any): IterableIterator<any>;
get(target: any, propertyKey: PropertyKey, receiver?: any): any;
getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
getPrototypeOf(target: any): any;
has(target: any, propertyKey: string): boolean;
has(target: any, propertyKey: symbol): boolean;
isExtensible(target: any): boolean;
ownKeys(target: any): Array<PropertyKey>;
preventExtensions(target: any): boolean;
set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
setPrototypeOf(target: any, proto: any): boolean;
};
declare module Reflect {
function apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
function construct(target: Function, argumentsList: ArrayLike<any>): any;
function defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
function deleteProperty(target: any, propertyKey: PropertyKey): boolean;
function enumerate(target: any): IterableIterator<any>;
function get(target: any, propertyKey: PropertyKey, receiver?: any): any;
function getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
function getPrototypeOf(target: any): any;
function has(target: any, propertyKey: string): boolean;
function has(target: any, propertyKey: symbol): boolean;
function isExtensible(target: any): boolean;
function ownKeys(target: any): Array<PropertyKey>;
function preventExtensions(target: any): boolean;
function set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
function setPrototypeOf(target: any, proto: any): boolean;
}

/**
* Represents the completion of an asynchronous operation
Expand Down
4 changes: 2 additions & 2 deletions bin/lib.d.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
*/
test(string: string): boolean;

/** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
/** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
source: string;

/** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

/////////////////////////////
/// IE10 ECMAScript Extensions
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Api review cleanup#2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Mohamed Hegazy (mhegazy)
merged 10 commits into

from

Apr 11, 2015
 Merged


Api review cleanup
#2692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
9b0bbf9

Remove step to build typeScript_internal.d.ts


mhegazy Apr 9, 2015
1c91c2c

Mark non-public API surface with the /* @internal */ comment


mhegazy Apr 9, 2015
9fdeffe

Fix formatting and parameter names


mhegazy Apr 9, 2015
e30f0d4

Make version const


mhegazy Apr 9, 2015
97a4c24

Expose parseCommandLine


mhegazy Apr 9, 2015
4a5d3a2

Remove _internal.d.ts files from LKG


mhegazy Apr 9, 2015
03685f4

Update LKG


mhegazy Apr 9, 2015
431dce7

Merge branch 'master' into APIReviewCleanup


mhegazy Apr 10, 2015
13ef271

use @internal comment consistenlly


mhegazy Apr 10, 2015
6f1feff

Update LKG


mhegazy Apr 11, 2015

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


74 changes: 14 additions & 60 deletions
Jakefile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -105,24 +105,6 @@ var serverSources = [
 return path.join(serverDirectory, f);
});

var definitionsRoots = [
 "compiler/types.d.ts",
 "compiler/scanner.d.ts",
 "compiler/parser.d.ts",
 "compiler/checker.d.ts",
 "compiler/program.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/services.d.ts",
];

var internalDefinitionsRoots = [
 "compiler/core.d.ts",
 "compiler/sys.d.ts",
 "compiler/utilities.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/utilities.d.ts",
];

var harnessSources = [
 "harness.ts",
 "sourceMapRecorder.ts",
Expand DownExpand Up@@ -354,60 +336,32 @@ var tscFile = path.join(builtLocalDirectory, compilerFilename);
compileFile(tscFile, compilerSources, [builtLocalDirectory, copyright].concat(compilerSources), [copyright], /*useBuiltCompiler:*/ false);

var servicesFile = path.join(builtLocalDirectory, "typescriptServices.js");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var nodePackageFile = path.join(builtLocalDirectory, "typescript.js");
var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");

compileFile(servicesFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ [copyright],
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ false,
 /*generateDeclarations*/ false,
 /*generateDeclarations*/ true,
 /*outDir*/ undefined,
 /*preserveConstEnums*/ true,
 /*keepComments*/ false,
 /*keepComments*/ true,
 /*noResolve*/ false,
 /*stripInternal*/ false,
 /*stripInternal*/ true,
 /*callback*/ function () { 
 jake.cpR(servicesFile, nodePackageFile, {silent: true});
 });

var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var internalNodeDefinitionsFile = path.join(builtLocalDirectory, "typescript_internal.d.ts");
var internalStandaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices_internal.d.ts");
var tempDirPath = path.join(builtLocalDirectory, "temptempdir");
compileFile(nodeDefinitionsFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ undefined,
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ true,
 /*generateDeclarations*/ true,
 /*outDir*/ tempDirPath,
 /*preserveConstEnums*/ true,
 /*keepComments*/ true,
 /*noResolve*/ true,
 /*stripInternal*/ true,
 /*callback*/ function () {
 function makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile) {
 // Create the standalone definition file
 concatenateFiles(standaloneDefinitionsFile, definitionsRoots.map(function (f) {
 return path.join(tempDirPath, f);
 }));
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 }
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the public definition files
 makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile);

 // Create the internal definition files
 makeDefinitionFiles(internalDefinitionsRoots, internalStandaloneDefinitionsFile, internalNodeDefinitionsFile);
 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 });

 // Delete the temp dir
 jake.rmRf(tempDirPath, {silent: true});
 });

var serverFile = path.join(builtLocalDirectory, "tsserver.js");
compileFile(serverFile, serverSources,[builtLocalDirectory, copyright].concat(serverSources), /*prefixes*/ [copyright], /*useBuiltCompiler*/ true);
Expand DownExpand Up@@ -469,7 +423,7 @@ task("generate-spec", [specMd])
// Makes a new LKG. This target does not build anything, but errors if not all the outputs are present in the built/local directory
desc("Makes a new LKG out of the built js files");
task("LKG", ["clean", "release", "local"].concat(libraryTargets), function() {
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile, internalNodeDefinitionsFile, internalStandaloneDefinitionsFile].concat(libraryTargets);
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile].concat(libraryTargets);
 var missingFiles = expectedFiles.filter(function (f) {
 return !fs.existsSync(f);
 });
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.core.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,4 +1183,4 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

71 changes: 39 additions & 32 deletions
bin/lib.core.es6.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
declare type PropertyKey = string | number | symbol;

interface Symbol {
Expand DownExpand Up@@ -1236,26 +1236,21 @@ interface SymbolConstructor {
 */
 isConcatSpreadable: symbol;

 /** 
 * A Boolean value that if true indicates that an object may be used as a regular expression. 
 */
 isRegExp: symbol;

 /** 
 * A method that returns the default iterator for an object.Called by the semantics of the 
 * for-of statement.
 * for-of statement.
 */
 iterator: symbol;

 /** 
 * A method that converts an object to a corresponding primitive value.Called by the ToPrimitive
 * abstract operation.
 * abstract operation.
 */
 toPrimitive: symbol;

 /** 
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 */
 toStringTag: symbol;

Expand DownExpand Up@@ -1297,7 +1292,7 @@ interface ObjectConstructor {
 getOwnPropertySymbols(o: any): symbol[];

 /**
 * Returns true if the values are the same value, false otherwise.
 * Returns true if the values are the same value, false otherwise.
 * @param value1 The first value.
 * @param value2 The second value.
 */
Expand DownExpand Up@@ -1784,8 +1779,6 @@ interface Math {
}

interface RegExp {
 [Symbol.isRegExp]: boolean;

 /** 
 * Matches a string with a regular expression, and returns an array containing the results of 
 * that search.
Expand DownExpand Up@@ -1817,6 +1810,20 @@ interface RegExp {
 */
 split(string: string, limit?: number): string[];

 /**
 * Returns a string indicating the flags of the regular expression in question. This field is read-only.
 * The characters in this string are sequenced and concatenated in the following order:
 *
 * - "g" for global
 * - "i" for ignoreCase
 * - "m" for multiline
 * - "u" for unicode
 * - "y" for sticky
 *
 * If no flags are set, the value is the empty string.
 */
 flags: string;

 /** 
 * Returns a Boolean value indicating the state of the sticky flag (y) used with a regular 
 * expression. Default is false. Read-only. 
Expand DownExpand Up@@ -4699,27 +4706,27 @@ interface ProxyHandler<T> {

interface ProxyConstructor {
 revocable<T>(target: T, handler: ProxyHandler<T>): { proxy: T; revoke: () => void; };
 new <T>(target: T, handeler: ProxyHandler<T>): T
 new <T>(target: T, handler: ProxyHandler<T>): T
}
declare var Proxy: ProxyConstructor;

declare var Reflect: {
 apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
 construct(target: Function, argumentsList: ArrayLike<any>): any;
 defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
 deleteProperty(target: any, propertyKey: PropertyKey): boolean;
 enumerate(target: any): IterableIterator<any>;
 get(target: any, propertyKey: PropertyKey, receiver?: any): any;
 getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
 getPrototypeOf(target: any): any;
 has(target: any, propertyKey: string): boolean;
 has(target: any, propertyKey: symbol): boolean;
 isExtensible(target: any): boolean;
 ownKeys(target: any): Array<PropertyKey>;
 preventExtensions(target: any): boolean;
 set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
 setPrototypeOf(target: any, proto: any): boolean;
};
declare module Reflect {
function apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
function construct(target: Function, argumentsList: ArrayLike<any>): any;
function defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
function deleteProperty(target: any, propertyKey: PropertyKey): boolean;
function enumerate(target: any): IterableIterator<any>;
function get(target: any, propertyKey: PropertyKey, receiver?: any): any;
function getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
function getPrototypeOf(target: any): any;
function has(target: any, propertyKey: string): boolean;
function has(target: any, propertyKey: symbol): boolean;
function isExtensible(target: any): boolean;
function ownKeys(target: any): Array<PropertyKey>;
function preventExtensions(target: any): boolean;
function set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
function setPrototypeOf(target: any, proto: any): boolean;
}

/**
 * Represents the completion of an asynchronous operation
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

/////////////////////////////
/// IE10 ECMAScript Extensions
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Api review cleanup#2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Mohamed Hegazy (mhegazy)
merged 10 commits into

from

Apr 11, 2015
 Merged


Api review cleanup
#2692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
9b0bbf9

Remove step to build typeScript_internal.d.ts


mhegazy Apr 9, 2015
1c91c2c

Mark non-public API surface with the /* @internal */ comment


mhegazy Apr 9, 2015
9fdeffe

Fix formatting and parameter names


mhegazy Apr 9, 2015
e30f0d4

Make version const


mhegazy Apr 9, 2015
97a4c24

Expose parseCommandLine


mhegazy Apr 9, 2015
4a5d3a2

Remove _internal.d.ts files from LKG


mhegazy Apr 9, 2015
03685f4

Update LKG


mhegazy Apr 9, 2015
431dce7

Merge branch 'master' into APIReviewCleanup


mhegazy Apr 10, 2015
13ef271

use @internal comment consistenlly


mhegazy Apr 10, 2015
6f1feff

Update LKG


mhegazy Apr 11, 2015

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


74 changes: 14 additions & 60 deletions
Jakefile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -105,24 +105,6 @@ var serverSources = [
 return path.join(serverDirectory, f);
});

var definitionsRoots = [
 "compiler/types.d.ts",
 "compiler/scanner.d.ts",
 "compiler/parser.d.ts",
 "compiler/checker.d.ts",
 "compiler/program.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/services.d.ts",
];

var internalDefinitionsRoots = [
 "compiler/core.d.ts",
 "compiler/sys.d.ts",
 "compiler/utilities.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/utilities.d.ts",
];

var harnessSources = [
 "harness.ts",
 "sourceMapRecorder.ts",
Expand DownExpand Up@@ -354,60 +336,32 @@ var tscFile = path.join(builtLocalDirectory, compilerFilename);
compileFile(tscFile, compilerSources, [builtLocalDirectory, copyright].concat(compilerSources), [copyright], /*useBuiltCompiler:*/ false);

var servicesFile = path.join(builtLocalDirectory, "typescriptServices.js");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var nodePackageFile = path.join(builtLocalDirectory, "typescript.js");
var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");

compileFile(servicesFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ [copyright],
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ false,
 /*generateDeclarations*/ false,
 /*generateDeclarations*/ true,
 /*outDir*/ undefined,
 /*preserveConstEnums*/ true,
 /*keepComments*/ false,
 /*keepComments*/ true,
 /*noResolve*/ false,
 /*stripInternal*/ false,
 /*stripInternal*/ true,
 /*callback*/ function () { 
 jake.cpR(servicesFile, nodePackageFile, {silent: true});
 });

var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var internalNodeDefinitionsFile = path.join(builtLocalDirectory, "typescript_internal.d.ts");
var internalStandaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices_internal.d.ts");
var tempDirPath = path.join(builtLocalDirectory, "temptempdir");
compileFile(nodeDefinitionsFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ undefined,
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ true,
 /*generateDeclarations*/ true,
 /*outDir*/ tempDirPath,
 /*preserveConstEnums*/ true,
 /*keepComments*/ true,
 /*noResolve*/ true,
 /*stripInternal*/ true,
 /*callback*/ function () {
 function makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile) {
 // Create the standalone definition file
 concatenateFiles(standaloneDefinitionsFile, definitionsRoots.map(function (f) {
 return path.join(tempDirPath, f);
 }));
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 }
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the public definition files
 makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile);

 // Create the internal definition files
 makeDefinitionFiles(internalDefinitionsRoots, internalStandaloneDefinitionsFile, internalNodeDefinitionsFile);
 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 });

 // Delete the temp dir
 jake.rmRf(tempDirPath, {silent: true});
 });

var serverFile = path.join(builtLocalDirectory, "tsserver.js");
compileFile(serverFile, serverSources,[builtLocalDirectory, copyright].concat(serverSources), /*prefixes*/ [copyright], /*useBuiltCompiler*/ true);
Expand DownExpand Up@@ -469,7 +423,7 @@ task("generate-spec", [specMd])
// Makes a new LKG. This target does not build anything, but errors if not all the outputs are present in the built/local directory
desc("Makes a new LKG out of the built js files");
task("LKG", ["clean", "release", "local"].concat(libraryTargets), function() {
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile, internalNodeDefinitionsFile, internalStandaloneDefinitionsFile].concat(libraryTargets);
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile].concat(libraryTargets);
 var missingFiles = expectedFiles.filter(function (f) {
 return !fs.existsSync(f);
 });
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.core.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,4 +1183,4 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

71 changes: 39 additions & 32 deletions
bin/lib.core.es6.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
declare type PropertyKey = string | number | symbol;

interface Symbol {
Expand DownExpand Up@@ -1236,26 +1236,21 @@ interface SymbolConstructor {
 */
 isConcatSpreadable: symbol;

 /** 
 * A Boolean value that if true indicates that an object may be used as a regular expression. 
 */
 isRegExp: symbol;

 /** 
 * A method that returns the default iterator for an object.Called by the semantics of the 
 * for-of statement.
 * for-of statement.
 */
 iterator: symbol;

 /** 
 * A method that converts an object to a corresponding primitive value.Called by the ToPrimitive
 * abstract operation.
 * abstract operation.
 */
 toPrimitive: symbol;

 /** 
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 */
 toStringTag: symbol;

Expand DownExpand Up@@ -1297,7 +1292,7 @@ interface ObjectConstructor {
 getOwnPropertySymbols(o: any): symbol[];

 /**
 * Returns true if the values are the same value, false otherwise.
 * Returns true if the values are the same value, false otherwise.
 * @param value1 The first value.
 * @param value2 The second value.
 */
Expand DownExpand Up@@ -1784,8 +1779,6 @@ interface Math {
}

interface RegExp {
 [Symbol.isRegExp]: boolean;

 /** 
 * Matches a string with a regular expression, and returns an array containing the results of 
 * that search.
Expand DownExpand Up@@ -1817,6 +1810,20 @@ interface RegExp {
 */
 split(string: string, limit?: number): string[];

 /**
 * Returns a string indicating the flags of the regular expression in question. This field is read-only.
 * The characters in this string are sequenced and concatenated in the following order:
 *
 * - "g" for global
 * - "i" for ignoreCase
 * - "m" for multiline
 * - "u" for unicode
 * - "y" for sticky
 *
 * If no flags are set, the value is the empty string.
 */
 flags: string;

 /** 
 * Returns a Boolean value indicating the state of the sticky flag (y) used with a regular 
 * expression. Default is false. Read-only. 
Expand DownExpand Up@@ -4699,27 +4706,27 @@ interface ProxyHandler<T> {

interface ProxyConstructor {
 revocable<T>(target: T, handler: ProxyHandler<T>): { proxy: T; revoke: () => void; };
 new <T>(target: T, handeler: ProxyHandler<T>): T
 new <T>(target: T, handler: ProxyHandler<T>): T
}
declare var Proxy: ProxyConstructor;

declare var Reflect: {
 apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
 construct(target: Function, argumentsList: ArrayLike<any>): any;
 defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
 deleteProperty(target: any, propertyKey: PropertyKey): boolean;
 enumerate(target: any): IterableIterator<any>;
 get(target: any, propertyKey: PropertyKey, receiver?: any): any;
 getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
 getPrototypeOf(target: any): any;
 has(target: any, propertyKey: string): boolean;
 has(target: any, propertyKey: symbol): boolean;
 isExtensible(target: any): boolean;
 ownKeys(target: any): Array<PropertyKey>;
 preventExtensions(target: any): boolean;
 set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
 setPrototypeOf(target: any, proto: any): boolean;
};
declare module Reflect {
function apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
function construct(target: Function, argumentsList: ArrayLike<any>): any;
function defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
function deleteProperty(target: any, propertyKey: PropertyKey): boolean;
function enumerate(target: any): IterableIterator<any>;
function get(target: any, propertyKey: PropertyKey, receiver?: any): any;
function getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
function getPrototypeOf(target: any): any;
function has(target: any, propertyKey: string): boolean;
function has(target: any, propertyKey: symbol): boolean;
function isExtensible(target: any): boolean;
function ownKeys(target: any): Array<PropertyKey>;
function preventExtensions(target: any): boolean;
function set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
function setPrototypeOf(target: any, proto: any): boolean;
}

/**
 * Represents the completion of an asynchronous operation
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

/////////////////////////////
/// IE10 ECMAScript Extensions
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Api review cleanup#2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Mohamed Hegazy (mhegazy)
merged 10 commits into

from

Apr 11, 2015
 Merged


Api review cleanup
#2692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
9b0bbf9

Remove step to build typeScript_internal.d.ts


mhegazy Apr 9, 2015
1c91c2c

Mark non-public API surface with the /* @internal */ comment


mhegazy Apr 9, 2015
9fdeffe

Fix formatting and parameter names


mhegazy Apr 9, 2015
e30f0d4

Make version const


mhegazy Apr 9, 2015
97a4c24

Expose parseCommandLine


mhegazy Apr 9, 2015
4a5d3a2

Remove _internal.d.ts files from LKG


mhegazy Apr 9, 2015
03685f4

Update LKG


mhegazy Apr 9, 2015
431dce7

Merge branch 'master' into APIReviewCleanup


mhegazy Apr 10, 2015
13ef271

use @internal comment consistenlly


mhegazy Apr 10, 2015
6f1feff

Update LKG


mhegazy Apr 11, 2015

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


74 changes: 14 additions & 60 deletions
Jakefile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -105,24 +105,6 @@ var serverSources = [
 return path.join(serverDirectory, f);
});

var definitionsRoots = [
 "compiler/types.d.ts",
 "compiler/scanner.d.ts",
 "compiler/parser.d.ts",
 "compiler/checker.d.ts",
 "compiler/program.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/services.d.ts",
];

var internalDefinitionsRoots = [
 "compiler/core.d.ts",
 "compiler/sys.d.ts",
 "compiler/utilities.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/utilities.d.ts",
];

var harnessSources = [
 "harness.ts",
 "sourceMapRecorder.ts",
Expand DownExpand Up@@ -354,60 +336,32 @@ var tscFile = path.join(builtLocalDirectory, compilerFilename);
compileFile(tscFile, compilerSources, [builtLocalDirectory, copyright].concat(compilerSources), [copyright], /*useBuiltCompiler:*/ false);

var servicesFile = path.join(builtLocalDirectory, "typescriptServices.js");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var nodePackageFile = path.join(builtLocalDirectory, "typescript.js");
var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");

compileFile(servicesFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ [copyright],
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ false,
 /*generateDeclarations*/ false,
 /*generateDeclarations*/ true,
 /*outDir*/ undefined,
 /*preserveConstEnums*/ true,
 /*keepComments*/ false,
 /*keepComments*/ true,
 /*noResolve*/ false,
 /*stripInternal*/ false,
 /*stripInternal*/ true,
 /*callback*/ function () { 
 jake.cpR(servicesFile, nodePackageFile, {silent: true});
 });

var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var internalNodeDefinitionsFile = path.join(builtLocalDirectory, "typescript_internal.d.ts");
var internalStandaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices_internal.d.ts");
var tempDirPath = path.join(builtLocalDirectory, "temptempdir");
compileFile(nodeDefinitionsFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ undefined,
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ true,
 /*generateDeclarations*/ true,
 /*outDir*/ tempDirPath,
 /*preserveConstEnums*/ true,
 /*keepComments*/ true,
 /*noResolve*/ true,
 /*stripInternal*/ true,
 /*callback*/ function () {
 function makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile) {
 // Create the standalone definition file
 concatenateFiles(standaloneDefinitionsFile, definitionsRoots.map(function (f) {
 return path.join(tempDirPath, f);
 }));
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 }
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the public definition files
 makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile);

 // Create the internal definition files
 makeDefinitionFiles(internalDefinitionsRoots, internalStandaloneDefinitionsFile, internalNodeDefinitionsFile);
 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 });

 // Delete the temp dir
 jake.rmRf(tempDirPath, {silent: true});
 });

var serverFile = path.join(builtLocalDirectory, "tsserver.js");
compileFile(serverFile, serverSources,[builtLocalDirectory, copyright].concat(serverSources), /*prefixes*/ [copyright], /*useBuiltCompiler*/ true);
Expand DownExpand Up@@ -469,7 +423,7 @@ task("generate-spec", [specMd])
// Makes a new LKG. This target does not build anything, but errors if not all the outputs are present in the built/local directory
desc("Makes a new LKG out of the built js files");
task("LKG", ["clean", "release", "local"].concat(libraryTargets), function() {
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile, internalNodeDefinitionsFile, internalStandaloneDefinitionsFile].concat(libraryTargets);
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile].concat(libraryTargets);
 var missingFiles = expectedFiles.filter(function (f) {
 return !fs.existsSync(f);
 });
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.core.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,4 +1183,4 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

71 changes: 39 additions & 32 deletions
bin/lib.core.es6.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
declare type PropertyKey = string | number | symbol;

interface Symbol {
Expand DownExpand Up@@ -1236,26 +1236,21 @@ interface SymbolConstructor {
 */
 isConcatSpreadable: symbol;

 /** 
 * A Boolean value that if true indicates that an object may be used as a regular expression. 
 */
 isRegExp: symbol;

 /** 
 * A method that returns the default iterator for an object.Called by the semantics of the 
 * for-of statement.
 * for-of statement.
 */
 iterator: symbol;

 /** 
 * A method that converts an object to a corresponding primitive value.Called by the ToPrimitive
 * abstract operation.
 * abstract operation.
 */
 toPrimitive: symbol;

 /** 
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 */
 toStringTag: symbol;

Expand DownExpand Up@@ -1297,7 +1292,7 @@ interface ObjectConstructor {
 getOwnPropertySymbols(o: any): symbol[];

 /**
 * Returns true if the values are the same value, false otherwise.
 * Returns true if the values are the same value, false otherwise.
 * @param value1 The first value.
 * @param value2 The second value.
 */
Expand DownExpand Up@@ -1784,8 +1779,6 @@ interface Math {
}

interface RegExp {
 [Symbol.isRegExp]: boolean;

 /** 
 * Matches a string with a regular expression, and returns an array containing the results of 
 * that search.
Expand DownExpand Up@@ -1817,6 +1810,20 @@ interface RegExp {
 */
 split(string: string, limit?: number): string[];

 /**
 * Returns a string indicating the flags of the regular expression in question. This field is read-only.
 * The characters in this string are sequenced and concatenated in the following order:
 *
 * - "g" for global
 * - "i" for ignoreCase
 * - "m" for multiline
 * - "u" for unicode
 * - "y" for sticky
 *
 * If no flags are set, the value is the empty string.
 */
 flags: string;

 /** 
 * Returns a Boolean value indicating the state of the sticky flag (y) used with a regular 
 * expression. Default is false. Read-only. 
Expand DownExpand Up@@ -4699,27 +4706,27 @@ interface ProxyHandler<T> {

interface ProxyConstructor {
 revocable<T>(target: T, handler: ProxyHandler<T>): { proxy: T; revoke: () => void; };
 new <T>(target: T, handeler: ProxyHandler<T>): T
 new <T>(target: T, handler: ProxyHandler<T>): T
}
declare var Proxy: ProxyConstructor;

declare var Reflect: {
 apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
 construct(target: Function, argumentsList: ArrayLike<any>): any;
 defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
 deleteProperty(target: any, propertyKey: PropertyKey): boolean;
 enumerate(target: any): IterableIterator<any>;
 get(target: any, propertyKey: PropertyKey, receiver?: any): any;
 getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
 getPrototypeOf(target: any): any;
 has(target: any, propertyKey: string): boolean;
 has(target: any, propertyKey: symbol): boolean;
 isExtensible(target: any): boolean;
 ownKeys(target: any): Array<PropertyKey>;
 preventExtensions(target: any): boolean;
 set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
 setPrototypeOf(target: any, proto: any): boolean;
};
declare module Reflect {
function apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
function construct(target: Function, argumentsList: ArrayLike<any>): any;
function defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
function deleteProperty(target: any, propertyKey: PropertyKey): boolean;
function enumerate(target: any): IterableIterator<any>;
function get(target: any, propertyKey: PropertyKey, receiver?: any): any;
function getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
function getPrototypeOf(target: any): any;
function has(target: any, propertyKey: string): boolean;
function has(target: any, propertyKey: symbol): boolean;
function isExtensible(target: any): boolean;
function ownKeys(target: any): Array<PropertyKey>;
function preventExtensions(target: any): boolean;
function set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
function setPrototypeOf(target: any, proto: any): boolean;
}

/**
 * Represents the completion of an asynchronous operation
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

/////////////////////////////
/// IE10 ECMAScript Extensions
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Api review cleanup#2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Mohamed Hegazy (mhegazy)
merged 10 commits into

from

Apr 11, 2015
 Merged


Api review cleanup
#2692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
9b0bbf9

Remove step to build typeScript_internal.d.ts


mhegazy Apr 9, 2015
1c91c2c

Mark non-public API surface with the /* @internal */ comment


mhegazy Apr 9, 2015
9fdeffe

Fix formatting and parameter names


mhegazy Apr 9, 2015
e30f0d4

Make version const


mhegazy Apr 9, 2015
97a4c24

Expose parseCommandLine


mhegazy Apr 9, 2015
4a5d3a2

Remove _internal.d.ts files from LKG


mhegazy Apr 9, 2015
03685f4

Update LKG


mhegazy Apr 9, 2015
431dce7

Merge branch 'master' into APIReviewCleanup


mhegazy Apr 10, 2015
13ef271

use @internal comment consistenlly


mhegazy Apr 10, 2015
6f1feff

Update LKG


mhegazy Apr 11, 2015

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


74 changes: 14 additions & 60 deletions
Jakefile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -105,24 +105,6 @@ var serverSources = [
 return path.join(serverDirectory, f);
});

var definitionsRoots = [
 "compiler/types.d.ts",
 "compiler/scanner.d.ts",
 "compiler/parser.d.ts",
 "compiler/checker.d.ts",
 "compiler/program.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/services.d.ts",
];

var internalDefinitionsRoots = [
 "compiler/core.d.ts",
 "compiler/sys.d.ts",
 "compiler/utilities.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/utilities.d.ts",
];

var harnessSources = [
 "harness.ts",
 "sourceMapRecorder.ts",
Expand DownExpand Up@@ -354,60 +336,32 @@ var tscFile = path.join(builtLocalDirectory, compilerFilename);
compileFile(tscFile, compilerSources, [builtLocalDirectory, copyright].concat(compilerSources), [copyright], /*useBuiltCompiler:*/ false);

var servicesFile = path.join(builtLocalDirectory, "typescriptServices.js");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var nodePackageFile = path.join(builtLocalDirectory, "typescript.js");
var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");

compileFile(servicesFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ [copyright],
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ false,
 /*generateDeclarations*/ false,
 /*generateDeclarations*/ true,
 /*outDir*/ undefined,
 /*preserveConstEnums*/ true,
 /*keepComments*/ false,
 /*keepComments*/ true,
 /*noResolve*/ false,
 /*stripInternal*/ false,
 /*stripInternal*/ true,
 /*callback*/ function () { 
 jake.cpR(servicesFile, nodePackageFile, {silent: true});
 });

var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var internalNodeDefinitionsFile = path.join(builtLocalDirectory, "typescript_internal.d.ts");
var internalStandaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices_internal.d.ts");
var tempDirPath = path.join(builtLocalDirectory, "temptempdir");
compileFile(nodeDefinitionsFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ undefined,
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ true,
 /*generateDeclarations*/ true,
 /*outDir*/ tempDirPath,
 /*preserveConstEnums*/ true,
 /*keepComments*/ true,
 /*noResolve*/ true,
 /*stripInternal*/ true,
 /*callback*/ function () {
 function makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile) {
 // Create the standalone definition file
 concatenateFiles(standaloneDefinitionsFile, definitionsRoots.map(function (f) {
 return path.join(tempDirPath, f);
 }));
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 }
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the public definition files
 makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile);

 // Create the internal definition files
 makeDefinitionFiles(internalDefinitionsRoots, internalStandaloneDefinitionsFile, internalNodeDefinitionsFile);
 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 });

 // Delete the temp dir
 jake.rmRf(tempDirPath, {silent: true});
 });

var serverFile = path.join(builtLocalDirectory, "tsserver.js");
compileFile(serverFile, serverSources,[builtLocalDirectory, copyright].concat(serverSources), /*prefixes*/ [copyright], /*useBuiltCompiler*/ true);
Expand DownExpand Up@@ -469,7 +423,7 @@ task("generate-spec", [specMd])
// Makes a new LKG. This target does not build anything, but errors if not all the outputs are present in the built/local directory
desc("Makes a new LKG out of the built js files");
task("LKG", ["clean", "release", "local"].concat(libraryTargets), function() {
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile, internalNodeDefinitionsFile, internalStandaloneDefinitionsFile].concat(libraryTargets);
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile].concat(libraryTargets);
 var missingFiles = expectedFiles.filter(function (f) {
 return !fs.existsSync(f);
 });
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.core.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,4 +1183,4 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

71 changes: 39 additions & 32 deletions
bin/lib.core.es6.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
declare type PropertyKey = string | number | symbol;

interface Symbol {
Expand DownExpand Up@@ -1236,26 +1236,21 @@ interface SymbolConstructor {
 */
 isConcatSpreadable: symbol;

 /** 
 * A Boolean value that if true indicates that an object may be used as a regular expression. 
 */
 isRegExp: symbol;

 /** 
 * A method that returns the default iterator for an object.Called by the semantics of the 
 * for-of statement.
 * for-of statement.
 */
 iterator: symbol;

 /** 
 * A method that converts an object to a corresponding primitive value.Called by the ToPrimitive
 * abstract operation.
 * abstract operation.
 */
 toPrimitive: symbol;

 /** 
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 */
 toStringTag: symbol;

Expand DownExpand Up@@ -1297,7 +1292,7 @@ interface ObjectConstructor {
 getOwnPropertySymbols(o: any): symbol[];

 /**
 * Returns true if the values are the same value, false otherwise.
 * Returns true if the values are the same value, false otherwise.
 * @param value1 The first value.
 * @param value2 The second value.
 */
Expand DownExpand Up@@ -1784,8 +1779,6 @@ interface Math {
}

interface RegExp {
 [Symbol.isRegExp]: boolean;

 /** 
 * Matches a string with a regular expression, and returns an array containing the results of 
 * that search.
Expand DownExpand Up@@ -1817,6 +1810,20 @@ interface RegExp {
 */
 split(string: string, limit?: number): string[];

 /**
 * Returns a string indicating the flags of the regular expression in question. This field is read-only.
 * The characters in this string are sequenced and concatenated in the following order:
 *
 * - "g" for global
 * - "i" for ignoreCase
 * - "m" for multiline
 * - "u" for unicode
 * - "y" for sticky
 *
 * If no flags are set, the value is the empty string.
 */
 flags: string;

 /** 
 * Returns a Boolean value indicating the state of the sticky flag (y) used with a regular 
 * expression. Default is false. Read-only. 
Expand DownExpand Up@@ -4699,27 +4706,27 @@ interface ProxyHandler<T> {

interface ProxyConstructor {
 revocable<T>(target: T, handler: ProxyHandler<T>): { proxy: T; revoke: () => void; };
 new <T>(target: T, handeler: ProxyHandler<T>): T
 new <T>(target: T, handler: ProxyHandler<T>): T
}
declare var Proxy: ProxyConstructor;

declare var Reflect: {
 apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
 construct(target: Function, argumentsList: ArrayLike<any>): any;
 defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
 deleteProperty(target: any, propertyKey: PropertyKey): boolean;
 enumerate(target: any): IterableIterator<any>;
 get(target: any, propertyKey: PropertyKey, receiver?: any): any;
 getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
 getPrototypeOf(target: any): any;
 has(target: any, propertyKey: string): boolean;
 has(target: any, propertyKey: symbol): boolean;
 isExtensible(target: any): boolean;
 ownKeys(target: any): Array<PropertyKey>;
 preventExtensions(target: any): boolean;
 set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
 setPrototypeOf(target: any, proto: any): boolean;
};
declare module Reflect {
function apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
function construct(target: Function, argumentsList: ArrayLike<any>): any;
function defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
function deleteProperty(target: any, propertyKey: PropertyKey): boolean;
function enumerate(target: any): IterableIterator<any>;
function get(target: any, propertyKey: PropertyKey, receiver?: any): any;
function getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
function getPrototypeOf(target: any): any;
function has(target: any, propertyKey: string): boolean;
function has(target: any, propertyKey: symbol): boolean;
function isExtensible(target: any): boolean;
function ownKeys(target: any): Array<PropertyKey>;
function preventExtensions(target: any): boolean;
function set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
function setPrototypeOf(target: any, proto: any): boolean;
}

/**
 * Represents the completion of an asynchronous operation
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

/////////////////////////////
/// IE10 ECMAScript Extensions
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Api review cleanup#2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Mohamed Hegazy (mhegazy)
merged 10 commits into

from

Apr 11, 2015
 Merged


Api review cleanup
#2692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
9b0bbf9

Remove step to build typeScript_internal.d.ts


mhegazy Apr 9, 2015
1c91c2c

Mark non-public API surface with the /* @internal */ comment


mhegazy Apr 9, 2015
9fdeffe

Fix formatting and parameter names


mhegazy Apr 9, 2015
e30f0d4

Make version const


mhegazy Apr 9, 2015
97a4c24

Expose parseCommandLine


mhegazy Apr 9, 2015
4a5d3a2

Remove _internal.d.ts files from LKG


mhegazy Apr 9, 2015
03685f4

Update LKG


mhegazy Apr 9, 2015
431dce7

Merge branch 'master' into APIReviewCleanup


mhegazy Apr 10, 2015
13ef271

use @internal comment consistenlly


mhegazy Apr 10, 2015
6f1feff

Update LKG


mhegazy Apr 11, 2015

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


74 changes: 14 additions & 60 deletions
Jakefile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -105,24 +105,6 @@ var serverSources = [
 return path.join(serverDirectory, f);
});

var definitionsRoots = [
 "compiler/types.d.ts",
 "compiler/scanner.d.ts",
 "compiler/parser.d.ts",
 "compiler/checker.d.ts",
 "compiler/program.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/services.d.ts",
];

var internalDefinitionsRoots = [
 "compiler/core.d.ts",
 "compiler/sys.d.ts",
 "compiler/utilities.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/utilities.d.ts",
];

var harnessSources = [
 "harness.ts",
 "sourceMapRecorder.ts",
Expand DownExpand Up@@ -354,60 +336,32 @@ var tscFile = path.join(builtLocalDirectory, compilerFilename);
compileFile(tscFile, compilerSources, [builtLocalDirectory, copyright].concat(compilerSources), [copyright], /*useBuiltCompiler:*/ false);

var servicesFile = path.join(builtLocalDirectory, "typescriptServices.js");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var nodePackageFile = path.join(builtLocalDirectory, "typescript.js");
var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");

compileFile(servicesFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ [copyright],
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ false,
 /*generateDeclarations*/ false,
 /*generateDeclarations*/ true,
 /*outDir*/ undefined,
 /*preserveConstEnums*/ true,
 /*keepComments*/ false,
 /*keepComments*/ true,
 /*noResolve*/ false,
 /*stripInternal*/ false,
 /*stripInternal*/ true,
 /*callback*/ function () { 
 jake.cpR(servicesFile, nodePackageFile, {silent: true});
 });

var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var internalNodeDefinitionsFile = path.join(builtLocalDirectory, "typescript_internal.d.ts");
var internalStandaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices_internal.d.ts");
var tempDirPath = path.join(builtLocalDirectory, "temptempdir");
compileFile(nodeDefinitionsFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ undefined,
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ true,
 /*generateDeclarations*/ true,
 /*outDir*/ tempDirPath,
 /*preserveConstEnums*/ true,
 /*keepComments*/ true,
 /*noResolve*/ true,
 /*stripInternal*/ true,
 /*callback*/ function () {
 function makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile) {
 // Create the standalone definition file
 concatenateFiles(standaloneDefinitionsFile, definitionsRoots.map(function (f) {
 return path.join(tempDirPath, f);
 }));
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 }
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the public definition files
 makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile);

 // Create the internal definition files
 makeDefinitionFiles(internalDefinitionsRoots, internalStandaloneDefinitionsFile, internalNodeDefinitionsFile);
 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 });

 // Delete the temp dir
 jake.rmRf(tempDirPath, {silent: true});
 });

var serverFile = path.join(builtLocalDirectory, "tsserver.js");
compileFile(serverFile, serverSources,[builtLocalDirectory, copyright].concat(serverSources), /*prefixes*/ [copyright], /*useBuiltCompiler*/ true);
Expand DownExpand Up@@ -469,7 +423,7 @@ task("generate-spec", [specMd])
// Makes a new LKG. This target does not build anything, but errors if not all the outputs are present in the built/local directory
desc("Makes a new LKG out of the built js files");
task("LKG", ["clean", "release", "local"].concat(libraryTargets), function() {
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile, internalNodeDefinitionsFile, internalStandaloneDefinitionsFile].concat(libraryTargets);
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile].concat(libraryTargets);
 var missingFiles = expectedFiles.filter(function (f) {
 return !fs.existsSync(f);
 });
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.core.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,4 +1183,4 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

71 changes: 39 additions & 32 deletions
bin/lib.core.es6.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
declare type PropertyKey = string | number | symbol;

interface Symbol {
Expand DownExpand Up@@ -1236,26 +1236,21 @@ interface SymbolConstructor {
 */
 isConcatSpreadable: symbol;

 /** 
 * A Boolean value that if true indicates that an object may be used as a regular expression. 
 */
 isRegExp: symbol;

 /** 
 * A method that returns the default iterator for an object.Called by the semantics of the 
 * for-of statement.
 * for-of statement.
 */
 iterator: symbol;

 /** 
 * A method that converts an object to a corresponding primitive value.Called by the ToPrimitive
 * abstract operation.
 * abstract operation.
 */
 toPrimitive: symbol;

 /** 
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 */
 toStringTag: symbol;

Expand DownExpand Up@@ -1297,7 +1292,7 @@ interface ObjectConstructor {
 getOwnPropertySymbols(o: any): symbol[];

 /**
 * Returns true if the values are the same value, false otherwise.
 * Returns true if the values are the same value, false otherwise.
 * @param value1 The first value.
 * @param value2 The second value.
 */
Expand DownExpand Up@@ -1784,8 +1779,6 @@ interface Math {
}

interface RegExp {
 [Symbol.isRegExp]: boolean;

 /** 
 * Matches a string with a regular expression, and returns an array containing the results of 
 * that search.
Expand DownExpand Up@@ -1817,6 +1810,20 @@ interface RegExp {
 */
 split(string: string, limit?: number): string[];

 /**
 * Returns a string indicating the flags of the regular expression in question. This field is read-only.
 * The characters in this string are sequenced and concatenated in the following order:
 *
 * - "g" for global
 * - "i" for ignoreCase
 * - "m" for multiline
 * - "u" for unicode
 * - "y" for sticky
 *
 * If no flags are set, the value is the empty string.
 */
 flags: string;

 /** 
 * Returns a Boolean value indicating the state of the sticky flag (y) used with a regular 
 * expression. Default is false. Read-only. 
Expand DownExpand Up@@ -4699,27 +4706,27 @@ interface ProxyHandler<T> {

interface ProxyConstructor {
 revocable<T>(target: T, handler: ProxyHandler<T>): { proxy: T; revoke: () => void; };
 new <T>(target: T, handeler: ProxyHandler<T>): T
 new <T>(target: T, handler: ProxyHandler<T>): T
}
declare var Proxy: ProxyConstructor;

declare var Reflect: {
 apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
 construct(target: Function, argumentsList: ArrayLike<any>): any;
 defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
 deleteProperty(target: any, propertyKey: PropertyKey): boolean;
 enumerate(target: any): IterableIterator<any>;
 get(target: any, propertyKey: PropertyKey, receiver?: any): any;
 getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
 getPrototypeOf(target: any): any;
 has(target: any, propertyKey: string): boolean;
 has(target: any, propertyKey: symbol): boolean;
 isExtensible(target: any): boolean;
 ownKeys(target: any): Array<PropertyKey>;
 preventExtensions(target: any): boolean;
 set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
 setPrototypeOf(target: any, proto: any): boolean;
};
declare module Reflect {
function apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
function construct(target: Function, argumentsList: ArrayLike<any>): any;
function defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
function deleteProperty(target: any, propertyKey: PropertyKey): boolean;
function enumerate(target: any): IterableIterator<any>;
function get(target: any, propertyKey: PropertyKey, receiver?: any): any;
function getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
function getPrototypeOf(target: any): any;
function has(target: any, propertyKey: string): boolean;
function has(target: any, propertyKey: symbol): boolean;
function isExtensible(target: any): boolean;
function ownKeys(target: any): Array<PropertyKey>;
function preventExtensions(target: any): boolean;
function set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
function setPrototypeOf(target: any, proto: any): boolean;
}

/**
 * Represents the completion of an asynchronous operation
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

/////////////////////////////
/// IE10 ECMAScript Extensions
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Api review cleanup#2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Mohamed Hegazy (mhegazy)
merged 10 commits into

from

Apr 11, 2015
 Merged


Api review cleanup
#2692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
9b0bbf9

Remove step to build typeScript_internal.d.ts


mhegazy Apr 9, 2015
1c91c2c

Mark non-public API surface with the /* @internal */ comment


mhegazy Apr 9, 2015
9fdeffe

Fix formatting and parameter names


mhegazy Apr 9, 2015
e30f0d4

Make version const


mhegazy Apr 9, 2015
97a4c24

Expose parseCommandLine


mhegazy Apr 9, 2015
4a5d3a2

Remove _internal.d.ts files from LKG


mhegazy Apr 9, 2015
03685f4

Update LKG


mhegazy Apr 9, 2015
431dce7

Merge branch 'master' into APIReviewCleanup


mhegazy Apr 10, 2015
13ef271

use @internal comment consistenlly


mhegazy Apr 10, 2015
6f1feff

Update LKG


mhegazy Apr 11, 2015

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


74 changes: 14 additions & 60 deletions
Jakefile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -105,24 +105,6 @@ var serverSources = [
 return path.join(serverDirectory, f);
});

var definitionsRoots = [
 "compiler/types.d.ts",
 "compiler/scanner.d.ts",
 "compiler/parser.d.ts",
 "compiler/checker.d.ts",
 "compiler/program.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/services.d.ts",
];

var internalDefinitionsRoots = [
 "compiler/core.d.ts",
 "compiler/sys.d.ts",
 "compiler/utilities.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/utilities.d.ts",
];

var harnessSources = [
 "harness.ts",
 "sourceMapRecorder.ts",
Expand DownExpand Up@@ -354,60 +336,32 @@ var tscFile = path.join(builtLocalDirectory, compilerFilename);
compileFile(tscFile, compilerSources, [builtLocalDirectory, copyright].concat(compilerSources), [copyright], /*useBuiltCompiler:*/ false);

var servicesFile = path.join(builtLocalDirectory, "typescriptServices.js");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var nodePackageFile = path.join(builtLocalDirectory, "typescript.js");
var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");

compileFile(servicesFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ [copyright],
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ false,
 /*generateDeclarations*/ false,
 /*generateDeclarations*/ true,
 /*outDir*/ undefined,
 /*preserveConstEnums*/ true,
 /*keepComments*/ false,
 /*keepComments*/ true,
 /*noResolve*/ false,
 /*stripInternal*/ false,
 /*stripInternal*/ true,
 /*callback*/ function () { 
 jake.cpR(servicesFile, nodePackageFile, {silent: true});
 });

var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var internalNodeDefinitionsFile = path.join(builtLocalDirectory, "typescript_internal.d.ts");
var internalStandaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices_internal.d.ts");
var tempDirPath = path.join(builtLocalDirectory, "temptempdir");
compileFile(nodeDefinitionsFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ undefined,
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ true,
 /*generateDeclarations*/ true,
 /*outDir*/ tempDirPath,
 /*preserveConstEnums*/ true,
 /*keepComments*/ true,
 /*noResolve*/ true,
 /*stripInternal*/ true,
 /*callback*/ function () {
 function makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile) {
 // Create the standalone definition file
 concatenateFiles(standaloneDefinitionsFile, definitionsRoots.map(function (f) {
 return path.join(tempDirPath, f);
 }));
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 }
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the public definition files
 makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile);

 // Create the internal definition files
 makeDefinitionFiles(internalDefinitionsRoots, internalStandaloneDefinitionsFile, internalNodeDefinitionsFile);
 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 });

 // Delete the temp dir
 jake.rmRf(tempDirPath, {silent: true});
 });

var serverFile = path.join(builtLocalDirectory, "tsserver.js");
compileFile(serverFile, serverSources,[builtLocalDirectory, copyright].concat(serverSources), /*prefixes*/ [copyright], /*useBuiltCompiler*/ true);
Expand DownExpand Up@@ -469,7 +423,7 @@ task("generate-spec", [specMd])
// Makes a new LKG. This target does not build anything, but errors if not all the outputs are present in the built/local directory
desc("Makes a new LKG out of the built js files");
task("LKG", ["clean", "release", "local"].concat(libraryTargets), function() {
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile, internalNodeDefinitionsFile, internalStandaloneDefinitionsFile].concat(libraryTargets);
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile].concat(libraryTargets);
 var missingFiles = expectedFiles.filter(function (f) {
 return !fs.existsSync(f);
 });
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.core.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,4 +1183,4 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

71 changes: 39 additions & 32 deletions
bin/lib.core.es6.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
declare type PropertyKey = string | number | symbol;

interface Symbol {
Expand DownExpand Up@@ -1236,26 +1236,21 @@ interface SymbolConstructor {
 */
 isConcatSpreadable: symbol;

 /** 
 * A Boolean value that if true indicates that an object may be used as a regular expression. 
 */
 isRegExp: symbol;

 /** 
 * A method that returns the default iterator for an object.Called by the semantics of the 
 * for-of statement.
 * for-of statement.
 */
 iterator: symbol;

 /** 
 * A method that converts an object to a corresponding primitive value.Called by the ToPrimitive
 * abstract operation.
 * abstract operation.
 */
 toPrimitive: symbol;

 /** 
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 */
 toStringTag: symbol;

Expand DownExpand Up@@ -1297,7 +1292,7 @@ interface ObjectConstructor {
 getOwnPropertySymbols(o: any): symbol[];

 /**
 * Returns true if the values are the same value, false otherwise.
 * Returns true if the values are the same value, false otherwise.
 * @param value1 The first value.
 * @param value2 The second value.
 */
Expand DownExpand Up@@ -1784,8 +1779,6 @@ interface Math {
}

interface RegExp {
 [Symbol.isRegExp]: boolean;

 /** 
 * Matches a string with a regular expression, and returns an array containing the results of 
 * that search.
Expand DownExpand Up@@ -1817,6 +1810,20 @@ interface RegExp {
 */
 split(string: string, limit?: number): string[];

 /**
 * Returns a string indicating the flags of the regular expression in question. This field is read-only.
 * The characters in this string are sequenced and concatenated in the following order:
 *
 * - "g" for global
 * - "i" for ignoreCase
 * - "m" for multiline
 * - "u" for unicode
 * - "y" for sticky
 *
 * If no flags are set, the value is the empty string.
 */
 flags: string;

 /** 
 * Returns a Boolean value indicating the state of the sticky flag (y) used with a regular 
 * expression. Default is false. Read-only. 
Expand DownExpand Up@@ -4699,27 +4706,27 @@ interface ProxyHandler<T> {

interface ProxyConstructor {
 revocable<T>(target: T, handler: ProxyHandler<T>): { proxy: T; revoke: () => void; };
 new <T>(target: T, handeler: ProxyHandler<T>): T
 new <T>(target: T, handler: ProxyHandler<T>): T
}
declare var Proxy: ProxyConstructor;

declare var Reflect: {
 apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
 construct(target: Function, argumentsList: ArrayLike<any>): any;
 defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
 deleteProperty(target: any, propertyKey: PropertyKey): boolean;
 enumerate(target: any): IterableIterator<any>;
 get(target: any, propertyKey: PropertyKey, receiver?: any): any;
 getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
 getPrototypeOf(target: any): any;
 has(target: any, propertyKey: string): boolean;
 has(target: any, propertyKey: symbol): boolean;
 isExtensible(target: any): boolean;
 ownKeys(target: any): Array<PropertyKey>;
 preventExtensions(target: any): boolean;
 set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
 setPrototypeOf(target: any, proto: any): boolean;
};
declare module Reflect {
function apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
function construct(target: Function, argumentsList: ArrayLike<any>): any;
function defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
function deleteProperty(target: any, propertyKey: PropertyKey): boolean;
function enumerate(target: any): IterableIterator<any>;
function get(target: any, propertyKey: PropertyKey, receiver?: any): any;
function getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
function getPrototypeOf(target: any): any;
function has(target: any, propertyKey: string): boolean;
function has(target: any, propertyKey: symbol): boolean;
function isExtensible(target: any): boolean;
function ownKeys(target: any): Array<PropertyKey>;
function preventExtensions(target: any): boolean;
function set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
function setPrototypeOf(target: any, proto: any): boolean;
}

/**
 * Represents the completion of an asynchronous operation
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

/////////////////////////////
/// IE10 ECMAScript Extensions
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Api review cleanup#2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Mohamed Hegazy (mhegazy)
merged 10 commits into

from

Apr 11, 2015
 Merged


Api review cleanup
#2692
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


10 commits


Select commit
Hold shift + click to select a range
9b0bbf9

Remove step to build typeScript_internal.d.ts


mhegazy Apr 9, 2015
1c91c2c

Mark non-public API surface with the /* @internal */ comment


mhegazy Apr 9, 2015
9fdeffe

Fix formatting and parameter names


mhegazy Apr 9, 2015
e30f0d4

Make version const


mhegazy Apr 9, 2015
97a4c24

Expose parseCommandLine


mhegazy Apr 9, 2015
4a5d3a2

Remove _internal.d.ts files from LKG


mhegazy Apr 9, 2015
03685f4

Update LKG


mhegazy Apr 9, 2015
431dce7

Merge branch 'master' into APIReviewCleanup


mhegazy Apr 10, 2015
13ef271

use @internal comment consistenlly


mhegazy Apr 10, 2015
6f1feff

Update LKG


mhegazy Apr 11, 2015

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


74 changes: 14 additions & 60 deletions
Jakefile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -105,24 +105,6 @@ var serverSources = [
 return path.join(serverDirectory, f);
});

var definitionsRoots = [
 "compiler/types.d.ts",
 "compiler/scanner.d.ts",
 "compiler/parser.d.ts",
 "compiler/checker.d.ts",
 "compiler/program.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/services.d.ts",
];

var internalDefinitionsRoots = [
 "compiler/core.d.ts",
 "compiler/sys.d.ts",
 "compiler/utilities.d.ts",
 "compiler/commandLineParser.d.ts",
 "services/utilities.d.ts",
];

var harnessSources = [
 "harness.ts",
 "sourceMapRecorder.ts",
Expand DownExpand Up@@ -354,60 +336,32 @@ var tscFile = path.join(builtLocalDirectory, compilerFilename);
compileFile(tscFile, compilerSources, [builtLocalDirectory, copyright].concat(compilerSources), [copyright], /*useBuiltCompiler:*/ false);

var servicesFile = path.join(builtLocalDirectory, "typescriptServices.js");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var nodePackageFile = path.join(builtLocalDirectory, "typescript.js");
var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");

compileFile(servicesFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ [copyright],
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ false,
 /*generateDeclarations*/ false,
 /*generateDeclarations*/ true,
 /*outDir*/ undefined,
 /*preserveConstEnums*/ true,
 /*keepComments*/ false,
 /*keepComments*/ true,
 /*noResolve*/ false,
 /*stripInternal*/ false,
 /*stripInternal*/ true,
 /*callback*/ function () { 
 jake.cpR(servicesFile, nodePackageFile, {silent: true});
 });

var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
var internalNodeDefinitionsFile = path.join(builtLocalDirectory, "typescript_internal.d.ts");
var internalStandaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices_internal.d.ts");
var tempDirPath = path.join(builtLocalDirectory, "temptempdir");
compileFile(nodeDefinitionsFile, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
 /*prefixes*/ undefined,
 /*useBuiltCompiler*/ true,
 /*noOutFile*/ true,
 /*generateDeclarations*/ true,
 /*outDir*/ tempDirPath,
 /*preserveConstEnums*/ true,
 /*keepComments*/ true,
 /*noResolve*/ true,
 /*stripInternal*/ true,
 /*callback*/ function () {
 function makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile) {
 // Create the standalone definition file
 concatenateFiles(standaloneDefinitionsFile, definitionsRoots.map(function (f) {
 return path.join(tempDirPath, f);
 }));
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 }
 prependFile(copyright, standaloneDefinitionsFile);

 // Create the public definition files
 makeDefinitionFiles(definitionsRoots, standaloneDefinitionsFile, nodeDefinitionsFile);

 // Create the internal definition files
 makeDefinitionFiles(internalDefinitionsRoots, internalStandaloneDefinitionsFile, internalNodeDefinitionsFile);
 // Create the node definition file by replacing 'ts' module with '"typescript"' as a module.
 jake.cpR(standaloneDefinitionsFile, nodeDefinitionsFile, {silent: true});
 var definitionFileContents = fs.readFileSync(nodeDefinitionsFile).toString();
 definitionFileContents = definitionFileContents.replace(/declare module ts/g, 'declare module "typescript"');
 fs.writeFileSync(nodeDefinitionsFile, definitionFileContents);
 });

 // Delete the temp dir
 jake.rmRf(tempDirPath, {silent: true});
 });

var serverFile = path.join(builtLocalDirectory, "tsserver.js");
compileFile(serverFile, serverSources,[builtLocalDirectory, copyright].concat(serverSources), /*prefixes*/ [copyright], /*useBuiltCompiler*/ true);
Expand DownExpand Up@@ -469,7 +423,7 @@ task("generate-spec", [specMd])
// Makes a new LKG. This target does not build anything, but errors if not all the outputs are present in the built/local directory
desc("Makes a new LKG out of the built js files");
task("LKG", ["clean", "release", "local"].concat(libraryTargets), function() {
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile, internalNodeDefinitionsFile, internalStandaloneDefinitionsFile].concat(libraryTargets);
 var expectedFiles = [tscFile, servicesFile, serverFile, nodePackageFile, nodeDefinitionsFile, standaloneDefinitionsFile].concat(libraryTargets);
 var missingFiles = expectedFiles.filter(function (f) {
 return !fs.existsSync(f);
 });
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.core.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,4 +1183,4 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

71 changes: 39 additions & 32 deletions
bin/lib.core.es6.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;
declare type PropertyKey = string | number | symbol;

interface Symbol {
Expand DownExpand Up@@ -1236,26 +1236,21 @@ interface SymbolConstructor {
 */
 isConcatSpreadable: symbol;

 /** 
 * A Boolean value that if true indicates that an object may be used as a regular expression. 
 */
 isRegExp: symbol;

 /** 
 * A method that returns the default iterator for an object.Called by the semantics of the 
 * for-of statement.
 * for-of statement.
 */
 iterator: symbol;

 /** 
 * A method that converts an object to a corresponding primitive value.Called by the ToPrimitive
 * abstract operation.
 * abstract operation.
 */
 toPrimitive: symbol;

 /** 
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 * A String value that is used in the creation of the default string description of an object.
 * Called by the built-in method Object.prototype.toString.
 */
 toStringTag: symbol;

Expand DownExpand Up@@ -1297,7 +1292,7 @@ interface ObjectConstructor {
 getOwnPropertySymbols(o: any): symbol[];

 /**
 * Returns true if the values are the same value, false otherwise.
 * Returns true if the values are the same value, false otherwise.
 * @param value1 The first value.
 * @param value2 The second value.
 */
Expand DownExpand Up@@ -1784,8 +1779,6 @@ interface Math {
}

interface RegExp {
 [Symbol.isRegExp]: boolean;

 /** 
 * Matches a string with a regular expression, and returns an array containing the results of 
 * that search.
Expand DownExpand Up@@ -1817,6 +1810,20 @@ interface RegExp {
 */
 split(string: string, limit?: number): string[];

 /**
 * Returns a string indicating the flags of the regular expression in question. This field is read-only.
 * The characters in this string are sequenced and concatenated in the following order:
 *
 * - "g" for global
 * - "i" for ignoreCase
 * - "m" for multiline
 * - "u" for unicode
 * - "y" for sticky
 *
 * If no flags are set, the value is the empty string.
 */
 flags: string;

 /** 
 * Returns a Boolean value indicating the state of the sticky flag (y) used with a regular 
 * expression. Default is false. Read-only. 
Expand DownExpand Up@@ -4699,27 +4706,27 @@ interface ProxyHandler<T> {

interface ProxyConstructor {
 revocable<T>(target: T, handler: ProxyHandler<T>): { proxy: T; revoke: () => void; };
 new <T>(target: T, handeler: ProxyHandler<T>): T
 new <T>(target: T, handler: ProxyHandler<T>): T
}
declare var Proxy: ProxyConstructor;

declare var Reflect: {
 apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
 construct(target: Function, argumentsList: ArrayLike<any>): any;
 defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
 deleteProperty(target: any, propertyKey: PropertyKey): boolean;
 enumerate(target: any): IterableIterator<any>;
 get(target: any, propertyKey: PropertyKey, receiver?: any): any;
 getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
 getPrototypeOf(target: any): any;
 has(target: any, propertyKey: string): boolean;
 has(target: any, propertyKey: symbol): boolean;
 isExtensible(target: any): boolean;
 ownKeys(target: any): Array<PropertyKey>;
 preventExtensions(target: any): boolean;
 set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
 setPrototypeOf(target: any, proto: any): boolean;
};
declare module Reflect {
function apply(target: Function, thisArgument: any, argumentsList: ArrayLike<any>): any;
function construct(target: Function, argumentsList: ArrayLike<any>): any;
function defineProperty(target: any, propertyKey: PropertyKey, attributes: PropertyDescriptor): boolean;
function deleteProperty(target: any, propertyKey: PropertyKey): boolean;
function enumerate(target: any): IterableIterator<any>;
function get(target: any, propertyKey: PropertyKey, receiver?: any): any;
function getOwnPropertyDescriptor(target: any, propertyKey: PropertyKey): PropertyDescriptor;
function getPrototypeOf(target: any): any;
function has(target: any, propertyKey: string): boolean;
function has(target: any, propertyKey: symbol): boolean;
function isExtensible(target: any): boolean;
function ownKeys(target: any): Array<PropertyKey>;
function preventExtensions(target: any): boolean;
function set(target: any, propertyKey: PropertyKey, value: any, receiver? :any): boolean;
function setPrototypeOf(target: any, proto: any): boolean;
}

/**
 * Represents the completion of an asynchronous operation
Expand Down

4 changes: 2 additions & 2 deletions
bin/lib.d.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -838,7 +838,7 @@ interface RegExp {
 */
 test(string: string): boolean;

 /** Returns a copy of the text of the regular expression pattern. Read-only. The rgExp argument is a Regular expression object. It can be a variable name or a literal. */
 /** Returns a copy of the text of the regular expression pattern. Read-only. The regExp argument is a Regular expression object. It can be a variable name or a literal. */
 source: string;

 /** Returns a Boolean value indicating the state of the global flag (g) used with a regular expression. Default is false. Read-only. */
Expand DownExpand Up@@ -1183,7 +1183,7 @@ interface TypedPropertyDescriptor<T> {
declare type ClassDecorator = <TFunction extends Function>(target: TFunction) => TFunction | void;
declare type PropertyDecorator = (target: Object, propertyKey: string | symbol) => void;
declare type MethodDecorator = <T>(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<T>) => TypedPropertyDescriptor<T> | void;
declare type ParameterDecorator = (target: Function, propertyKey: string | symbol, parameterIndex: number) => void;
declare type ParameterDecorator = (target: Object, propertyKey: string | symbol, parameterIndex: number) => void;

/////////////////////////////
/// IE10 ECMAScript Extensions
Expand Down
Loading