Uh oh!
There was an error while loading. Please reload this page.
Add es3.d.ts - #28372
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Eric Robinson (ericdrobinson)
commented
Nov 13, 2018
Am I missing something or is the current setup one that would have an Unless I'm missing something, the current |
Eric Robinson (@ericdrobinson) The OP says:
Moving all in once is doable but generates tons of baseline changes, which will make this PR hard to review. I want to get some review about code changes first and then move remaining types. |
3b6a3a4 to
88fe948Comparefecbd7a to
371a634CompareRyan Cavanaugh (RyanCavanaugh)
commented
Aug 21, 2019
In the intervening years since #2410 was logged, pretty much all the ES3 targets have died out (even the use cases identified most recently don't even really count as a true ES3 target). Something we should have realized four years ago was that this would be a breaking change! Anyone targeting ES3 but using ES5 APIs (which is an entirely reasonable state to find yourself in if your actual runtime is ES5 and you're not using getters/setters, or if you're using polyfills) is going to be broken if we merge this and make So given the relative lack of remaining use cases for this, and the fact that to preserve back compat we'd have to make this an opt-in that you can effectively already achieve today with |
Attila Hajdrik (attilah)
commented
Jan 30, 2023
Ryan Cavanaugh (@RyanCavanaugh) FYI Salesforce Marketing Cloud is using an ES3 compatible language set for (Jint is their JS runtime) their SSJS language. |
Eric Robinson (ericdrobinson)
commented
Feb 4, 2023
Attila Hajdrik (@attilah) You might want to mention that over on #51909 which is explicitly about the ES3 target deprecation coming in TypeScript 5.0 (removal planned for 5.5). |
Revives #16077
Fixes#2410
Fixes#15978
Intentionally included only NaN in es3.d.ts to initially generate minimal baseline changes.