Skip to content

Remove jake (hopefully for real this time) - #29085

Merged
Wesley Wigham (weswigham) merged 5 commits into
microsoft:masterfrom
weswigham:rm-jake
Feb 20, 2019
Merged

Remove jake (hopefully for real this time)#29085
Wesley Wigham (weswigham) merged 5 commits into
microsoft:masterfrom
weswigham:rm-jake

Conversation

@weswigham

@weswighamWesley Wigham (weswigham) commented Dec 18, 2018

Copy link
Copy Markdown
Member

A couple of our build tasks will need to be updated, too; but I think this should be all that's needed in TS itself.

@weswigham

Wesley Wigham (weswigham) commented Dec 18, 2018

Copy link
Copy Markdown
MemberAuthor

Oooooo that feeling when you put async functions in the gulpfile but node 6 doesn't support them natively. Ron Buckton (@rbuckton) got a preference on how to handle that?

@sandersn

Nathan Shively-Sanders (sandersn) commented Dec 18, 2018

Copy link
Copy Markdown
Member

I would like to keep jake around until

> gulp
> gulp

Has the second invocation run fast, just like jake does today.

@weswigham

Wesley Wigham (weswigham) commented Dec 18, 2018

Copy link
Copy Markdown
MemberAuthor

node 6 is in LTS until april, BTW. So April is roughly when we'll be OK ceasing to build on it.

@weswigham

Wesley Wigham (weswigham) commented Dec 19, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Well...
Now that's true. (re: multiple gulp invocations being slower)

@sandersn

Nathan Shively-Sanders (sandersn) commented Jan 17, 2019

Copy link
Copy Markdown
Member

This should wait on gulp (and gulp local if different) correctly building built/local/tsserver.js

@weswigham

Wesley Wigham (weswigham) commented Jan 17, 2019

Copy link
Copy Markdown
MemberAuthor

Nathan Shively-Sanders (@sandersn) See #29447 😛

@rbuckton

Ron Buckton (rbuckton) commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

Do you need to add the change to support using LKG on CI that we added to jake?

@weswigham

Wesley Wigham (weswigham) commented Feb 13, 2019

Copy link
Copy Markdown
MemberAuthor

I'm doing something a little different - one second, just validating it a bit.

@weswigham
Fix gulpfile non-lkg build, add sanity-check build to posttest on CI,…
cab7e3c
… accept older baseline style to go with lkgd build
@weswigham

Wesley Wigham (weswigham) commented Feb 13, 2019

Copy link
Copy Markdown
MemberAuthor

There we go - rather than disabling lkg on CI (which leads to frustrating test diffs locally), I'm now running a sanity check built/local build on CI only after tests pass.

@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 13, 2019

Copy link
Copy Markdown
Member

Node 6 is now out in favour of node 11, so that's one more obstacle out of the way.

@weswigham

Wesley Wigham (weswigham) commented Feb 13, 2019

Copy link
Copy Markdown
MemberAuthor

Alright, looks like everything is now green. Anyone wanna peek over the CI logs to see that you're OK with the now gulp-based ones and give this the 👍?

@weswighamWesley Wigham (weswigham) mentioned this pull request Feb 14, 2019
Merged
rbuckton
Ron Buckton (rbuckton) approved these changes Feb 14, 2019
View reviewed changes
Comment threadtests/baselines/reference/api/tsserverlibrary.d.ts
private typeAcquisition;
updateGraph(): boolean;
getExcludedFiles(): readonly NormalizedPath[];
getExcludedFiles(): ReadonlyArray<NormalizedPath>;

@rbucktonRon Buckton (rbuckton)Feb 14, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this had already been addressed in #29783?

@weswighamWesley Wigham (weswigham)Feb 14, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I un-addressed it to make the nightlies build again.

@weswigham

Wesley Wigham (weswigham) commented Feb 20, 2019

Copy link
Copy Markdown
MemberAuthor

Alright. All build pipelines are on gulp-based scripts and the sync script for VS is setup to use gulp, too. Once this build passes now that I've synced with master and resolved the package.json conflict, I plan to merge this. That should unblock merging user suite PRs verbatim, and make the code coverage pipeline green again. This PR's been up for a week since approval, but if anyone has any final words before this merges, the next hour or so is what's left (barring catastrophic failures requiring a revert).

@weswigham
Wesley Wigham (weswigham) merged commit b67f2d6 into microsoft:masterFeb 20, 2019
@Kingwl

Wenlu Wang (Kingwl) commented Feb 21, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Wooo, it‘’s scared me.（bye jake）

Closed
@alexeagle

Alex Eagle (alexeagle) commented Mar 8, 2019

Copy link
Copy Markdown
Contributor

Wesley Wigham (@weswigham) how do you have incremental builds now?

@weswigham

Wesley Wigham (weswigham) commented Mar 9, 2019

Copy link
Copy Markdown
MemberAuthor

Our gulpfile is shelling out to tsc -b and not using gulp-typescript is how. 😐

@microsoftMicrosoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersnNathan Shively-Sanders (sandersn)sandersn approved these changes
@ahejlsbergAnders Hejlsberg (ahejlsberg)Awaiting requested review from ahejlsberg
+1 more reviewer
@rbucktonRon Buckton (rbuckton)rbuckton approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@weswighamWesley Wigham (weswigham)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@weswigham@sandersn@rbuckton@Kingwl@alexeagle